BlockId removal: refactor: HeaderBackend::header (#1977)

* BlockId removal: refactor: HeaderBackend::header

It changes the arguments of:
- `HeaderBackend::header`,
- `Client::header`

methods from: `BlockId<Block>` to: `Block::Hash`

This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292)

* update lockfile for {"polkadot", "substrate"}

Co-authored-by: parity-processbot <>
This commit is contained in:
Michal Kucharczyk
2022-12-20 13:46:44 +01:00
committed by GitHub
parent 29175bb984
commit b7dff85939
5 changed files with 321 additions and 406 deletions
+17 -13
View File
@@ -82,7 +82,10 @@ mod tests {
ValidationParams,
};
use cumulus_test_relay_sproof_builder::RelayStateSproofBuilder;
use sp_runtime::{generic::BlockId, traits::Header as HeaderT};
use sp_runtime::{
generic::BlockId,
traits::{Block as BlockT, Header as HeaderT},
};
use std::{env, process::Command, str::FromStr};
const SLOT_DURATION: u64 = 6000;
@@ -106,14 +109,14 @@ mod tests {
fn build_block(
client: &Client,
at: BlockId<Block>,
hash: <Block as BlockT>::Hash,
timestamp: u64,
relay_chain_slot: Slot,
) -> (ParachainBlockData, PHash) {
let sproof_builder =
RelayStateSproofBuilder { current_slot: relay_chain_slot, ..Default::default() };
let parent_header = client.header(&at).ok().flatten().expect("Genesis header exists");
let parent_header = client.header(hash).ok().flatten().expect("Genesis header exists");
let relay_parent_storage_root = sproof_builder.clone().into_state_root_and_proof().0;
@@ -125,7 +128,7 @@ mod tests {
let block = client
.init_block_builder_with_timestamp(
&at,
&BlockId::Hash(hash),
Some(validation_data),
sproof_builder,
timestamp,
@@ -146,19 +149,20 @@ mod tests {
.expect("TIMESTAMP is a valid `u64`");
let block =
build_block(&client, BlockId::number(0), SLOT_DURATION, 1.into()).0.into_block();
futures::executor::block_on(client.import(sp_consensus::BlockOrigin::Own, block))
.unwrap();
build_block(&client, client.chain_info().genesis_hash, SLOT_DURATION, 1.into())
.0
.into_block();
futures::executor::block_on(
client.import(sp_consensus::BlockOrigin::Own, block.clone()),
)
.unwrap();
let hashof1 = block.hash();
let (block, relay_chain_root) =
build_block(&client, BlockId::number(1), timestamp, relay_chain_slot.into());
build_block(&client, hashof1, timestamp, relay_chain_slot.into());
let header = call_validate_block(
client
.header(&BlockId::number(1))
.ok()
.flatten()
.expect("Genesis header exists"),
client.header(hashof1).ok().flatten().expect("Genesis header exists"),
block.clone(),
relay_chain_root,
)