mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-05-31 06:21:02 +00:00
Add more debug logs to understand if statement-distribution misbehaving (#3419)
Add more debug logs to understand if statement-distribution is in a bad state, should be useful for debugging https://github.com/paritytech/polkadot-sdk/issues/3314 on production networks. Additionally, increase the number of parallel requests should make, since I notice that requests take around 100ms on kusama, and the 5 parallel request was picked mostly random, no reason why we can do more than that. --------- Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io> Co-authored-by: ordian <write@reusable.software>
This commit is contained in:
committed by
GitHub
parent
ce5de99540
commit
b9c792a4b8
@@ -55,8 +55,9 @@
|
||||
//! and to keep track of what we have sent to other validators in the group and what we may
|
||||
//! continue to send them.
|
||||
|
||||
use polkadot_primitives::{CandidateHash, CompactStatement, ValidatorIndex};
|
||||
use polkadot_primitives::{CandidateHash, CompactStatement, Hash, ValidatorIndex};
|
||||
|
||||
use crate::LOG_TARGET;
|
||||
use std::collections::{HashMap, HashSet};
|
||||
|
||||
#[derive(Hash, PartialEq, Eq)]
|
||||
@@ -424,6 +425,28 @@ impl ClusterTracker {
|
||||
fn is_in_group(&self, validator: ValidatorIndex) -> bool {
|
||||
self.validators.contains(&validator)
|
||||
}
|
||||
|
||||
/// Dumps pending statement for this cluster.
|
||||
///
|
||||
/// Normally we should not have pending statements to validators in our cluster,
|
||||
/// but if we do for all validators in our cluster, then we don't participate
|
||||
/// in backing. Ocasional pending statements are expected if two authorities
|
||||
/// can't detect each otehr or after restart, where it takes a while to discover
|
||||
/// the whole network.
|
||||
|
||||
pub fn warn_if_too_many_pending_statements(&self, parent_hash: Hash) {
|
||||
if self.pending.iter().filter(|pending| !pending.1.is_empty()).count() >=
|
||||
self.validators.len()
|
||||
{
|
||||
gum::warn!(
|
||||
target: LOG_TARGET,
|
||||
pending_statements = ?self.pending,
|
||||
?parent_hash,
|
||||
"Cluster has too many pending statements, something wrong with our connection to our group peers \n
|
||||
Restart might be needed if validator gets 0 backing rewards for more than 3-4 consecutive sessions"
|
||||
);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/// Incoming statement was accepted.
|
||||
|
||||
Reference in New Issue
Block a user