client/network: Remove option to disable yamux flow control (#7358)

With the `OnRead` flow control option yamux "send[s] window updates only
when data is read on the receiving end" and not as soon as "a Stream's
receive window drops to 0".

Yamux flow control has proven itself. This commit removes the feature
flag. Yamux flow control is now always enabled.
This commit is contained in:
Max Inden
2020-10-19 21:43:32 +02:00
committed by GitHub
parent 9f61b5b9f4
commit bd2dbc055c
6 changed files with 8 additions and 23 deletions
@@ -92,11 +92,6 @@ pub struct NetworkParams {
#[structopt(flatten)]
pub node_key_params: NodeKeyParams,
/// Disable the yamux flow control. This option will be removed in the future once there is
/// enough confidence that this feature is properly working.
#[structopt(long)]
pub no_yamux_flow_control: bool,
/// Enable peer discovery on local networks.
///
/// By default this option is true for `--dev` and false otherwise.
@@ -158,7 +153,6 @@ impl NetworkParams {
enable_mdns: !is_dev && !self.no_mdns,
allow_private_ipv4: !self.no_private_ipv4,
wasm_external_transport: None,
use_yamux_flow_control: !self.no_yamux_flow_control,
},
max_parallel_downloads: self.max_parallel_downloads,
allow_non_globals_in_dht: self.discover_local || is_dev,