Fix clippy suggestions. (#179)

* Fix clippy errors.

* Cargo fmt.

* Enable clippy checks.

* Create if does not exist.

* Fix warnings and enable sccache for clippy.

* chmod +x

* Revert and ignore errors.

* Update cancel-workflow-action.

* Fixes.

* Clippy fixes.

* Fix compilation.

* Fix new clippy warnings.

* fmt --all

* Fix the rest.

* fmt --all

* Conditional.

* Bump smallvec.

* Use separate cache dir for clippy to prevent races.

* Remove unused imports in tests

* Remove "useless conversion"

* Move clippy to main worfklow to avoid clashes.

* Fix clippy error.

* Fix remaning clippy errors.

* cargo fmt --all

Co-authored-by: Hernando Castano <castano.ha@gmail.com>

bridges/primitives/ethereum-poa/src/lib.rs

@@ -15,6 +15,10 @@
 // along with Parity Bridges Common.  If not, see <http://www.gnu.org/licenses/>.
 
 #![cfg_attr(not(feature = "std"), no_std)]
+// RuntimeApi generated functions
+#![allow(clippy::too_many_arguments)]
+// Generated by `DecodeLimit::decode_with_depth_limit`
+#![allow(clippy::unnecessary_mut_passed)]
 
 pub use parity_bytes::Bytes;
 pub use primitive_types::{H160, H256, H512, U128, U256};
@@ -206,7 +210,7 @@ impl Header {
 
 	/// Check if passed transactions are matching transactions root in this header.
 	pub fn verify_transactions_root(&self, transactions: &[RawTransaction]) -> bool {
-		verify_merkle_proof(self.transactions_root, transactions.into_iter())
+		verify_merkle_proof(self.transactions_root, transactions.iter())
 	}
 
 	/// Gets the seal hash of this header.
@@ -581,7 +585,7 @@ mod tests {
 					gas: 86016.into(),
 					to: Some(hex!("dac17f958d2ee523a2206206994597c13d831ec7").into()),
 					value: 0.into(),
-					payload: hex!("a9059cbb000000000000000000000000e08f35f66867a454835b25118f1e490e7f9e9a7400000000000000000000000000000000000000000000000000000000004c4b40").to_vec().into(),
+					payload: hex!("a9059cbb000000000000000000000000e08f35f66867a454835b25118f1e490e7f9e9a7400000000000000000000000000000000000000000000000000000000004c4b40").to_vec(),
 				},
 			}),
 		);
@@ -600,7 +604,7 @@ mod tests {
 					gas: 160000.into(),
 					to: Some(hex!("84dd11eb2a29615303d18149c0dbfa24167f8966").into()),
 					value: 0.into(),
-					payload: hex!("a9059cbb00000000000000000000000001503dfc5ad81bf630d83697e98601871bb211b60000000000000000000000000000000000000000000000000000000000002710").to_vec().into(),
+					payload: hex!("a9059cbb00000000000000000000000001503dfc5ad81bf630d83697e98601871bb211b60000000000000000000000000000000000000000000000000000000000002710").to_vec(),
 				},
 			}),
 		);