CLI improvements & fixes (#4812)

mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-05-30 11:41:02 +00:00

These are a few changes I missed during the refactoring.

1. Initialization issue and boilerplate

Most importantly: part of the `Configuration` initialization was done in `sc_cli::init`. This means the user can not benefit from this initialization boilerplate if they have multiple `Configuration` since `sc_cli::init` can only be called once.

2. Boilerplate for `VersionInfo` and `Configuration`

I'm also answering to the critic of @bkchr on the initialization using version: https://github.com/paritytech/substrate/pull/4692/files/bea809d4c14a2ede953227ac885e3b3f9771c548#r372047238 This will allow initializing a `Configuration` and provide the version by default.

3. Loading the `chain_spec` explicitly

In the past it was done automatically but in some cases we want to delay this. I moved the code to `Configuration.load_spec()` so it can be called later on. `chain_spec` can also be written directly to the `Configuration` without using this `load_spec` helper.

4. [deleted]

5. Fixing issue that prevents the user to override the port

In the refactoring I introduced a bug by mistake that could potentially prevent the CLI user to override the ports if defaults where provided for these ports (only on cumulus).

6. Change task_executor from Box to Arc

This is useful for cumulus where we have 2 nodes with 2 separate Configuration that need to spawn tasks to the same runtime.

7. Renamed TasksExecutorRequired to TaskExecutor

For consistency.

This is related to https://github.com/paritytech/cumulus/issues/24

This is the continuation (and hopefully the end of) #4692

This commit is contained in:

Cecile Tonglet

2020-02-06 15:46:49 +01:00

committed by

GitHub

parent f891342f20

commit be075893b5

16 changed files with 321 additions and 136 deletions

									
										substrate/.gitlab-ci.yml
									
		-9
	
												View File
												
				@@ -235,15 +235,6 @@ check-web-wasm:

				    - time cargo build --manifest-path=bin/node/cli/Cargo.toml --no-default-features --features "browser" --target=wasm32-unknown-unknown

				    - sccache -s

				node-exits:

				  stage:                           test

				  <<:                              *docker-env

				  except:

				    - /^v[0-9]+\.[0-9]+.*$/        # i.e. v1.0, v2.1rc1

				  script:

				    - ./.maintain/check_for_exit.sh

				test-full-crypto-feature:

				  stage:                           test

				  <<:                              *docker-env