pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-07-19 12:15:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't ban peers for small duplicate requests (#11084)

Browse Source 
* Don't ban peers for small duplicate requests

* Address review comment
This commit is contained in:
Nathan Whitaker
2022-03-22 03:47:05 -04:00
committed by GitHub
parent dd35c571f6
commit be11700658
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
substrate/client/network/src/block_request_handler.rs
+13 -1
View File
@@ -54,6 +54,10 @@ mod rep {
/// Reputation change when a peer sent us the same request multiple times. /// Reputation change when a peer sent us the same request multiple times.
pub const SAME_REQUEST: Rep = Rep::new_fatal("Same block request multiple times"); pub const SAME_REQUEST: Rep = Rep::new_fatal("Same block request multiple times");
/// Reputation change when a peer sent us the same "small" request multiple times.
pub const SAME_SMALL_REQUEST: Rep =
Rep::new(-(1 << 10), "same small block request multiple times");
} }
/// Generates a [`ProtocolConfig`] for the block request protocol, refusing incoming requests. /// Generates a [`ProtocolConfig`] for the block request protocol, refusing incoming requests.
@@ -200,8 +204,16 @@ impl<B: BlockT> BlockRequestHandler<B> {
Some(SeenRequestsValue::Fulfilled(ref mut requests)) => { Some(SeenRequestsValue::Fulfilled(ref mut requests)) => {
*requests = requests.saturating_add(1); *requests = requests.saturating_add(1);
let small_request = attributes
.difference(BlockAttributes::HEADER | BlockAttributes::JUSTIFICATION)
.is_empty();
if *requests > MAX_NUMBER_OF_SAME_REQUESTS_PER_PEER { if *requests > MAX_NUMBER_OF_SAME_REQUESTS_PER_PEER {
reputation_change = Some(rep::SAME_REQUEST); reputation_change = Some(if small_request {
rep::SAME_SMALL_REQUEST
} else {
rep::SAME_REQUEST
});
} }
}, },
None => { None => {