Set clippy lints in workspace (requires rust 1.74) (#2390)

We currently use a bit of a hack in `.cargo/config` to make sure that clippy isn't too annoying by specifying the list of lints. There is now a stable way to define lints for a workspace. The only down side is that every crate seems to have to opt into this so there's a *few* files modified in this PR. Dependencies: - [x] PR that upgrades CI to use rust 1.74 is merged. --------- Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
2026-06-18 03:41:02 +00:00 · 2023-12-13 14:11:07 +00:00
parent 4c4407a893
commit be8e626806
471 changed files with 1430 additions and 37 deletions
@@ -6,6 +6,9 @@ edition.workspace = true
 description = "Parachain node CLI utilities."
 license = "GPL-3.0-or-later WITH Classpath-exception-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 clap = { version = "4.4.11", features = ["derive"] }
 codec = { package = "parity-scale-codec", version = "3.0.0" }
@@ -6,6 +6,9 @@ edition.workspace = true
 description = "Common node-side functionality and glue code to collate parachain blocks."
 license = "GPL-3.0-or-later WITH Classpath-exception-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 parking_lot = "0.12.1"
 codec = { package = "parity-scale-codec", version = "3.0.0", features = ["derive"] }
@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license = "GPL-3.0-or-later WITH Classpath-exception-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 async-trait = "0.1.73"
 codec = { package = "parity-scale-codec", version = "3.0.0", features = ["derive"] }
@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license = "GPL-3.0-or-later WITH Classpath-exception-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 async-trait = "0.1.73"
 codec = { package = "parity-scale-codec", version = "3.0.0", features = ["derive"] }
@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license = "GPL-3.0-or-later WITH Classpath-exception-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 anyhow = "1.0"
 async-trait = "0.1.73"
@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license = "GPL-3.0-or-later WITH Classpath-exception-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 async-trait = "0.1.73"
 futures = "0.3.28"
@@ -6,6 +6,9 @@ description = "Cumulus-specific networking protocol"
 edition.workspace = true
 license = "GPL-3.0-or-later WITH Classpath-exception-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 async-trait = "0.1.73"
 codec = { package = "parity-scale-codec", version = "3.0.0", features = ["derive"] }
@@ -6,6 +6,9 @@ description = "Cumulus-specific networking protocol"
 edition.workspace = true
 license = "GPL-3.0-or-later WITH Classpath-exception-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", features = ["derive"] }
 futures = "0.3.28"
@@ -6,6 +6,9 @@ edition.workspace = true
 description = "Implementation of the RelayChainInterface trait for Polkadot full-nodes."
 license = "GPL-3.0-or-later WITH Classpath-exception-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 async-trait = "0.1.73"
 futures = "0.3.28"
@@ -6,6 +6,9 @@ edition.workspace = true
 description = "Common interface for different relay chain datasources."
 license = "GPL-3.0-or-later WITH Classpath-exception-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 polkadot-overseer = { path = "../../../polkadot/node/overseer" }

@@ -6,6 +6,9 @@ edition.workspace = true
 description = "Minimal node implementation to be used in tandem with RPC or light-client mode."
 license = "GPL-3.0-or-later WITH Classpath-exception-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 # polkadot deps
 polkadot-primitives = { path = "../../../polkadot/primitives" }
@@ -6,6 +6,8 @@ edition.workspace = true
 description = "Implementation of the RelayChainInterface trait that connects to a remote RPC-node."
 license = "GPL-3.0-or-later WITH Classpath-exception-2.0"

+[lints]
+workspace = true

 [dependencies]
 polkadot-overseer = { path = "../../../polkadot/node/overseer" }
@@ -6,6 +6,9 @@ edition.workspace = true
 description = "Common functions used to assemble the components of a parachain node."
 license = "GPL-3.0-or-later WITH Classpath-exception-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 futures = "0.3.28"

@@ -6,6 +6,9 @@ edition.workspace = true
 description = "AURA consensus extension pallet for parachains"
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive"] }
 scale-info = { version = "2.10.0", default-features = false, features = ["derive"] }
@@ -9,6 +9,9 @@ readme = "README.md"
 repository.workspace = true
 version = "3.0.0"

+[lints]
+workspace = true
+
 [package.metadata.docs.rs]
 targets = ["x86_64-unknown-linux-gnu"]

@@ -7,6 +7,9 @@ repository.workspace = true
 description = "Migrates messages from the old DMP queue pallet."
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [package.metadata.docs.rs]
 targets = ["x86_64-unknown-linux-gnu"]

@@ -6,6 +6,9 @@ edition.workspace = true
 description = "Base pallet for cumulus-based parachains"
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 bytes = { version = "1.4.0", default-features = false }
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive"] }
@@ -6,6 +6,9 @@ edition.workspace = true
 description = "Proc macros provided by the parachain-system pallet"
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [lib]
 proc-macro = true

@@ -9,6 +9,9 @@ repository.workspace = true
 description = "FRAME sessions pallet benchmarking"
 readme = "README.md"

+[lints]
+workspace = true
+
 [package.metadata.docs.rs]
 targets = ["x86_64-unknown-linux-gnu"]

@@ -6,6 +6,9 @@ edition.workspace = true
 description = "Adds functionality to migrate from a Solo to a Parachain"
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive"] }
 scale-info = { version = "2.10.0", default-features = false, features = ["derive"] }
@@ -6,6 +6,9 @@ version = "0.1.0"
 license = "Apache-2.0"
 description = "Pallet for stuff specific to parachains' usage of XCM"

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive"] }
 scale-info = { version = "2.10.0", default-features = false, features = ["derive"] }
@@ -6,6 +6,9 @@ edition.workspace = true
 description = "Pallet to queue outbound and inbound XCMP messages."
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", features = ["derive"], default-features = false }
 log = { version = "0.4.20", default-features = false }
@@ -10,6 +10,9 @@ edition.workspace = true
 build = "build.rs"
 publish = false

+[lints]
+workspace = true
+
 [dependencies]
 clap = { version = "4.4.11", features = ["derive"] }
 log = "0.4.20"
@@ -8,6 +8,9 @@ homepage = "https://substrate.io"
 repository.workspace = true
 edition.workspace = true

+[lints]
+workspace = true
+
 [package.metadata.docs.rs]
 targets = ["x86_64-unknown-linux-gnu"]

@@ -8,6 +8,9 @@ homepage = "https://substrate.io"
 repository.workspace = true
 edition.workspace = true

+[lints]
+workspace = true
+
 [package.metadata.docs.rs]
 targets = ["x86_64-unknown-linux-gnu"]

@@ -6,6 +6,9 @@ edition.workspace = true
 description = "Logic which is common to all parachain runtimes"
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [package.metadata.docs.rs]
 targets = ["x86_64-unknown-linux-gnu"]

@@ -7,6 +7,9 @@ license = "Apache-2.0"
 description = "Asset Hub Rococo emulated chain"
 publish = false

+[lints]
+workspace = true
+
 [dependencies]
 serde_json = "1.0.104"

@@ -7,6 +7,9 @@ license = "Apache-2.0"
 description = "Asset Hub Westend emulated chain"
 publish = false

+[lints]
+workspace = true
+
 [dependencies]
 serde_json = "1.0.104"

@@ -7,6 +7,9 @@ license = "Apache-2.0"
 description = "Bridge Hub Rococo emulated chain"
 publish = false

+[lints]
+workspace = true
+
 [dependencies]
 serde_json = "1.0.104"

@@ -7,6 +7,9 @@ license = "Apache-2.0"
 description = "Bridge Hub Westend emulated chain"
 publish = false

+[lints]
+workspace = true
+
 [dependencies]
 serde_json = "1.0.104"

@@ -7,6 +7,9 @@ license = "Apache-2.0"
 description = "Collectives Westend emulated chain"
 publish = false

+[lints]
+workspace = true
+
 [dependencies]
 serde_json = "1.0.104"

@@ -7,6 +7,9 @@ license = "Apache-2.0"
 description = "Penpal emulated chain"
 publish = false

+[lints]
+workspace = true
+
 [dependencies]
 serde_json = "1.0.104"

@@ -7,6 +7,9 @@ license = "Apache-2.0"
 description = "Rococo emulated chain"
 publish = false

+[lints]
+workspace = true
+
 [dependencies]
 serde_json = "1.0.104"

@@ -7,6 +7,9 @@ license = "Apache-2.0"
 description = "Westend emulated chain"
 publish = false

+[lints]
+workspace = true
+
 [dependencies]
 serde_json = "1.0.104"

@@ -6,6 +6,9 @@ edition.workspace = true
 license = "Apache-2.0"
 description = "Common resources for integration testing with xcm-emulator"

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.4.0", default-features = false }
 paste = "1.0.14"
@@ -7,6 +7,9 @@ license = "Apache-2.0"
 description = "Rococo System emulated network"
 publish = false

+[lints]
+workspace = true
+
 [dependencies]
 # Cumulus
 emulated-integration-tests-common = { path = "../../common", default-features = false }
@@ -7,6 +7,9 @@ license = "Apache-2.0"
 description = "Rococo<>Westend emulated bridged network"
 publish = false

+[lints]
+workspace = true
+
 [dependencies]
 # Cumulus
 emulated-integration-tests-common = { path = "../../common", default-features = false }
@@ -7,6 +7,9 @@ license = "Apache-2.0"
 description = "Westend System emulated network"
 publish = false

+[lints]
+workspace = true
+
 [dependencies]
 # Cumulus
 emulated-integration-tests-common = { path = "../../common", default-features = false }
@@ -7,6 +7,9 @@ license = "Apache-2.0"
 description = "Asset Hub Rococo runtime integration tests with xcm-emulator"
 publish = false

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.4.0", default-features = false }
 assert_matches = "1.5.0"
@@ -7,6 +7,9 @@ license = "Apache-2.0"
 description = "Asset Hub Westend runtime integration tests with xcm-emulator"
 publish = false

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.4.0", default-features = false }
 assert_matches = "1.5.0"
@@ -7,6 +7,9 @@ license = "Apache-2.0"
 description = "Bridge Hub Rococo runtime integration tests with xcm-emulator"
 publish = false

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.4.0", default-features = false }

@@ -7,6 +7,9 @@ license = "Apache-2.0"
 description = "Bridge Hub Westend runtime integration tests with xcm-emulator"
 publish = false

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.4.0", default-features = false }

@@ -6,6 +6,9 @@ edition = "2021"
 description = "Managed content"
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive", "max-encoded-len"] }
 scale-info = { version = "2.10.0", default-features = false, features = ["derive"] }
@@ -6,6 +6,9 @@ version = "0.1.0"
 license = "Apache-2.0"
 description = "Pallet to store the parachain ID"

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive"] }
 scale-info = { version = "2.10.0", default-features = false, features = ["derive"] }
@@ -6,6 +6,9 @@ version = "0.1.0"
 license = "Apache-2.0"
 description = "Ping Pallet for Cumulus XCM/UMP testing."

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive"] }
 scale-info = { version = "2.10.0", default-features = false, features = ["derive"] }
@@ -6,6 +6,9 @@ edition.workspace = true
 description = "Rococo variant of Asset Hub parachain runtime"
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive", "max-encoded-len"] }
 hex-literal = { version = "0.4.1" }
@@ -6,6 +6,9 @@ edition.workspace = true
 description = "Westend variant of Asset Hub parachain runtime"
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive", "max-encoded-len"] }
 hex-literal = { version = "0.4.1", optional = true }
@@ -6,6 +6,9 @@ edition.workspace = true
 description = "Assets common utilities"
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive"] }
 scale-info = { version = "2.10.0", default-features = false, features = ["derive"] }
@@ -6,6 +6,9 @@ edition.workspace = true
 description = "Test utils for Asset Hub runtimes."
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive", "max-encoded-len"] }

@@ -6,6 +6,9 @@ edition.workspace = true
 description = "Rococo's BridgeHub  parachain runtime"
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [build-dependencies]
 substrate-wasm-builder = { path = "../../../../../substrate/utils/wasm-builder", optional = true }

@@ -6,6 +6,9 @@ edition.workspace = true
 description = "Westend's BridgeHub parachain runtime"
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [build-dependencies]
 substrate-wasm-builder = { path = "../../../../../substrate/utils/wasm-builder", optional = true }

@@ -6,6 +6,9 @@ edition.workspace = true
 description = "Utils for BridgeHub testing"
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive", "max-encoded-len"] }
 impl-trait-for-tuples = "0.2"
@@ -6,6 +6,9 @@ edition.workspace = true
 license = "Apache-2.0"
 description = "Westend Collectives Parachain Runtime"

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive", "max-encoded-len"] }
 hex-literal = { version = "0.4.1" }
@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [package.metadata.docs.rs]
 targets = ["x86_64-unknown-linux-gnu"]

@@ -6,6 +6,9 @@ edition.workspace = true
 license = "Apache-2.0"
 description = "Glutton parachain runtime."

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive"] }
 scale-info = { version = "2.10.0", default-features = false, features = ["derive"] }
@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive"] }
 scale-info = { version = "2.10.0", default-features = false, features = ["derive"] }
@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive"] }
 scale-info = { version = "2.10.0", default-features = false, features = ["derive"] }
@@ -6,6 +6,9 @@ edition.workspace = true
 description = "Utils for Runtimes testing"
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive", "max-encoded-len"] }

@@ -8,6 +8,9 @@ homepage = "https://substrate.io"
 repository.workspace = true
 edition.workspace = true

+[lints]
+workspace = true
+
 [package.metadata.docs.rs]
 targets = ["x86_64-unknown-linux-gnu"]

@@ -6,6 +6,9 @@ edition.workspace = true
 description = "Simple runtime used by the rococo parachain(s)"
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive"] }
 scale-info = { version = "2.10.0", default-features = false, features = ["derive"] }
@@ -7,6 +7,9 @@ edition.workspace = true
 description = "Runs a polkadot parachain node which could be a collator."
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [[bin]]
 name = "polkadot-parachain"
 path = "src/main.rs"
@@ -6,6 +6,9 @@ edition.workspace = true
 license = "Apache-2.0"
 description = "Core primitives for Aura in Cumulus"

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive"] }

@@ -6,6 +6,9 @@ edition.workspace = true
 license = "Apache-2.0"
 description = "Cumulus related core primitive types and traits"

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive"] }
 scale-info = { version = "2.10.0", default-features = false, features = ["derive"] }
@@ -6,6 +6,9 @@ edition.workspace = true
 description = "Inherent that needs to be present in every parachain block. Contains messages and a relay chain storage-proof."
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 async-trait = { version = "0.1.73", optional = true }
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive"] }
@@ -6,6 +6,9 @@ edition.workspace = true
 description = "Hostfunction exposing storage proof size to the runtime."
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 sp-runtime-interface = { path = "../../../substrate/primitives/runtime-interface", default-features = false }
 sp-externalities = { path = "../../../substrate/primitives/externalities", default-features = false }
@@ -6,6 +6,9 @@ edition.workspace = true
 description = "Provides timestamp related functionality for parachains."
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive"] }
 futures = "0.3.28"
@@ -6,6 +6,9 @@ edition.workspace = true
 license = "Apache-2.0"
 description = "Helper datatypes for Cumulus"

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive"] }
 log = { version = "0.4.20", default-features = false }
@@ -5,6 +5,9 @@ authors.workspace = true
 edition.workspace = true
 publish = false

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive"] }

@@ -6,6 +6,9 @@ edition.workspace = true
 license = "Apache-2.0"
 description = "Mocked relay state proof builder for testing Cumulus."

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive"] }

@@ -5,6 +5,9 @@ authors.workspace = true
 edition.workspace = true
 publish = false

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = ["derive"] }
 scale-info = { version = "2.10.0", default-features = false, features = ["derive"] }
@@ -5,6 +5,9 @@ authors.workspace = true
 edition.workspace = true
 publish = false

+[lints]
+workspace = true
+
 [[bin]]
 name = "test-parachain"
 path = "src/main.rs"
@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license = "Apache-2.0"

+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", version = "3.0.0" }
 paste = "1.0.14"