Set clippy lints in workspace (requires rust 1.74) (#2390)

We currently use a bit of a hack in `.cargo/config` to make sure that
clippy isn't too annoying by specifying the list of lints.

There is now a stable way to define lints for a workspace. The only down
side is that every crate seems to have to opt into this so there's a
*few* files modified in this PR.

Dependencies:

- [x] PR that upgrades CI to use rust 1.74 is merged.

---------

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>

polkadot/node/collation-generation/Cargo.toml

@@ -6,6 +6,9 @@ edition.workspace = true
 license.workspace = true
 description = "Collator-side subsystem that handles incoming candidate submissions from the parachain."
 
+[lints]
+workspace = true
+
 [dependencies]
 futures = "0.3.21"
 gum = { package = "tracing-gum", path = "../gum" }

polkadot/node/core/approval-voting/Cargo.toml

@@ -6,6 +6,9 @@ edition.workspace = true
 license.workspace = true
 description = "Approval Voting Subsystem of the Polkadot node"
 
+[lints]
+workspace = true
+
 [dependencies]
 futures = "0.3.21"
 futures-timer = "3.0.2"

polkadot/node/core/av-store/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 futures = "0.3.21"
 futures-timer = "3.0.2"

polkadot/node/core/backing/Cargo.toml

@@ -6,6 +6,9 @@ edition.workspace = true
 license.workspace = true
 description = "The Candidate Backing Subsystem. Tracks parachain candidates that can be backed, as well as the issuance of statements about candidates."
 
+[lints]
+workspace = true
+
 [dependencies]
 futures = "0.3.21"
 sp-keystore = { path = "../../../../substrate/primitives/keystore" }

polkadot/node/core/bitfield-signing/Cargo.toml

@@ -6,6 +6,9 @@ edition.workspace = true
 license.workspace = true
 description = "Bitfield signing subsystem for the Polkadot node"
 
+[lints]
+workspace = true
+
 [dependencies]
 futures = "0.3.21"
 gum = { package = "tracing-gum", path = "../../gum" }

polkadot/node/core/candidate-validation/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 async-trait = "0.1.57"
 futures = "0.3.21"

polkadot/node/core/chain-api/Cargo.toml

@@ -6,6 +6,9 @@ edition.workspace = true
 license.workspace = true
 description = "The Chain API subsystem provides access to chain related utility functions like block number to hash conversions."
 
+[lints]
+workspace = true
+
 [dependencies]
 futures = "0.3.21"
 gum = { package = "tracing-gum", path = "../../gum" }

polkadot/node/core/chain-selection/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 futures = "0.3.21"
 futures-timer = "3"

polkadot/node/core/dispute-coordinator/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 futures = "0.3.21"
 gum = { package = "tracing-gum", path = "../../gum" }

polkadot/node/core/parachains-inherent/Cargo.toml

@@ -6,6 +6,9 @@ edition.workspace = true
 license.workspace = true
 description = "Parachains inherent data provider for Polkadot node"
 
+[lints]
+workspace = true
+
 [dependencies]
 futures = "0.3.21"
 futures-timer = "3.0.2"

polkadot/node/core/prospective-parachains/Cargo.toml

@@ -6,6 +6,9 @@ edition.workspace = true
 license.workspace = true
 description = "The Prospective Parachains subsystem. Tracks and handles prospective parachain fragments."
 
+[lints]
+workspace = true
+
 [dependencies]
 futures = "0.3.19"
 gum = { package = "tracing-gum", path = "../../gum" }

polkadot/node/core/provisioner/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 bitvec = { version = "1.0.0", default-features = false, features = ["alloc"] }
 futures = "0.3.21"

polkadot/node/core/pvf-checker/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 futures = "0.3.21"
 thiserror = "1.0.48"

polkadot/node/core/pvf/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 always-assert = "0.1"
 blake3 = "1.5"

polkadot/node/core/pvf/benches/host_prepare_rococo_runtime.rs

@@ -28,7 +28,8 @@ use tokio::{runtime::Handle, sync::Mutex};
 const TEST_PREPARATION_TIMEOUT: Duration = Duration::from_secs(30);
 
 struct TestHost {
-	// Keep a reference to the tempdir as it gets deleted on drop.
+	// Keep a reference to the tempdir otherwise it gets deleted on drop.
+	#[allow(dead_code)]
 	cache_dir: tempfile::TempDir,
 	host: Mutex<ValidationHost>,
 }

polkadot/node/core/pvf/common/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 cfg-if = "1.0"
 cpu-time = "1.0.0"

polkadot/node/core/pvf/execute-worker/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 cpu-time = "1.0.0"
 gum = { package = "tracing-gum", path = "../../../gum" }

polkadot/node/core/pvf/prepare-worker/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 blake3 = "1.5"
 cfg-if = "1.0"

polkadot/node/core/runtime-api/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 futures = "0.3.21"
 gum = { package = "tracing-gum", path = "../../gum" }

polkadot/node/gum/Cargo.toml

@@ -6,6 +6,9 @@ edition.workspace = true
 license.workspace = true
 description = "Stick logs together with the TraceID as provided by tempo"
 
+[lints]
+workspace = true
+
 [dependencies]
 coarsetime = "0.1.22"
 tracing = "0.1.35"

polkadot/node/gum/proc-macro/Cargo.toml

@@ -6,6 +6,9 @@ edition.workspace = true
 license.workspace = true
 description = "Generate an overseer including builder pattern and message wrapper from a single annotated struct definition."
 
+[lints]
+workspace = true
+
 [package.metadata.docs.rs]
 targets = ["x86_64-unknown-linux-gnu"]
 

polkadot/node/jaeger/Cargo.toml

@@ -6,6 +6,9 @@ edition.workspace = true
 license.workspace = true
 description = "Polkadot Jaeger primitives, but equally useful for Grafana/Tempo"
 
+[lints]
+workspace = true
+
 [dependencies]
 mick-jaeger = "0.1.8"
 lazy_static = "1.4"

polkadot/node/malus/Cargo.toml

@@ -8,6 +8,9 @@ license.workspace = true
 readme = "README.md"
 publish = false
 
+[lints]
+workspace = true
+
 [[bin]]
 name = "malus"
 path = "src/malus.rs"

polkadot/node/metrics/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 futures = "0.3.21"
 futures-timer = "3.0.2"

polkadot/node/network/approval-distribution/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 polkadot-node-metrics = { path = "../../metrics" }
 polkadot-node-network-protocol = { path = "../protocol" }

polkadot/node/network/availability-distribution/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 futures = "0.3.21"
 gum = { package = "tracing-gum", path = "../../gum" }

polkadot/node/network/availability-recovery/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 futures = "0.3.21"
 schnellru = "0.2.1"

polkadot/node/network/bitfield-distribution/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 always-assert = "0.1"
 futures = "0.3.21"

polkadot/node/network/bridge/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 always-assert = "0.1"
 async-trait = "0.1.57"

polkadot/node/network/collator-protocol/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 bitvec = { version = "1.0.1", default-features = false, features = ["alloc"] }
 futures = "0.3.21"

polkadot/node/network/dispute-distribution/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 futures = "0.3.21"
 futures-timer = "3.0.2"

polkadot/node/network/gossip-support/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 sp-application-crypto = { path = "../../../../substrate/primitives/application-crypto" }
 sp-keystore = { path = "../../../../substrate/primitives/keystore" }

polkadot/node/network/protocol/Cargo.toml

@@ -6,6 +6,9 @@ edition.workspace = true
 license.workspace = true
 description = "Primitives types for the Node-side"
 
+[lints]
+workspace = true
+
 [dependencies]
 async-channel = "1.8.0"
 async-trait = "0.1.57"

polkadot/node/network/statement-distribution/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 futures = "0.3.21"
 futures-timer = "3.0.2"

polkadot/node/overseer/Cargo.toml

@@ -6,6 +6,9 @@ edition.workspace = true
 license.workspace = true
 description = "System overseer of the Polkadot node"
 
+[lints]
+workspace = true
+
 [dependencies]
 client = { package = "sc-client-api", path = "../../../substrate/client/api" }
 sp-api = { path = "../../../substrate/primitives/api" }

polkadot/node/primitives/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 bounded-vec = "0.7"
 futures = "0.3.21"

polkadot/node/service/Cargo.toml

@@ -7,6 +7,9 @@ edition.workspace = true
 license.workspace = true
 description = "Utils to tie different Polkadot components together and allow instantiation of a node."
 
+[lints]
+workspace = true
+
 [dependencies]
 # Substrate Client
 sc-authority-discovery = { path = "../../../substrate/client/authority-discovery" }

polkadot/node/subsystem-test-helpers/Cargo.toml

@@ -7,6 +7,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 async-trait = "0.1.57"
 futures = "0.3.21"

polkadot/node/subsystem-types/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 derive_more = "0.99.17"
 futures = "0.3.21"

polkadot/node/subsystem-util/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 async-trait = "0.1.57"
 futures = "0.3.21"

polkadot/node/subsystem/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 polkadot-overseer = { path = "../overseer" }
 polkadot-node-subsystem-types = { path = "../subsystem-types" }

polkadot/node/test/client/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 parity-scale-codec = { version = "3.6.1", default-features = false, features = ["derive"] }
 

polkadot/node/test/service/Cargo.toml

@@ -6,6 +6,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 futures = "0.3.21"
 hex = "0.4.3"

polkadot/node/tracking-allocator/Cargo.toml

@@ -5,3 +5,6 @@ version = "1.0.0"
 authors.workspace = true
 edition.workspace = true
 license.workspace = true
+
+[lints]
+workspace = true

polkadot/node/zombienet-backchannel/Cargo.toml

@@ -8,6 +8,9 @@ authors.workspace = true
 edition.workspace = true
 license.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 tokio = { version = "1.24.2", default-features = false, features = ["macros", "net", "rt-multi-thread", "sync"] }
 url = "2.3.1"