pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-04-27 15:07:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed race in batch signature verification (#5805)

Browse Source
This commit is contained in:
Arkadiy Paronyan
2020-04-28 00:10:21 +02:00
committed by GitHub
parent 5662501258
commit bf61cece1c
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
substrate/primitives/io/src/batch_verifier.rs
+8 -4
View File
@@ -139,11 +139,13 @@ impl BatchVerifier {
self.sr25519_items.clear();
if pending.len() > 0 {
let pair = Arc::new((Mutex::new(()), Condvar::new()));
let pair = Arc::new((Mutex::new(false), Condvar::new()));
let pair_clone = pair.clone();
if self.scheduler.spawn_obj(FutureObj::new(async move {
futures::future::join_all(pending).await;
let mut finished = pair_clone.0.lock().expect("Locking can only fail when the mutex is poisoned; qed");
*finished = true;
pair_clone.1.notify_all();
}.boxed())).is_err() {
log::debug!(
@@ -154,9 +156,11 @@ impl BatchVerifier {
return false;
}
let (mtx, cond_var) = &*pair;
let mtx = mtx.lock().expect("Locking can only fail when the mutex is poisoned; qed");
let _ = cond_var.wait(mtx).expect("Waiting can only fail when the mutex waited on is poisoned; qed");
let (finished, cond_var) = &*pair;
let mut finished = finished.lock().expect("Locking can only fail when the mutex is poisoned; qed");
while !*finished {
finished = cond_var.wait(finished).expect("Waiting can only fail when the mutex waited on is poisoned; qed");
}
}
log::trace!(