Change the Config of the MaxRococoNum Slot from a Constant to a Storage function (#7217)

* set MaxPermanentSlots and MaxTemporarySlots with a extrinsic instead of a constant

* delete the  MaxPermanentSlots and MaxTemporarySlots constants from config on  Rococo and Westend

* migration code for assigned slots

* remove getters

* little refactor

* set values in the GenesisConfig

* refactor in the migration, adding it in the rococo runtime

* refactor: fmt

* Minor fix

* pre_upgrade check

* add migration to mod v1

* Logs following Substrate#12873

* fix: current storage version set to 1

* use enact when try-runtime

* Vec seems to be missing

* feature gate import

* fix as per #13993

* address comments

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* address  comments

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* benchmarking for assign_perm_parachain_slot extrinsic

* benchmark all the extrinsics of the pallet

* cargo fmt for assigned slots

* migration added for westend

* licence in benchmarking file

* BuildGenesisConfig

* assigned_slots default in genesis

* cargo fmt

* assigned_slots fix tests config

* cargo fmt

* fix benchmarking compile error

* fix benchmarking imports

* benchmark worst case scenario for validation code and head data

* add assigned_slots in frame_benchmarking on Rococo and Westend

* modify values for para_id in benchmarking

* delete the assigned_slots in westend frame_benchmarking

* fix benchmarkings and add it to westend

* cargo fmt

* ".git/.scripts/commands/bench/bench.sh" --subcommand=runtime --runtime=rococo --target_dir=polkadot --pallet=runtime_common::assigned_slots

* ".git/.scripts/commands/bench/bench.sh" --subcommand=runtime --runtime=westend --target_dir=polkadot --pallet=runtime_common::assigned_slots

* use generated weights in assigned_slots pallet

* small changes in set_max_permanent_slots and set_max_temporary_slots

* revert last commit

* address some comments

* wrap migration with VersionCheckedMigrateToV1

* add experimental feature in pallet, and assers in post_upgrade migration

* clean warnings

* clean unnecesary experimental flag

* small typo in comments

* cargo fmt

* small comments fixes

---------

Co-authored-by: al3mart <11448715+al3mart@users.noreply.github.com>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: command-bot <>
This commit is contained in:
alexd10s
2023-08-15 15:17:15 +02:00
committed by GitHub
parent cf3271fea2
commit bf785881ac
13 changed files with 727 additions and 45 deletions
+4 -5
View File
@@ -1334,8 +1334,6 @@ impl paras_sudo_wrapper::Config for Runtime {}
parameter_types! {
pub const PermanentSlotLeasePeriodLength: u32 = 365;
pub const TemporarySlotLeasePeriodLength: u32 = 5;
pub const MaxPermanentSlots: u32 = 100;
pub const MaxTemporarySlots: u32 = 100;
pub const MaxTemporarySlotPerLeasePeriod: u32 = 5;
}
@@ -1345,9 +1343,8 @@ impl assigned_slots::Config for Runtime {
type Leaser = Slots;
type PermanentSlotLeasePeriodLength = PermanentSlotLeasePeriodLength;
type TemporarySlotLeasePeriodLength = TemporarySlotLeasePeriodLength;
type MaxPermanentSlots = MaxPermanentSlots;
type MaxTemporarySlots = MaxTemporarySlots;
type MaxTemporarySlotPerLeasePeriod = MaxTemporarySlotPerLeasePeriod;
type WeightInfo = weights::runtime_common_assigned_slots::WeightInfo<Runtime>;
}
impl validator_manager::Config for Runtime {
@@ -1471,7 +1468,7 @@ construct_runtime! {
MmrLeaf: pallet_beefy_mmr::{Pallet, Storage} = 242,
ParasSudoWrapper: paras_sudo_wrapper::{Pallet, Call} = 250,
AssignedSlots: assigned_slots::{Pallet, Call, Storage, Event<T>} = 251,
AssignedSlots: assigned_slots::{Pallet, Call, Storage, Event<T>, Config<T>} = 251,
// Validator Manager pallet.
ValidatorManager: validator_manager::{Pallet, Call, Storage, Event<T>} = 252,
@@ -1526,6 +1523,7 @@ pub mod migrations {
pallet_society::migrations::VersionCheckedMigrateToV2<Runtime, (), ()>,
pallet_im_online::migration::v1::Migration<Runtime>,
parachains_configuration::migration::v7::MigrateToV7<Runtime>,
assigned_slots::migration::v1::VersionCheckedMigrateToV1<Runtime>,
);
}
@@ -1572,6 +1570,7 @@ mod benches {
// Polkadot
// NOTE: Make sure to prefix these with `runtime_common::` so
// the that path resolves correctly in the generated file.
[runtime_common::assigned_slots, AssignedSlots]
[runtime_common::auctions, Auctions]
[runtime_common::crowdloan, Crowdloan]
[runtime_common::claims, Claims]