pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-06-17 06:41:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix documentation about justification and finalized == true requirement (#1607)

Browse Source 
I was reading source code and noticed these two places that are no
longer true after https://github.com/paritytech/polkadot-sdk/pull/1211
This commit is contained in:
Nazar Mokrynskyi
2023-09-25 13:56:43 +03:00
committed by GitHub
parent b5fcdff9f5
commit c0a4ce1fc8
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
substrate/client/service/src/client/client.rs
+2 -4
View File
@@ -484,8 +484,7 @@ where
CallExecutor::runtime_version(&self.executor, hash) CallExecutor::runtime_version(&self.executor, hash)
} }
/// Apply a checked and validated block to an operation. If a justification is provided /// Apply a checked and validated block to an operation.
/// then `finalized` *must* be true.
fn apply_block( fn apply_block(
&self, &self,
operation: &mut ClientImportOperation<Block, B>, operation: &mut ClientImportOperation<Block, B>,
@@ -1766,8 +1765,7 @@ where
{ {
type Error = ConsensusError; type Error = ConsensusError;
/// Import a checked and validated block. If a justification is provided in /// Import a checked and validated block.
/// `BlockImportParams` then `finalized` *must* be true.
/// ///
/// NOTE: only use this implementation when there are NO consensus-level BlockImport /// NOTE: only use this implementation when there are NO consensus-level BlockImport
/// objects. Otherwise, importing blocks directly into the client would be bypassing /// objects. Otherwise, importing blocks directly into the client would be bypassing