From c46b2020f2915d6e99f1f362234615e272add281 Mon Sep 17 00:00:00 2001
From: Xiliang Chen <xlchen1291@gmail.com>
Date: Wed, 27 May 2020 20:18:53 +1200
Subject: [PATCH] fix lstrip in biguint (#6151)

* add failing test for multiply_by_rational

* fix BigUint

* fix length

* bump version

* merge tests
---
 substrate/bin/node/runtime/src/lib.rs              |  2 +-
 substrate/primitives/arithmetic/src/biguint.rs     | 10 +++++-----
 substrate/primitives/arithmetic/src/rational128.rs |  9 +++++++++
 3 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/substrate/bin/node/runtime/src/lib.rs b/substrate/bin/node/runtime/src/lib.rs
index 67e988f496..a3723f049a 100644
--- a/substrate/bin/node/runtime/src/lib.rs
+++ b/substrate/bin/node/runtime/src/lib.rs
@@ -94,7 +94,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
 	// implementation changes and behavior does not, then leave spec_version as
 	// is and increment impl_version.
 	spec_version: 251,
-	impl_version: 0,
+	impl_version: 1,
 	apis: RUNTIME_API_VERSIONS,
 	transaction_version: 1,
 };
diff --git a/substrate/primitives/arithmetic/src/biguint.rs b/substrate/primitives/arithmetic/src/biguint.rs
index a1e5ea2666..41e2c759a5 100644
--- a/substrate/primitives/arithmetic/src/biguint.rs
+++ b/substrate/primitives/arithmetic/src/biguint.rs
@@ -151,7 +151,7 @@ impl BigUint {
 		// has the ability to cause this. There is nothing to do if the number already has 1
 		// limb only. call it a day and return.
 		if self.len().is_zero() { return; }
-		let index = self.digits.iter().position(|&elem| elem != 0).unwrap_or(0);
+		let index = self.digits.iter().position(|&elem| elem != 0).unwrap_or(self.len() - 1);
 
 		if index > 0 {
 			self.digits = self.digits[index..].to_vec()
@@ -581,19 +581,19 @@ pub mod tests {
 	fn strip_works() {
 		let mut a = BigUint::from_limbs(&[0, 1, 0]);
 		a.lstrip();
-		assert_eq!(a, BigUint { digits: vec![1, 0] });
+		assert_eq!(a.digits, vec![1, 0]);
 
 		let mut a = BigUint::from_limbs(&[0, 0, 1]);
 		a.lstrip();
-		assert_eq!(a, BigUint { digits: vec![1] });
+		assert_eq!(a.digits, vec![1]);
 
 		let mut a = BigUint::from_limbs(&[0, 0]);
 		a.lstrip();
-		assert_eq!(a, BigUint { digits: vec![0] });
+		assert_eq!(a.digits, vec![0]);
 
 		let mut a = BigUint::from_limbs(&[0, 0, 0]);
 		a.lstrip();
-		assert_eq!(a, BigUint { digits: vec![0] });
+		assert_eq!(a.digits, vec![0]);
 	}
 
 	#[test]
diff --git a/substrate/primitives/arithmetic/src/rational128.rs b/substrate/primitives/arithmetic/src/rational128.rs
index 9d0d10921d..709af1d3b9 100644
--- a/substrate/primitives/arithmetic/src/rational128.rs
+++ b/substrate/primitives/arithmetic/src/rational128.rs
@@ -360,6 +360,15 @@ mod tests {
 			multiply_by_rational(1_000_000_000, MAX128 / 8, MAX128 / 2).unwrap(),
 			250000000,
 		);
+
+		assert_eq!(
+			multiply_by_rational(
+				29459999999999999988000u128,
+				1000000000000000000u128,
+				10000000000000000000u128
+			).unwrap(),
+			2945999999999999998800u128
+		);
 	}
 
 	#[test]