Use scale-encode and scale-decode to encode and decode based on metadata (#842)

* WIP EncodeAsType and DecodeAsType

* remove silly cli experiment code

* Get things finally compiling with EncodeAsType and DecodeAsType

* update codegen test and WrapperKeepOpaque proper impl (in case it shows up in codegen)

* fix tests

* accomodate scale-value changes

* starting to migrate to EncodeAsType/DecodeAsType

* static event decoding and tx encoding to use DecodeAsFields/EncodeAsFields

* some tidy up and add decode(skip) attrs where needed

* fix root event decoding

* #[codec(skip)] will do, and combine map_key stuff into storage_address since it's all specific to that

* fmt and clippy

* update Cargo.lock

* remove patched scale-encode

* bump scale-encode to 0.1 and remove unused dep in testing crate

* update deps and use released scale-decode

* update scale-value to latest to remove git branch

* Apply suggestions from code review

Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>

* remove sorting in derives/attr generation; spit them out in order given

* re-add derive sorting; it's a hashmap

* StaticTxPayload and DynamicTxPayload rolled into single Payload struct

* StaticStorageAddress and DynamicStorageAddress into single Address struct

* Fix storage address byte retrieval

* StaticConstantAddress and DynamicConstantAddress => Address

* Simplify storage codegen to fix test

* Add comments

* Alias to RuntimeEvent rather than making another, and prep for substituting call type

* remove unnecessary clone

* Fix docs and failing UI test

* root_bytes -> to_root_bytes

* document error case in StorageClient::address_bytes()

---------

Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>

testing/integration-tests/src/client/mod.rs

@@ -466,10 +466,12 @@ async fn chainhead_unstable_storage() {
     let sub_id = blocks.subscription_id().unwrap().clone();
 
     let alice: AccountId32 = AccountKeyring::Alice.to_account_id().into();
-    let addr = node_runtime::storage().system().account(alice).to_bytes();
+    let addr = node_runtime::storage().system().account(alice);
+    let addr_bytes = api.storage().address_bytes(&addr).unwrap();
+
     let mut sub = api
         .rpc()
-        .chainhead_unstable_storage(sub_id, hash, &addr, None)
+        .chainhead_unstable_storage(sub_id, hash, &addr_bytes, None)
         .await
         .unwrap();
     let event = sub.next().await.unwrap().unwrap();

testing/integration-tests/src/codegen/mod.rs

@@ -5,10 +5,11 @@
 /// Checks that code generated by `subxt-cli codegen` compiles. Allows inspection of compiler errors
 /// directly, more accurately than via the macro and `cargo expand`.
 ///
-/// Generate by:
+/// Generate by running this at the root of the repository:
 ///
-/// - run `polkadot --dev --tmp` node locally
-/// - `cargo run -p subxt-cli -- codegen | rustfmt > testing/integration-tests/src/codegen/polkadot.rs`
+/// ```
+/// cargo run --bin subxt -- codegen --file artifacts/polkadot_metadata.scale | rustfmt > testing/integration-tests/src/codegen/polkadot.rs
+/// ```
 #[rustfmt::skip]
 #[allow(clippy::all)]
 mod polkadot;

testing/integration-tests/src/frame/contracts.rs

@@ -219,6 +219,8 @@ async fn tx_call() {
         .contracts()
         .contract_info_of(&contract);
 
+    let info_addr_bytes = cxt.client().storage().address_bytes(&info_addr).unwrap();
+
     let contract_info = cxt
         .client()
         .storage()
@@ -235,7 +237,7 @@ async fn tx_call() {
         .at(None)
         .await
         .unwrap()
-        .fetch_keys(&info_addr.to_bytes(), 10, None)
+        .fetch_keys(&info_addr_bytes, 10, None)
         .await
         .unwrap()
         .iter()

testing/integration-tests/src/frame/staking.rs

@@ -5,9 +5,12 @@
 use crate::{
     node_runtime::{
         self,
-        runtime_types::pallet_staking::{
-            RewardDestination,
-            ValidatorPrefs,
+        runtime_types::{
+            pallet_staking::{
+                RewardDestination,
+                ValidatorPrefs,
+            },
+            sp_arithmetic::per_things::Perbill,
         },
         staking,
     },
@@ -33,7 +36,7 @@ fn get_from_seed(seed: &str) -> sr25519::Pair {
 
 fn default_validator_prefs() -> ValidatorPrefs {
     ValidatorPrefs {
-        commission: sp_runtime::Perbill::default(),
+        commission: Perbill(0),
         blocked: false,
     }
 }

testing/integration-tests/src/storage/mod.rs

@@ -70,11 +70,14 @@ async fn storage_n_mapish_key_is_properly_created() -> Result<(), subxt::Error>
     use codec::Encode;
     use node_runtime::runtime_types::sp_core::crypto::KeyTypeId;
 
+    let ctx = test_context().await;
+    let api = ctx.client();
+
     // This is what the generated code hashes a `session().key_owner(..)` key into:
-    let actual_key_bytes = node_runtime::storage()
+    let actual_key = node_runtime::storage()
         .session()
-        .key_owner(KeyTypeId([1, 2, 3, 4]), [5u8, 6, 7, 8])
-        .to_bytes();
+        .key_owner(KeyTypeId([1, 2, 3, 4]), [5u8, 6, 7, 8]);
+    let actual_key_bytes = api.storage().address_bytes(&actual_key)?;
 
     // Let's manually hash to what we assume it should be and compare:
     let expected_key_bytes = {