From c74537fefdfdca0f87d74e5ab7cd27c1a970944f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bastian=20K=C3=B6cher?= Date: Mon, 7 Dec 2020 21:57:49 +0100 Subject: [PATCH] Do not spam when we can not send a message to a job (#2084) * Do not spam when we can not send a message to a job There are legal reasons why a job ended. If a job failed, the error is logged. So, we don't need to log an error when we can not send a message to a job. * Review feedback --- polkadot/node/subsystem-util/src/lib.rs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/polkadot/node/subsystem-util/src/lib.rs b/polkadot/node/subsystem-util/src/lib.rs index 82c3310f21..9cc68834be 100644 --- a/polkadot/node/subsystem-util/src/lib.rs +++ b/polkadot/node/subsystem-util/src/lib.rs @@ -610,10 +610,6 @@ impl Jobs { async fn send_msg(&mut self, parent_hash: Hash, msg: Job::ToJob) { if let Entry::Occupied(mut job) = self.running.entry(parent_hash) { if job.get_mut().send_msg(msg).await.is_err() { - tracing::warn!( - job = Job::NAME, - relay_parent = ?parent_hash, - "failed to send message to job, will remove it"); job.remove(); } }