From c7cd82784b5768c0ed3189e0505ad3d99dc0772a Mon Sep 17 00:00:00 2001 From: Sergei Pepyakin Date: Thu, 9 May 2019 19:02:55 +0200 Subject: [PATCH] Add a simple PR template (#2510) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Add a basic PR template * Update * Update * Another iteration. * Fixes. * Apply suggestions from code review Co-Authored-By: Bastian Köcher * Be not rude * Label only if you have permissions --- substrate/PULL_REQUEST_TEMPLATE.md | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 substrate/PULL_REQUEST_TEMPLATE.md diff --git a/substrate/PULL_REQUEST_TEMPLATE.md b/substrate/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000000..9b368f3f04 --- /dev/null +++ b/substrate/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,22 @@ +Thank you for your Pull Request! + +Before you submitting, please check that: + +- [ ] You added a brief description of the PR, e.g.: + - What does it do? + - What important points reviewers should know? + - Is there something left for follow-up PRs? +- [ ] You labeled the PR with appropriate labels if you have permissions to do so. +- [ ] You mentioned a related issue if this PR related to it, e.g. `Fixes #228` or `Related #1337`. +- [ ] You asked any particular reviewers to review. If you aren't sure, start with GH suggestions. +- [ ] Your PR adheres [the style guide](https://github.com/paritytech/polkadot/wiki/Style-Guide) + - In particular, mind the maximal line length. + - There is no commented code checked in unless necessary. + - Any panickers have a proof or removed. +- [ ] You bumped the runtime version if there are breaking changes in the **runtime**. +- [ ] You updated any rustdocs which may have changed + +After you've read this notice feel free to remove it. +Thank you! + +✄ -----------------------------------------------------------------------------