pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-06-13 09:21:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

paras: include_pvf_check_statement rt bench (#4938)

Browse Source 
* paras: `include_pvf_check_statement` rt bench

Resolves #4933

This PR adds a benchmark for the `include_pvf_check_statement`
dispatchable. This is a necessary step to make it work without
modifications. That enables us to proceed with testing on Versi.

This introduces 5 new benchmarks. Those measure performance of the
`include_pvf_check_statement` under 2 different conditions:

1. regular vote submission. That's the common case.
2. submission of the last vote. That happens only once and leads to a
   heavy finalization stage.

There are 2 different types of finalization (one for onboarding, one for
upgrading) and there are two outcomes: accepted and rejected. Those 4
are similar but I decided to cover them all and assign the maximum of
all 4. This is to avoid a situation when one of those paths becomes more
heavier than others and opens up an attack venue.

The regular vote submission weight is drastically different from the
submission last vote weight. That's why in case during runtime
finalization was not executed the weight consumed value will be lowered
down to the regular vote submission.

The finalization weight is proportional to the number of "causes", i.e.
the events that caused the PVF pre-checking vote in the first place, and
here we assume that the maximum number of causes is 100.

Theoretically, there is nothing that prevents an adversary to
register/upgrade to more than 100 parachains. In that case, the consumed
weight will be lower than the actual time consumed by the finalization
process. That can enable a DoS vector.

However, practically, it is not very possible. Right now it is very
expensive to call `schedule_para_initialize` because it requires a very
large lock up of funds. Moreover, finalizing a vote with 100 causes
leads to around 31ms time spent. Finalizing more will require more time.
However, finalizing with 200 causes will cause ≈62ms delay. This is not
that bad since even though we had a full block and the adversary tried
to finalize 200 causes it won't be able to even exceed the operational
extrinsic boundary of 250ms and even if so it won't make big difference.

That said, this should be addressed later on, esp. when we enable
parathreads, which will make creating causes easier. One of potential
solutions will be shifting the logic of finalization into
`on_initialize`/`on_finalize`. Another is to create a maximum number of
causes and then reject upgrades or onboardings if that was reached.

* cargo run --quiet --profile=production  --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_paras.rs

* cargo run --quiet --profile=production  --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_paras.rs

* cargo run --quiet --profile=production  --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_paras.rs

* cargo run --quiet --profile=production --features runtime-benchmarks -- benchmark --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/rococo/src/weights/runtime_parachains_paras.rs

* Fix import error

Co-authored-by: Parity Bot <admin@parity.io>
Co-authored-by: Robert Klotzner <robert.klotzner@gmx.at>
Co-authored-by: Lldenaurois <Ljdenaurois@gmail.com>
This commit is contained in:
Sergei Shulepov
2022-03-24 17:52:40 +01:00
committed by GitHub
parent aa89374d4a
commit c8fda4f1b6
11 changed files with 635 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files
polkadot/runtime/rococo/src/weights/runtime_parachains_paras.rs
+68 -6
View File
@@ -1,4 +1,4 @@
// Copyright 2017-2022 Parity Technologies (UK) Ltd.
// Copyright 2017-2021 Parity Technologies (UK) Ltd.
// This file is part of Polkadot.
// Polkadot is free software: you can redistribute it and/or modify
@@ -16,7 +16,7 @@
//! Autogenerated weights for `runtime_parachains::paras`
//!
//! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 4.0.0-dev
//! DATE: 2022-03-14, STEPS: `50`, REPEAT: 20, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! DATE: 2022-02-21, STEPS: `50`, REPEAT: 20, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! EXECUTION: Some(Wasm), WASM-EXECUTION: Compiled, CHAIN: Some("rococo-dev"), DB CACHE: 1024
// Executed Command:
@@ -58,7 +58,7 @@ impl<T: frame_system::Config> runtime_parachains::paras::WeightInfo for WeightIn
}
// Storage: Paras Heads (r:0 w:1)
fn force_set_current_head(s: u32, ) -> Weight {
(11_885_000 as Weight)
(10_856_000 as Weight)
// Standard Error: 0
.saturating_add((1_000 as Weight).saturating_mul(s as Weight))
.saturating_add(T::DbWeight::get().writes(1 as Weight))
@@ -85,7 +85,7 @@ impl<T: frame_system::Config> runtime_parachains::paras::WeightInfo for WeightIn
// Storage: Paras Heads (r:0 w:1)
// Storage: Paras UpgradeGoAheadSignal (r:0 w:1)
fn force_note_new_head(s: u32, ) -> Weight {
(14_996_000 as Weight)
(13_762_000 as Weight)
// Standard Error: 0
.saturating_add((1_000 as Weight).saturating_mul(s as Weight))
.saturating_add(T::DbWeight::get().reads(1 as Weight))
@@ -94,7 +94,7 @@ impl<T: frame_system::Config> runtime_parachains::paras::WeightInfo for WeightIn
// Storage: ParasShared CurrentSessionIndex (r:1 w:0)
// Storage: Paras ActionsQueue (r:1 w:1)
fn force_queue_action() -> Weight {
(15_924_000 as Weight)
(15_946_000 as Weight)
.saturating_add(T::DbWeight::get().reads(2 as Weight))
.saturating_add(T::DbWeight::get().writes(1 as Weight))
}
@@ -110,8 +110,70 @@ impl<T: frame_system::Config> runtime_parachains::paras::WeightInfo for WeightIn
// Storage: Paras CodeByHashRefs (r:1 w:0)
// Storage: Paras CodeByHash (r:0 w:1)
fn poke_unused_validation_code() -> Weight {
(2_424_000 as Weight)
(2_509_000 as Weight)
.saturating_add(T::DbWeight::get().reads(1 as Weight))
.saturating_add(T::DbWeight::get().writes(1 as Weight))
}
// Storage: Configuration ActiveConfig (r:1 w:0)
// Storage: ParasShared ActiveValidatorKeys (r:1 w:0)
// Storage: ParasShared CurrentSessionIndex (r:1 w:0)
// Storage: Paras PvfActiveVoteMap (r:1 w:1)
fn include_pvf_check_statement() -> Weight {
(117_675_000 as Weight)
.saturating_add(T::DbWeight::get().reads(4 as Weight))
.saturating_add(T::DbWeight::get().writes(1 as Weight))
}
// Storage: Configuration ActiveConfig (r:1 w:0)
// Storage: ParasShared ActiveValidatorKeys (r:1 w:0)
// Storage: ParasShared CurrentSessionIndex (r:1 w:0)
// Storage: Paras PvfActiveVoteMap (r:1 w:1)
// Storage: Paras PvfActiveVoteList (r:1 w:1)
// Storage: Paras UpcomingUpgrades (r:1 w:1)
// Storage: System Digest (r:1 w:1)
// Storage: Paras FutureCodeUpgrades (r:0 w:100)
fn include_pvf_check_statement_finalize_upgrade_accept() -> Weight {
(618_769_000 as Weight)
.saturating_add(T::DbWeight::get().reads(7 as Weight))
.saturating_add(T::DbWeight::get().writes(104 as Weight))
}
// Storage: Configuration ActiveConfig (r:1 w:0)
// Storage: ParasShared ActiveValidatorKeys (r:1 w:0)
// Storage: ParasShared CurrentSessionIndex (r:1 w:0)
// Storage: Paras PvfActiveVoteMap (r:1 w:1)
// Storage: Paras PvfActiveVoteList (r:1 w:1)
// Storage: Paras CodeByHashRefs (r:1 w:1)
// Storage: Paras CodeByHash (r:0 w:1)
// Storage: Paras UpgradeGoAheadSignal (r:0 w:100)
// Storage: Paras FutureCodeHash (r:0 w:100)
fn include_pvf_check_statement_finalize_upgrade_reject() -> Weight {
(553_319_000 as Weight)
.saturating_add(T::DbWeight::get().reads(6 as Weight))
.saturating_add(T::DbWeight::get().writes(204 as Weight))
}
// Storage: Configuration ActiveConfig (r:1 w:0)
// Storage: ParasShared ActiveValidatorKeys (r:1 w:0)
// Storage: ParasShared CurrentSessionIndex (r:1 w:0)
// Storage: Paras PvfActiveVoteMap (r:1 w:1)
// Storage: Paras PvfActiveVoteList (r:1 w:1)
// Storage: Paras ActionsQueue (r:1 w:1)
fn include_pvf_check_statement_finalize_onboarding_accept() -> Weight {
(507_519_000 as Weight)
.saturating_add(T::DbWeight::get().reads(6 as Weight))
.saturating_add(T::DbWeight::get().writes(3 as Weight))
}
// Storage: Configuration ActiveConfig (r:1 w:0)
// Storage: ParasShared ActiveValidatorKeys (r:1 w:0)
// Storage: ParasShared CurrentSessionIndex (r:1 w:0)
// Storage: Paras PvfActiveVoteMap (r:1 w:1)
// Storage: Paras PvfActiveVoteList (r:1 w:1)
// Storage: Paras CodeByHashRefs (r:1 w:1)
// Storage: Paras ParaLifecycles (r:0 w:100)
// Storage: Paras CodeByHash (r:0 w:1)
// Storage: Paras CurrentCodeHash (r:0 w:100)
// Storage: Paras UpcomingParasGenesis (r:0 w:100)
fn include_pvf_check_statement_finalize_onboarding_reject() -> Weight {
(609_820_000 as Weight)
.saturating_add(T::DbWeight::get().reads(6 as Weight))
.saturating_add(T::DbWeight::get().writes(304 as Weight))
}
}