From cff487dd222d699e3d173df162c97c7590dedd36 Mon Sep 17 00:00:00 2001 From: Pierre Krieger Date: Sat, 18 Apr 2020 14:04:23 +0200 Subject: [PATCH] Refactor misleading log in discovery (#5679) * Refactor misleading log * Forgot to git add the compilation fix --- substrate/client/network/src/discovery.rs | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/substrate/client/network/src/discovery.rs b/substrate/client/network/src/discovery.rs index fc78e9b3e3..f3b9c5cc71 100644 --- a/substrate/client/network/src/discovery.rs +++ b/substrate/client/network/src/discovery.rs @@ -375,9 +375,10 @@ impl NetworkBehaviour for DiscoveryBehaviour { list.extend(list_to_filter); } - trace!(target: "sub-libp2p", "Addresses of {:?} are {:?}", peer_id, list); + if !list.is_empty() { + trace!(target: "sub-libp2p", "Addresses of {:?}: {:?}", peer_id, list); - if list.is_empty() { + } else { let mut has_entry = false; for k in self.kademlias.values_mut() { if k.kbuckets_entries().any(|p| p == peer_id) { @@ -386,15 +387,12 @@ impl NetworkBehaviour for DiscoveryBehaviour { } } if has_entry { - debug!(target: "sub-libp2p", - "Requested dialing to {:?} (peer in k-buckets), and no address was found", - peer_id); + trace!(target: "sub-libp2p", "Addresses of {:?}: none (peer in k-buckets)", peer_id); } else { - debug!(target: "sub-libp2p", - "Requested dialing to {:?} (peer not in k-buckets), and no address was found", - peer_id); + trace!(target: "sub-libp2p", "Addresses of {:?}: none (peer not in k-buckets)", peer_id); } } + list }