pallet-xcm: fix weights for all XTs and deprecate unlimited weight ones (#3927)

Fix "double-weights" for extrinsics, use only the ones benchmarked in
the runtime.

Deprecate extrinsics that don't specify WeightLimit, remove their usage
across the repo.

---------

Signed-off-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: command-bot <>

polkadot/runtime/westend/src/tests.rs

@@ -54,11 +54,12 @@ fn sanity_check_teleport_assets_weight() {
 	// Usually when XCM runs into an issue, it will return a weight of `Weight::MAX`,
 	// so this test will certainly ensure that this problem does not occur.
 	use frame_support::dispatch::GetDispatchInfo;
-	let weight = pallet_xcm::Call::<Runtime>::teleport_assets {
+	let weight = pallet_xcm::Call::<Runtime>::limited_teleport_assets {
 		dest: Box::new(Here.into()),
 		beneficiary: Box::new(Here.into()),
 		assets: Box::new((Here, 200_000).into()),
 		fee_asset_item: 0,
+		weight_limit: Unlimited,
 	}
 	.get_dispatch_info()
 	.weight;