diff --git a/.gitlab/pipeline/test.yml b/.gitlab/pipeline/test.yml
index f6dad887a6..0e7d96f3db 100644
--- a/.gitlab/pipeline/test.yml
+++ b/.gitlab/pipeline/test.yml
@@ -438,6 +438,7 @@ cargo-check-each-crate:
- .run-immediately
# - .collect-artifacts
variables:
+ RUSTFLAGS: "-D warnings"
# $CI_JOB_NAME is set manually so that cache could be shared for all jobs
# "cargo-check-each-crate I/N" jobs
CI_JOB_NAME: cargo-check-each-crate
diff --git a/substrate/client/network/src/behaviour.rs b/substrate/client/network/src/behaviour.rs
index 9f770bc3ba..745550412f 100644
--- a/substrate/client/network/src/behaviour.rs
+++ b/substrate/client/network/src/behaviour.rs
@@ -39,7 +39,7 @@ use parking_lot::Mutex;
use sp_runtime::traits::Block as BlockT;
use std::{collections::HashSet, sync::Arc, time::Duration};
-pub use crate::request_responses::{InboundFailure, OutboundFailure, RequestId, ResponseFailure};
+pub use crate::request_responses::{InboundFailure, OutboundFailure, ResponseFailure};
/// General behaviour of the network. Combines all protocols together.
#[derive(NetworkBehaviour)]
diff --git a/substrate/client/network/src/protocol/message.rs b/substrate/client/network/src/protocol/message.rs
index 247580083f..5f2511fd6d 100644
--- a/substrate/client/network/src/protocol/message.rs
+++ b/substrate/client/network/src/protocol/message.rs
@@ -19,10 +19,6 @@
//! Network packet message types. These get serialized and put into the lower level protocol
//! payload.
-pub use self::generic::{
- RemoteCallRequest, RemoteChangesRequest, RemoteChangesResponse, RemoteHeaderRequest,
- RemoteHeaderResponse, RemoteReadChildRequest, RemoteReadRequest,
-};
use codec::{Decode, Encode};
use sc_client_api::StorageProof;
use sc_network_common::message::RequestId;
diff --git a/substrate/client/network/src/protocol/notifications/upgrade.rs b/substrate/client/network/src/protocol/notifications/upgrade.rs
index 70c6023623..8fd837f949 100644
--- a/substrate/client/network/src/protocol/notifications/upgrade.rs
+++ b/substrate/client/network/src/protocol/notifications/upgrade.rs
@@ -16,12 +16,14 @@
// You should have received a copy of the GNU General Public License
// along with this program. If not, see .
+#[cfg(test)]
+pub(crate) use self::notifications::{
+ NotificationsInOpen, NotificationsInSubstreamHandshake, NotificationsOutOpen,
+};
pub use self::{
collec::UpgradeCollec,
notifications::{
- NotificationsHandshakeError, NotificationsIn, NotificationsInOpen,
- NotificationsInSubstream, NotificationsInSubstreamHandshake, NotificationsOut,
- NotificationsOutError, NotificationsOutOpen, NotificationsOutSubstream,
+ NotificationsIn, NotificationsInSubstream, NotificationsOut, NotificationsOutSubstream,
},
};
diff --git a/substrate/client/offchain/src/api.rs b/substrate/client/offchain/src/api.rs
index 40f866b6d2..65e2f3ba64 100644
--- a/substrate/client/offchain/src/api.rs
+++ b/substrate/client/offchain/src/api.rs
@@ -30,7 +30,6 @@ use sp_core::{
},
OpaquePeerId,
};
-pub use sp_offchain::STORAGE_PREFIX;
mod http;
diff --git a/substrate/client/transaction-pool/src/graph/mod.rs b/substrate/client/transaction-pool/src/graph/mod.rs
index 5afdddb740..484a6d6cf9 100644
--- a/substrate/client/transaction-pool/src/graph/mod.rs
+++ b/substrate/client/transaction-pool/src/graph/mod.rs
@@ -39,9 +39,6 @@ pub mod watcher;
pub use self::{
base_pool::Transaction,
- pool::{
- BlockHash, ChainApi, EventStream, ExtrinsicFor, ExtrinsicHash, NumberFor, Options, Pool,
- TransactionFor,
- },
+ pool::{BlockHash, ChainApi, ExtrinsicFor, ExtrinsicHash, NumberFor, Options, Pool},
};
pub use validated_pool::{IsValidator, ValidatedTransaction};
diff --git a/substrate/frame/contracts/proc-macro/src/lib.rs b/substrate/frame/contracts/proc-macro/src/lib.rs
index 4ef02497b8..9dc34d5223 100644
--- a/substrate/frame/contracts/proc-macro/src/lib.rs
+++ b/substrate/frame/contracts/proc-macro/src/lib.rs
@@ -74,7 +74,7 @@ fn derive_debug(input: TokenStream, fmt: impl Fn(&Ident) -> TokenStream2) -> Tok
#[cfg(not(feature = "full"))]
let fields = {
drop(fmt);
- drop(data);
+ let _ = data;
TokenStream2::new()
};
diff --git a/substrate/primitives/api/proc-macro/src/utils.rs b/substrate/primitives/api/proc-macro/src/utils.rs
index 68f0a77a39..c8c1f12d90 100644
--- a/substrate/primitives/api/proc-macro/src/utils.rs
+++ b/substrate/primitives/api/proc-macro/src/utils.rs
@@ -19,7 +19,7 @@ use crate::common::API_VERSION_ATTRIBUTE;
use inflector::Inflector;
use proc_macro2::{Span, TokenStream};
use proc_macro_crate::{crate_name, FoundCrate};
-use quote::{format_ident, quote, ToTokens};
+use quote::{format_ident, quote};
use syn::{
parse_quote, spanned::Spanned, token::And, Attribute, Error, FnArg, GenericArgument, Ident,
ImplItem, ItemImpl, Pat, Path, PathArguments, Result, ReturnType, Signature, Type, TypePath,
@@ -261,6 +261,7 @@ pub fn versioned_trait_name(trait_ident: &Ident, version: u64) -> Ident {
/// Extract the documentation from the provided attributes.
#[cfg(feature = "frame-metadata")]
pub fn get_doc_literals(attrs: &[syn::Attribute]) -> Vec {
+ use quote::ToTokens;
attrs
.iter()
.filter_map(|attr| {
diff --git a/substrate/primitives/state-machine/src/lib.rs b/substrate/primitives/state-machine/src/lib.rs
index 1345097e8f..5909a30a81 100644
--- a/substrate/primitives/state-machine/src/lib.rs
+++ b/substrate/primitives/state-machine/src/lib.rs
@@ -142,7 +142,6 @@ pub use crate::{
mod std_reexport {
pub use crate::{
basic::BasicExternalities,
- error::{Error, ExecutionError},
in_memory_backend::new_in_mem,
read_only::{InspectState, ReadOnlyExternalities},
testing::TestExternalities,