Upgrade to substrate rc4 release (#131)

* Upgrade to substrate rc4 release

* Fix up test-node/service

* Fix up client node config

* Fix up remaining compilation errors

* Fmt

* Remove fixme

* Fix test

* Release v0.10.0

client/Cargo.toml

@@ -17,10 +17,10 @@ futures = { version = "0.3.5", features = ["compat"] }
 futures01 = { package = "futures", version = "0.1.29" }
 jsonrpsee = "0.1.0"
 log = "0.4.8"
-sc-network = { version = "0.8.0-rc3", default-features = false }
-sc-service = { version = "0.8.0-rc3", default-features = false }
+sc-network = { version = "0.8.0-rc4", default-features = false }
+sc-service = { version = "0.8.0-rc4", default-features = false }
 serde_json = "1.0.55"
-sp-keyring = "2.0.0-rc3"
+sp-keyring = "2.0.0-rc4"
 thiserror = "1.0.20"
 
 [dev-dependencies]

client/src/lib.rs

@@ -208,12 +208,13 @@ fn start_subxt_client<C: ChainSpec + 'static, S: AbstractService>(
         impl_version: config.impl_version,
         chain_spec: Box::new(config.chain_spec),
         role: config.role.into(),
-        task_executor: std::sync::Arc::new(move |fut, ty| {
+        task_executor: (move |fut, ty| {
             match ty {
                 TaskType::Async => task::spawn(fut),
                 TaskType::Blocking => task::spawn_blocking(|| task::block_on(fut)),
             };
-        }),
+        })
+        .into(),
         database: config.db,
         keystore: KeystoreConfig::InMemory,
         max_runtime_instances: 8,
@@ -231,6 +232,7 @@ fn start_subxt_client<C: ChainSpec + 'static, S: AbstractService>(
         pruning: Default::default(),
         rpc_cors: Default::default(),
         rpc_http: Default::default(),
+        rpc_ipc: Default::default(),
         rpc_ws: Default::default(),
         rpc_ws_max_connections: Default::default(),
         rpc_methods: Default::default(),
@@ -240,6 +242,8 @@ fn start_subxt_client<C: ChainSpec + 'static, S: AbstractService>(
         tracing_targets: Default::default(),
         transaction_pool: Default::default(),
         wasm_method: Default::default(),
+        base_path: Default::default(),
+        informant_output_format: Default::default(),
     };
 
     log::info!("{}", service_config.impl_name);
@@ -329,6 +333,7 @@ mod tests {
             test_node::chain_spec::ChainSpec::from_json_bytes(bytes).unwrap();
         let tmp = TempDir::new("subxt-").expect("failed to create tempdir");
         let config = SubxtClientConfig {
+            // base_path:
             impl_name: "substrate-subxt-light-client",
             impl_version: "0.0.1",
             author: "David Craven",