pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-06-13 18:41:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

client/authority-discovery: Do not double encode signature (#5901)

Browse Source 
Previously, when publishing ones address onto the DHT, the signature
signing those addresses would be SCALE encoded twice.

This commit removes the second encoding and adjusts the tests
to catch future regressions.
This commit is contained in:
Max Inden
2020-05-06 10:52:44 +02:00
committed by GitHub
parent 3860999ea3
commit d40bf3cf36
3 changed files with 69 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files
substrate/primitives/core/src/traits.rs
+3 -3
View File
@@ -120,7 +120,7 @@ pub trait BareCryptoStore: Send + Sync {
/// Given a list of public keys, find the first supported key and
/// sign the provided message with that key.
///
/// Returns a tuple of the used key and the signature
/// Returns a tuple of the used key and the SCALE encoded signature.
fn sign_with_any(
&self,
id: KeyTypeId,
@@ -144,8 +144,8 @@ pub trait BareCryptoStore: Send + Sync {
/// Provided a list of public keys, sign a message with
/// each key given that the key is supported.
///
/// Returns a list of `Result`s each representing the signature of each key or
/// a BareCryptoStoreError for non-supported keys.
/// Returns a list of `Result`s each representing the SCALE encoded
/// signature of each key or a BareCryptoStoreError for non-supported keys.
fn sign_with_all(
&self,
id: KeyTypeId,