Fix clippy warnings (#7625)

* Fix clippy check

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Autofix clippy

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix trivial

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* fmt

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* suppress warnings

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Quiet clippy 😌

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

polkadot/node/network/availability-distribution/src/tests/state.rs

@@ -123,13 +123,13 @@ impl Default for TestState {
 						let (core, chunk) = OccupiedCoreBuilder {
 							group_responsible: GroupIndex(i as _),
 							para_id: *para_id,
-							relay_parent: relay_parent.clone(),
+							relay_parent: *relay_parent,
 						}
 						.build();
 						(CoreState::Occupied(core), chunk)
 					})
 					.unzip();
-				cores.insert(relay_child.clone(), p_cores);
+				cores.insert(*relay_child, p_cores);
 				// Skip chunks for our own group (won't get fetched):
 				let mut chunks_other_groups = p_chunks.into_iter();
 				chunks_other_groups.next();
@@ -176,12 +176,12 @@ impl TestState {
 				.zip(advanced)
 				.map(|(old, new)| ActiveLeavesUpdate {
 					activated: Some(ActivatedLeaf {
-						hash: new.clone(),
+						hash: *new,
 						number: 1,
 						status: LeafStatus::Fresh,
 						span: Arc::new(jaeger::Span::Disabled),
 					}),
-					deactivated: vec![old.clone()].into(),
+					deactivated: vec![*old].into(),
 				})
 				.collect::<Vec<_>>()
 		};
@@ -239,8 +239,7 @@ impl TestState {
 					let chunk = self
 						.chunks
 						.get_mut(&(candidate_hash, validator_index))
-						.map(Vec::pop)
-						.flatten()
+						.and_then(Vec::pop)
 						.flatten();
 					tx.send(chunk).expect("Receiver is expected to be alive");
 				},