Switch to pooling copy-on-write instantiation strategy for WASM (companion for Substrate#11232) (#5337)

* Switch to pooling copy-on-write instantiation strategy for WASM

* Fix compilation of `polkadot-test-service`

* Update comments

* Move `max_memory_size` to `Semantics`

* Rename `WasmInstantiationStrategy` to `WasmtimeInstantiationStrategy`

* Update a safety comment

* update lockfile for {"substrate"}

Co-authored-by: parity-processbot <>

polkadot/node/core/pvf/src/execute/worker.rs

@@ -15,7 +15,7 @@
 // along with Polkadot.  If not, see <http://www.gnu.org/licenses/>.
 
 use crate::{
-	artifacts::{ArtifactPathId, CompiledArtifact},
+	artifacts::ArtifactPathId,
 	executor_intf::TaskExecutor,
 	worker_common::{
 		bytes_to_path, framed_recv, framed_send, path_to_bytes, spawn_with_program_path,
@@ -206,29 +206,12 @@ async fn validate_using_artifact(
 	params: &[u8],
 	spawner: &TaskExecutor,
 ) -> Response {
-	let artifact_bytes = match async_std::fs::read(artifact_path).await {
-		Err(e) =>
-			return Response::InternalError(format!(
-				"failed to read the artifact at {}: {:?}",
-				artifact_path.display(),
-				e,
-			)),
-		Ok(b) => b,
-	};
-
-	let artifact = match CompiledArtifact::decode(&mut artifact_bytes.as_slice()) {
-		Err(e) => return Response::InternalError(format!("artifact deserialization: {:?}", e)),
-		Ok(a) => a,
-	};
-
-	let compiled_artifact = artifact.as_ref();
-
 	let validation_started_at = Instant::now();
 	let descriptor_bytes = match unsafe {
 		// SAFETY: this should be safe since the compiled artifact passed here comes from the
 		//         file created by the prepare workers. These files are obtained by calling
 		//         [`executor_intf::prepare`].
-		crate::executor_intf::execute(compiled_artifact, params, spawner.clone())
+		crate::executor_intf::execute(artifact_path.as_ref(), params, spawner.clone())
 	} {
 		Err(err) => return Response::format_invalid("execute", &err.to_string()),
 		Ok(d) => d,