Infrastructure improvements (#2897)

* Factor out runtime module into utils.

* Add maybe_authority information to `PeerConnected` event.

We already gather this information in authority discovery, so we might
as well share it with others.

This opens up an easy path to trigger validators differently from normal
nodes, e.g. for prioritization. This change has become more important
now, that we just connect to all validators and therefore just have a
long peer list without any information about those nodes.

* Test fix.
This commit is contained in:
Robert Klotzner
2021-04-16 21:42:20 +02:00
committed by GitHub
parent 23db3479a0
commit dacde443f7
19 changed files with 175 additions and 76 deletions
@@ -791,7 +791,7 @@ async fn handle_network_msg(
use NetworkBridgeEvent::*;
match bridge_message {
PeerConnected(peer_id, observed_role) => {
PeerConnected(peer_id, observed_role, _) => {
// If it is possible that a disconnected validator would attempt a reconnect
// it should be handled here.
tracing::trace!(
@@ -1343,6 +1343,7 @@ mod tests {
NetworkBridgeEvent::PeerConnected(
peer.clone(),
polkadot_node_network_protocol::ObservedRole::Authority,
None,
),
),
).await;
@@ -873,7 +873,7 @@ where
use NetworkBridgeEvent::*;
match bridge_message {
PeerConnected(peer_id, _role) => {
PeerConnected(peer_id, _role, _) => {
state.peer_data.entry(peer_id).or_default();
state.metrics.note_collator_peer_count(state.peer_data.len());
},
@@ -1469,6 +1469,7 @@ mod tests {
NetworkBridgeEvent::PeerConnected(
peer_b,
ObservedRole::Full,
None,
),
)
).await;
@@ -1543,6 +1544,7 @@ mod tests {
NetworkBridgeEvent::PeerConnected(
peer_b,
ObservedRole::Full,
None,
),
)
).await;
@@ -1553,6 +1555,7 @@ mod tests {
NetworkBridgeEvent::PeerConnected(
peer_c,
ObservedRole::Full,
None,
),
)
).await;
@@ -1636,6 +1639,7 @@ mod tests {
NetworkBridgeEvent::PeerConnected(
peer_b,
ObservedRole::Full,
None,
),
)
).await;
@@ -1704,6 +1708,7 @@ mod tests {
NetworkBridgeEvent::PeerConnected(
peer_b,
ObservedRole::Full,
None,
),
)
).await;
@@ -1714,6 +1719,7 @@ mod tests {
NetworkBridgeEvent::PeerConnected(
peer_c,
ObservedRole::Full,
None,
),
)
).await;
@@ -1918,6 +1924,7 @@ mod tests {
NetworkBridgeEvent::PeerConnected(
peer_b.clone(),
ObservedRole::Full,
None,
)
)
).await;
@@ -2012,6 +2019,7 @@ mod tests {
NetworkBridgeEvent::PeerConnected(
peer_b.clone(),
ObservedRole::Full,
None,
)
)
).await;
@@ -2153,6 +2161,7 @@ mod tests {
NetworkBridgeEvent::PeerConnected(
peer_b.clone(),
ObservedRole::Full,
None,
)
)
).await;
@@ -2199,6 +2208,7 @@ mod tests {
NetworkBridgeEvent::PeerConnected(
peer_b.clone(),
ObservedRole::Full,
None,
)
)
).await;
@@ -2270,6 +2280,7 @@ mod tests {
NetworkBridgeEvent::PeerConnected(
peer_b.clone(),
ObservedRole::Full,
None,
)
)
).await;