mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-04-26 18:07:58 +00:00
Init System Parachain storage versions and add migration check jobs to CI (#1344)
Makes SPs first class citizens along with the relay chains in the context of our CI runtime upgrade checks. ## Code changes - Sets missing current storage version in `uniques` pallet - Adds multisig V1 migration to run where it was missing - Removes executed migration whos pre/post hooks were failing from collectives runtime - Initializes storage versions for SP pallets added after genesis - Originally I was going to wait for https://github.com/paritytech/polkadot-sdk/pull/1297 to be merged so this wouldn't need to be done manually, but it doesn't seem like it'll be merged any time soon so I've decided to set them manually to unblock this ## CI changes - Removed dependency of `westend` runtime upgrades being complete prior to other ones running. I assume it is supposed to cache the `try-runtime` build for a performance benefit, but it seems it wasn't working. Maybe someone from the CI team can look into this or explain why it needs to be there? - Adds check-runtime-migration jobs for Parity asset-hubs, bridge-hubs and contract chains - Updated VARIABLES to accomodate the `kusama-runtime` package being renamed to `staging-kusama-runtime` in https://github.com/paritytech/polkadot-sdk/pull/1241 - Added `EXTRA_ARGS` variable to `check-runtime-migration`, and set `--no-weight-warnings` to the relay chain runtime upgrade checks (relay chains don't have weight restrictions).
This commit is contained in:
@@ -43,16 +43,14 @@ pub mod v1 {
|
||||
impl<T: Config> OnRuntimeUpgrade for MigrateToV1<T> {
|
||||
#[cfg(feature = "try-runtime")]
|
||||
fn pre_upgrade() -> Result<Vec<u8>, sp_runtime::TryRuntimeError> {
|
||||
let onchain = Pallet::<T>::on_chain_storage_version();
|
||||
|
||||
ensure!(onchain < 1, "this migration can be deleted");
|
||||
|
||||
log!(info, "Number of calls to refund and delete: {}", Calls::<T>::iter().count());
|
||||
|
||||
Ok(Vec::new())
|
||||
}
|
||||
|
||||
fn on_runtime_upgrade() -> Weight {
|
||||
use sp_runtime::Saturating;
|
||||
|
||||
let current = Pallet::<T>::current_storage_version();
|
||||
let onchain = Pallet::<T>::on_chain_storage_version();
|
||||
|
||||
@@ -61,20 +59,24 @@ pub mod v1 {
|
||||
return T::DbWeight::get().reads(1)
|
||||
}
|
||||
|
||||
let mut call_count = 0u64;
|
||||
Calls::<T>::drain().for_each(|(_call_hash, (_data, caller, deposit))| {
|
||||
T::Currency::unreserve(&caller, deposit);
|
||||
call_count.saturating_inc();
|
||||
});
|
||||
|
||||
current.put::<Pallet<T>>();
|
||||
|
||||
<T as frame_system::Config>::BlockWeights::get().max_block
|
||||
T::DbWeight::get().reads_writes(
|
||||
// Reads: Get Calls + Get Version
|
||||
call_count.saturating_add(1),
|
||||
// Writes: Drain Calls + Unreserves + Set version
|
||||
call_count.saturating_mul(2).saturating_add(1),
|
||||
)
|
||||
}
|
||||
|
||||
#[cfg(feature = "try-runtime")]
|
||||
fn post_upgrade(_state: Vec<u8>) -> Result<(), sp_runtime::TryRuntimeError> {
|
||||
let onchain = Pallet::<T>::on_chain_storage_version();
|
||||
ensure!(onchain < 2, "this migration needs to be removed");
|
||||
ensure!(onchain == 1, "this migration needs to be run");
|
||||
ensure!(
|
||||
Calls::<T>::iter().count() == 0,
|
||||
"there are some dangling calls that need to be destroyed and refunded"
|
||||
|
||||
Reference in New Issue
Block a user