ChainSpec trait (#5185)

* ChainSpec trait

* Apply suggestions from code review

Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>

* Added docs

* Fixed build

* Fixed build

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

substrate/client/src/client.rs

@@ -243,10 +243,10 @@ impl<B, E, Block, RA> Client<B, E, Block, RA> where
 	Block: BlockT,
 {
 	/// Creates new Substrate Client with given blockchain and code executor.
-	pub fn new<S: BuildStorage>(
+	pub fn new(
 		backend: Arc<B>,
 		executor: E,
-		build_genesis_storage: &S,
+		build_genesis_storage: &dyn BuildStorage,
 		fork_blocks: ForkBlocks<Block>,
 		bad_blocks: BadBlocks<Block>,
 		execution_extensions: ExecutionExtensions<Block>,

substrate/client/src/light/mod.rs

@@ -55,9 +55,9 @@ pub fn new_light_backend<B, S>(blockchain: Arc<Blockchain<S>>) -> Arc<Backend<S,
 }
 
 /// Create an instance of light client.
-pub fn new_light<B, S, GS, RA, E>(
+pub fn new_light<B, S, RA, E>(
 	backend: Arc<Backend<S, HashFor<B>>>,
-	genesis_storage: &GS,
+	genesis_storage: &dyn BuildStorage,
 	code_executor: E,
 	prometheus_registry: Option<Registry>,
 ) -> ClientResult<
@@ -74,7 +74,6 @@ pub fn new_light<B, S, GS, RA, E>(
 	where
 		B: BlockT,
 		S: BlockchainStorage<B> + 'static,
-		GS: BuildStorage,
 		E: CodeExecutor + RuntimeInfo + Clone + 'static,
 {
 	let local_executor = LocalCallExecutor::new(backend.clone(), code_executor);