DecodeAsEvent and DecodeAsExtrinsic; make easier to implement by removing consts

codegen/src/api/calls.rs

@@ -81,10 +81,15 @@ pub fn generate_calls(
                 #struct_def
                 #alias_mod
 
-                impl #crate_path::extrinsics::DecodeAsExtrinsic for #struct_name {
+                impl #struct_name {
                     const PALLET_NAME: &'static str = #pallet_name;
                     const CALL_NAME: &'static str = #call_name;
                 }
+                impl #crate_path::extrinsics::DecodeAsExtrinsic for #struct_name {
+                    fn is_extrinsic(pallet_name: &str, call_name: &str) -> bool {
+                        pallet_name == Self::PALLET_NAME && call_name == Self::CALL_NAME
+                    }
+                }
             };
 
             let client_fn = quote! {

codegen/src/api/events.rs

@@ -63,10 +63,15 @@ pub fn generate_events(
             #struct_def
             #alias_mod
 
-            impl #crate_path::events::DecodeAsEvent for #event_struct_name {
+            impl #event_struct_name {
                 const PALLET_NAME: &'static str = #pallet_name;
                 const EVENT_NAME: &'static str = #event_name;
             }
+            impl #crate_path::events::DecodeAsEvent for #event_struct_name {
+                fn is_event(pallet_name: &str, event_name: &str) -> bool {
+                    pallet_name == Self::PALLET_NAME && event_name == Self::EVENT_NAME
+                }
+            }
         }
     });
 

subxt/src/events/decode_as_event.rs

@@ -4,13 +4,6 @@ use scale_decode::DecodeAsFields;
 /// This adds information to the type about which event it is, which enforces that
 /// only the correct event can be decoded into it.
 pub trait DecodeAsEvent: DecodeAsFields {
-    /// Pallet name.
-    const PALLET_NAME: &'static str;
-    /// Event name.
-    const EVENT_NAME: &'static str;
-
     /// Returns true if the given pallet and event names match this event.
-    fn is_event(pallet: &str, event: &str) -> bool {
+    fn is_event(pallet: &str, event: &str) -> bool;
-        Self::PALLET_NAME == pallet && Self::EVENT_NAME == event
-    }
 }

subxt/src/extrinsics/decode_as_extrinsic.rs

@@ -4,13 +4,6 @@ use scale_decode::DecodeAsFields;
 /// This adds information to the type about which extrinsic it is, which enforces that
 /// only the correct extrinsic can be decoded into it.
 pub trait DecodeAsExtrinsic: DecodeAsFields {
-    /// Pallet name.
-    const PALLET_NAME: &'static str;
-    /// Call name.
-    const CALL_NAME: &'static str;
-
     /// Returns true if the given pallet and call names match this extrinsic.
-    fn is_extrinsic(pallet: &str, call: &str) -> bool {
+    fn is_extrinsic(pallet: &str, call: &str) -> bool;
-        Self::PALLET_NAME == pallet && Self::CALL_NAME == call
-    }
 }