Allow modules to validate transaction, second attempt (#2463)

* first impl

* rename origin::inherent to none

* fix

* fix

* Apply suggestions from code review

Co-Authored-By: thiolliere <gui.thiolliere@gmail.com>

* comment

* better error

* doc

* (add unsigned module 🤦)

* doc

* fix

* implement for node-template as well

* add validated unsigned to executor

* fix

* fix

* bump version

* testing xt

* remove extraneous logic

* licence

* impl test

substrate/core/sr-primitives/src/testing.rs

@@ -199,7 +199,10 @@ impl<'a, Xt> Deserialize<'a> for Block<Xt> where Block<Xt>: Decode {
 	}
 }
 
-/// Test transaction
+/// Test transaction, tuple of (sender, index, call)
+/// with index only used if sender is some.
+///
+/// If sender is some then the transaction is signed otherwise it is unsigned.
 #[derive(PartialEq, Eq, Clone, Encode, Decode)]
 pub struct TestXt<Call>(pub Option<u64>, pub u64, pub Call);
 
@@ -222,7 +225,7 @@ impl<Call: Codec + Sync + Send, Context> Checkable<Context> for TestXt<Call> {
 }
 impl<Call: Codec + Sync + Send> traits::Extrinsic for TestXt<Call> {
 	fn is_signed(&self) -> Option<bool> {
-		None
+		Some(self.0.is_some())
 	}
 }
 impl<Call> Applyable for TestXt<Call> where

substrate/core/sr-primitives/src/traits.rs

@@ -23,6 +23,7 @@ use runtime_io;
 #[cfg(feature = "std")] use serde::{Serialize, Deserialize, de::DeserializeOwned};
 use substrate_primitives::{self, Hasher, Blake2Hasher};
 use crate::codec::{Codec, Encode, HasCompact};
+use crate::transaction_validity::TransactionValidity;
 pub use integer_sqrt::IntegerSquareRoot;
 pub use num_traits::{
 	Zero, One, Bounded, CheckedAdd, CheckedSub, CheckedMul, CheckedDiv,
@@ -786,3 +787,17 @@ pub trait RuntimeApiInfo {
 	/// The version of the runtime api.
 	const VERSION: u32;
 }
+
+/// Something that can validate unsigned extrinsics.
+pub trait ValidateUnsigned {
+	/// The call to validate
+	type Call;
+
+	/// Return the validity of the call
+	///
+	/// This doesn't execute any side-effects; it merely checks
+	/// whether the transaction would panic if it were included or not.
+	///
+	/// Changes made to storage should be discarded by caller.
+	fn validate_unsigned(call: &Self::Call) -> TransactionValidity;
+}