Logs: add extra debug log for negative rep changes (#1205)

* refactor and more debug

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

* review

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

* fix

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

* 🤦

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

---------

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
This commit is contained in:
Andrei Sandu
2023-09-01 14:55:23 +03:00
committed by GitHub
parent 15cb0af58c
commit e165eacd58
@@ -25,6 +25,7 @@ use std::{collections::HashMap, time::Duration};
/// Default delay for sending reputation changes
pub const REPUTATION_CHANGE_INTERVAL: Duration = Duration::from_secs(30);
const LOG_TARGET: &'static str = "parachain::reputation-aggregator";
type BatchReputationChange = HashMap<PeerId, i32>;
@@ -75,6 +76,10 @@ impl ReputationAggregator {
peer_id: PeerId,
rep: UnifiedReputationChange,
) {
if rep.cost_or_benefit() < 0 {
gum::debug!(target: LOG_TARGET, peer = ?peer_id, ?rep, "Reduce reputation");
}
if (self.send_immediately_if)(rep) {
self.single_send(sender, peer_id, rep).await;
} else {
@@ -97,12 +102,8 @@ impl ReputationAggregator {
}
fn add(&mut self, peer_id: PeerId, rep: UnifiedReputationChange) {
if self.by_peer.is_none() {
self.by_peer = Some(HashMap::new());
}
if let Some(ref mut by_peer) = self.by_peer {
add_reputation(by_peer, peer_id, rep)
}
let by_peer = self.by_peer.get_or_insert(HashMap::new());
add_reputation(by_peer, peer_id, rep)
}
}