BREAKING: Rename Origin (#12258)

* BREAKING: Rename Origin

* more renaming

* a bit more renaming

* fix

* more fixing

* fix in frame_support

* even more fixes

* fix

* small fix

* ...

* update .stderr

* docs

* update docs

* update docs

* docs
This commit is contained in:
Sergej Sakac
2022-09-21 00:13:09 +02:00
committed by GitHub
parent 986d20b352
commit e4b6f4a66d
221 changed files with 5233 additions and 4200 deletions
+34 -29
View File
@@ -41,11 +41,11 @@ fn query_membership_works() {
fn submit_candidacy_must_not_work() {
new_test_ext().execute_with(|| {
assert_noop!(
ScoredPool::submit_candidacy(Origin::signed(99)),
ScoredPool::submit_candidacy(RuntimeOrigin::signed(99)),
pallet_balances::Error::<Test, _>::InsufficientBalance,
);
assert_noop!(
ScoredPool::submit_candidacy(Origin::signed(40)),
ScoredPool::submit_candidacy(RuntimeOrigin::signed(40)),
Error::<Test, _>::AlreadyInPool
);
});
@@ -58,7 +58,7 @@ fn submit_candidacy_works() {
let who = 15;
// when
assert_ok!(ScoredPool::submit_candidacy(Origin::signed(who)));
assert_ok!(ScoredPool::submit_candidacy(RuntimeOrigin::signed(who)));
assert_eq!(fetch_from_pool(15), Some((who, None)));
// then
@@ -72,11 +72,11 @@ fn scoring_works() {
// given
let who = 15;
let score = 99;
assert_ok!(ScoredPool::submit_candidacy(Origin::signed(who)));
assert_ok!(ScoredPool::submit_candidacy(RuntimeOrigin::signed(who)));
// when
let index = find_in_pool(who).expect("entity must be in pool") as u32;
assert_ok!(ScoredPool::score(Origin::signed(ScoreOrigin::get()), who, index, score));
assert_ok!(ScoredPool::score(RuntimeOrigin::signed(ScoreOrigin::get()), who, index, score));
// then
assert_eq!(fetch_from_pool(who), Some((who, Some(score))));
@@ -93,7 +93,7 @@ fn scoring_same_element_with_same_score_works() {
let score = 2;
// when
assert_ok!(ScoredPool::score(Origin::signed(ScoreOrigin::get()), who, index, score));
assert_ok!(ScoredPool::score(RuntimeOrigin::signed(ScoreOrigin::get()), who, index, score));
// then
assert_eq!(fetch_from_pool(who), Some((who, Some(score))));
@@ -109,7 +109,7 @@ fn kicking_works_only_for_authorized() {
new_test_ext().execute_with(|| {
let who = 40;
let index = find_in_pool(who).expect("entity must be in pool") as u32;
assert_noop!(ScoredPool::kick(Origin::signed(99), who, index), BadOrigin);
assert_noop!(ScoredPool::kick(RuntimeOrigin::signed(99), who, index), BadOrigin);
});
}
@@ -123,7 +123,7 @@ fn kicking_works() {
// when
let index = find_in_pool(who).expect("entity must be in pool") as u32;
assert_ok!(ScoredPool::kick(Origin::signed(KickOrigin::get()), who, index));
assert_ok!(ScoredPool::kick(RuntimeOrigin::signed(KickOrigin::get()), who, index));
// then
assert_eq!(find_in_pool(who), None);
@@ -138,14 +138,14 @@ fn unscored_entities_must_not_be_used_for_filling_members() {
new_test_ext().execute_with(|| {
// given
// we submit a candidacy, score will be `None`
assert_ok!(ScoredPool::submit_candidacy(Origin::signed(15)));
assert_ok!(ScoredPool::submit_candidacy(RuntimeOrigin::signed(15)));
// when
// we remove every scored member
ScoredPool::pool().into_iter().for_each(|(who, score)| {
if let Some(_) = score {
let index = find_in_pool(who).expect("entity must be in pool") as u32;
assert_ok!(ScoredPool::kick(Origin::signed(KickOrigin::get()), who, index));
assert_ok!(ScoredPool::kick(RuntimeOrigin::signed(KickOrigin::get()), who, index));
}
});
@@ -161,9 +161,9 @@ fn refreshing_works() {
new_test_ext().execute_with(|| {
// given
let who = 15;
assert_ok!(ScoredPool::submit_candidacy(Origin::signed(who)));
assert_ok!(ScoredPool::submit_candidacy(RuntimeOrigin::signed(who)));
let index = find_in_pool(who).expect("entity must be in pool") as u32;
assert_ok!(ScoredPool::score(Origin::signed(ScoreOrigin::get()), who, index, 99));
assert_ok!(ScoredPool::score(RuntimeOrigin::signed(ScoreOrigin::get()), who, index, 99));
// when
ScoredPool::refresh_members(ScoredPool::pool(), ChangeReceiver::MembershipChanged);
@@ -179,9 +179,9 @@ fn refreshing_happens_every_period() {
new_test_ext().execute_with(|| {
// given
System::set_block_number(1);
assert_ok!(ScoredPool::submit_candidacy(Origin::signed(15)));
assert_ok!(ScoredPool::submit_candidacy(RuntimeOrigin::signed(15)));
let index = find_in_pool(15).expect("entity must be in pool") as u32;
assert_ok!(ScoredPool::score(Origin::signed(ScoreOrigin::get()), 15, index, 99));
assert_ok!(ScoredPool::score(RuntimeOrigin::signed(ScoreOrigin::get()), 15, index, 99));
assert_eq!(ScoredPool::members(), vec![20, 40]);
// when
@@ -200,7 +200,7 @@ fn withdraw_candidacy_must_only_work_for_members() {
let who = 77;
let index = 0;
assert_noop!(
ScoredPool::withdraw_candidacy(Origin::signed(who), index),
ScoredPool::withdraw_candidacy(RuntimeOrigin::signed(who), index),
Error::<Test, _>::WrongAccountIndex
);
});
@@ -212,15 +212,15 @@ fn oob_index_should_abort() {
let who = 40;
let oob_index = ScoredPool::pool().len() as u32;
assert_noop!(
ScoredPool::withdraw_candidacy(Origin::signed(who), oob_index),
ScoredPool::withdraw_candidacy(RuntimeOrigin::signed(who), oob_index),
Error::<Test, _>::InvalidIndex
);
assert_noop!(
ScoredPool::score(Origin::signed(ScoreOrigin::get()), who, oob_index, 99),
ScoredPool::score(RuntimeOrigin::signed(ScoreOrigin::get()), who, oob_index, 99),
Error::<Test, _>::InvalidIndex
);
assert_noop!(
ScoredPool::kick(Origin::signed(KickOrigin::get()), who, oob_index),
ScoredPool::kick(RuntimeOrigin::signed(KickOrigin::get()), who, oob_index),
Error::<Test, _>::InvalidIndex
);
});
@@ -232,15 +232,15 @@ fn index_mismatches_should_abort() {
let who = 40;
let index = 3;
assert_noop!(
ScoredPool::withdraw_candidacy(Origin::signed(who), index),
ScoredPool::withdraw_candidacy(RuntimeOrigin::signed(who), index),
Error::<Test, _>::WrongAccountIndex
);
assert_noop!(
ScoredPool::score(Origin::signed(ScoreOrigin::get()), who, index, 99),
ScoredPool::score(RuntimeOrigin::signed(ScoreOrigin::get()), who, index, 99),
Error::<Test, _>::WrongAccountIndex
);
assert_noop!(
ScoredPool::kick(Origin::signed(KickOrigin::get()), who, index),
ScoredPool::kick(RuntimeOrigin::signed(KickOrigin::get()), who, index),
Error::<Test, _>::WrongAccountIndex
);
});
@@ -254,7 +254,7 @@ fn withdraw_unscored_candidacy_must_work() {
// when
let index = find_in_pool(who).expect("entity must be in pool") as u32;
assert_ok!(ScoredPool::withdraw_candidacy(Origin::signed(who), index));
assert_ok!(ScoredPool::withdraw_candidacy(RuntimeOrigin::signed(who), index));
// then
assert_eq!(fetch_from_pool(5), None);
@@ -270,7 +270,7 @@ fn withdraw_scored_candidacy_must_work() {
// when
let index = find_in_pool(who).expect("entity must be in pool") as u32;
assert_ok!(ScoredPool::withdraw_candidacy(Origin::signed(who), index));
assert_ok!(ScoredPool::withdraw_candidacy(RuntimeOrigin::signed(who), index));
// then
assert_eq!(fetch_from_pool(who), None);
@@ -286,12 +286,12 @@ fn candidacy_resubmitting_works() {
let who = 15;
// when
assert_ok!(ScoredPool::submit_candidacy(Origin::signed(who)));
assert_ok!(ScoredPool::submit_candidacy(RuntimeOrigin::signed(who)));
assert_eq!(ScoredPool::candidate_exists(who), true);
let index = find_in_pool(who).expect("entity must be in pool") as u32;
assert_ok!(ScoredPool::withdraw_candidacy(Origin::signed(who), index));
assert_ok!(ScoredPool::withdraw_candidacy(RuntimeOrigin::signed(who), index));
assert_eq!(ScoredPool::candidate_exists(who), false);
assert_ok!(ScoredPool::submit_candidacy(Origin::signed(who)));
assert_ok!(ScoredPool::submit_candidacy(RuntimeOrigin::signed(who)));
// then
assert_eq!(ScoredPool::candidate_exists(who), true);
@@ -303,13 +303,18 @@ fn pool_candidates_exceeded() {
new_test_ext().execute_with(|| {
for i in [1, 2, 3, 4, 6] {
let who = i as u64;
assert_ok!(ScoredPool::submit_candidacy(Origin::signed(who)));
assert_ok!(ScoredPool::submit_candidacy(RuntimeOrigin::signed(who)));
let index = find_in_pool(who).expect("entity must be in pool") as u32;
assert_ok!(ScoredPool::score(Origin::signed(ScoreOrigin::get()), who, index, 99));
assert_ok!(ScoredPool::score(
RuntimeOrigin::signed(ScoreOrigin::get()),
who,
index,
99
));
}
assert_noop!(
ScoredPool::submit_candidacy(Origin::signed(8)),
ScoredPool::submit_candidacy(RuntimeOrigin::signed(8)),
Error::<Test, _>::TooManyMembers
);
});