From e57e54ab9c3a72377e2c015c4c8a73450ce90255 Mon Sep 17 00:00:00 2001
From: Pierre Krieger <pierre.krieger1708@gmail.com>
Date: Tue, 9 Apr 2019 05:30:43 -0300
Subject: [PATCH] Add warning when using default protocol ID (#2234)

* Add warning when using default protocol ID

* Update core/service/src/lib.rs
---
 substrate/core/service/src/lib.rs | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/substrate/core/service/src/lib.rs b/substrate/core/service/src/lib.rs
index 105bab8ca0..ec94053f85 100644
--- a/substrate/core/service/src/lib.rs
+++ b/substrate/core/service/src/lib.rs
@@ -154,7 +154,15 @@ impl<Components: components::Components> Service<Components> {
 		};
 
 		let protocol_id = {
-			let protocol_id_full = config.chain_spec.protocol_id().unwrap_or(DEFAULT_PROTOCOL_ID).as_bytes();
+			let protocol_id_full = match config.chain_spec.protocol_id() {
+				Some(pid) => pid,
+				None => {
+					warn!("Using default protocol ID {:?} because none is configured in the \
+						chain specs", DEFAULT_PROTOCOL_ID
+					);
+					DEFAULT_PROTOCOL_ID	
+				}
+			}.as_bytes();
 			let mut protocol_id = network::ProtocolId::default();
 			if protocol_id_full.len() > protocol_id.len() {
 				warn!("Protocol ID truncated to {} chars", protocol_id.len());