From e6e3bda3f0f6d343866316b9e1b7a25bbfb86edf Mon Sep 17 00:00:00 2001 From: Pierre Krieger Date: Thu, 17 Dec 2020 15:38:56 +0100 Subject: [PATCH] Improve Jaeger errors and debugging experience (#2127) * Improve Jaeger errors and debugging experience * Bind on 0.0.0.0:0 instead --- polkadot/node/subsystem/src/errors.rs | 6 ------ polkadot/node/subsystem/src/jaeger.rs | 12 ++++-------- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/polkadot/node/subsystem/src/errors.rs b/polkadot/node/subsystem/src/errors.rs index 69ddd86108..243577c353 100644 --- a/polkadot/node/subsystem/src/errors.rs +++ b/polkadot/node/subsystem/src/errors.rs @@ -70,10 +70,4 @@ pub enum JaegerError { #[error("Missing jaeger configuration")] MissingConfiguration, - - #[error("Failed to allocate port for UDP transfer to jaeger agent")] - PortAllocationError(#[source] std::io::Error), - - #[error("Failed to send jaeger span to agent")] - SendError(#[source] std::io::Error), } diff --git a/polkadot/node/subsystem/src/jaeger.rs b/polkadot/node/subsystem/src/jaeger.rs index 56ba883354..849e59474d 100644 --- a/polkadot/node/subsystem/src/jaeger.rs +++ b/polkadot/node/subsystem/src/jaeger.rs @@ -210,20 +210,16 @@ impl Jaeger { // Spawn a background task that pulls span information and sends them on the network. spawner.spawn("jaeger-collector", Box::pin(async move { - let res = async_std::net::UdpSocket::bind("127.0.0.1:0").await - .map_err(JaegerError::PortAllocationError); - match res { + match async_std::net::UdpSocket::bind("0.0.0.0:0").await { Ok(udp_socket) => loop { let buf = traces_out.next().await; // UDP sending errors happen only either if the API is misused or in case of missing privilege. - if let Err(e) = udp_socket.send_to(&buf, jaeger_agent).await - .map_err(|e| JaegerError::SendError(e)) - { - log::trace!("Jaeger: {:?}", e); + if let Err(e) = udp_socket.send_to(&buf, jaeger_agent).await { + log::debug!(target: "jaeger", "UDP send error: {}", e); } } Err(e) => { - log::warn!("Jaeger: {:?}", e); + log::warn!(target: "jaeger", "UDP socket open error: {}", e); } } }));