pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-05-31 09:51:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rework the event system of sc-network (#1370)

Browse Source 
This commit introduces a new concept called `NotificationService` which
allows Polkadot protocols to communicate with the underlying
notification protocol implementation directly, without routing events
through `NetworkWorker`. This implies that each protocol has its own
service which it uses to communicate with remote peers and that each
`NotificationService` is unique with respect to the underlying
notification protocol, meaning `NotificationService` for the transaction
protocol can only be used to send and receive transaction-related
notifications.

The `NotificationService` concept introduces two additional benefits:
  * allow protocols to start using custom handshakes
  * allow protocols to accept/reject inbound peers

Previously the validation of inbound connections was solely the
responsibility of `ProtocolController`. This caused issues with light
peers and `SyncingEngine` as `ProtocolController` would accept more
peers than `SyncingEngine` could accept which caused peers to have
differing views of their own states. `SyncingEngine` would reject excess
peers but these rejections were not properly communicated to those peers
causing them to assume that they were accepted.

With `NotificationService`, the local handshake is not sent to remote
peer if peer is rejected which allows it to detect that it was rejected.

This commit also deprecates the use of `NetworkEventStream` for all
notification-related events and going forward only DHT events are
provided through `NetworkEventStream`. If protocols wish to follow each
other's events, they must introduce additional abtractions, as is done
for GRANDPA and transactions protocols by following the syncing protocol
through `SyncEventStream`.

Fixes https://github.com/paritytech/polkadot-sdk/issues/512
Fixes https://github.com/paritytech/polkadot-sdk/issues/514
Fixes https://github.com/paritytech/polkadot-sdk/issues/515
Fixes https://github.com/paritytech/polkadot-sdk/issues/554
Fixes https://github.com/paritytech/polkadot-sdk/issues/556

---
These changes are transferred from
https://github.com/paritytech/substrate/pull/14197 but there are no
functional changes compared to that PR

---------

Co-authored-by: Dmitry Markin <dmitry@markin.tech>
Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
This commit is contained in:
Aaro Altonen
2023-11-28 20:18:52 +02:00
committed by GitHub
parent ec3a61ed86
commit e71c484d5b
102 changed files with 5694 additions and 2603 deletions
Download Patch File Download Diff File Expand all files Collapse all files
substrate/frame/contracts/fixtures/data/caller_contract.wat
+33 -33
View File
@@ -10,7 +10,7 @@
(func $assert (param i32)
(block $ok
(br_if $ok
(get_local 0)
(local.get 0)
)
(unreachable)
)
@@ -37,10 +37,10 @@
)
;; Read current balance into local variable.
(set_local $sp (i32.const 1024))
(local.set $sp (i32.const 1024))
;; Fail to deploy the contract since it returns a non-zero exit status.
(set_local $exit_code
(local.set $exit_code
(call $seal_instantiate
(i32.const 24) ;; Pointer to the code hash.
(i64.const 0) ;; How much ref_time weight to devote for the execution. 0 = all.
@@ -60,11 +60,11 @@
;; Check non-zero exit status.
(call $assert
(i32.eq (get_local $exit_code) (i32.const 2)) ;; ReturnCode::CalleeReverted
(i32.eq (local.get $exit_code) (i32.const 2)) ;; ReturnCode::CalleeReverted
)
;; Fail to deploy the contract due to insufficient ref_time weight.
(set_local $exit_code
(local.set $exit_code
(call $seal_instantiate
(i32.const 24) ;; Pointer to the code hash.
(i64.const 1) ;; Supply too little ref_time weight
@@ -85,11 +85,11 @@
;; Check for special trap exit status.
(call $assert
(i32.eq (get_local $exit_code) (i32.const 1)) ;; ReturnCode::CalleeTrapped
(i32.eq (local.get $exit_code) (i32.const 1)) ;; ReturnCode::CalleeTrapped
)
;; Fail to deploy the contract due to insufficient ref_time weight.
(set_local $exit_code
(local.set $exit_code
(call $seal_instantiate
(i32.const 24) ;; Pointer to the code hash.
(i64.const 0) ;; How much ref_time weight to devote for the execution. 0 = all.
@@ -110,17 +110,17 @@
;; Check for special trap exit status.
(call $assert
(i32.eq (get_local $exit_code) (i32.const 1)) ;; ReturnCode::CalleeTrapped
(i32.eq (local.get $exit_code) (i32.const 1)) ;; ReturnCode::CalleeTrapped
)
;; Length of the output buffer
(i32.store
(i32.sub (get_local $sp) (i32.const 4))
(i32.sub (local.get $sp) (i32.const 4))
(i32.const 256)
)
;; Deploy the contract successfully.
(set_local $exit_code
(local.set $exit_code
(call $seal_instantiate
(i32.const 24) ;; Pointer to the code hash.
(i64.const 0) ;; How much ref_time weight to devote for the execution. 0 = all.
@@ -130,7 +130,7 @@
(i32.const 8) ;; Pointer to input data buffer address
(i32.const 8) ;; Length of input data buffer
(i32.const 16) ;; Pointer to the address output buffer
(i32.sub (get_local $sp) (i32.const 4)) ;; Pointer to the address buffer length
(i32.sub (local.get $sp) (i32.const 4)) ;; Pointer to the address buffer length
(i32.const 4294967295) ;; u32 max sentinel value: do not copy output
(i32.const 0) ;; Length is ignored in this case
(i32.const 0) ;; salt_ptr
@@ -141,28 +141,28 @@
;; Check for success exit status.
(call $assert
(i32.eq (get_local $exit_code) (i32.const 0)) ;; ReturnCode::Success
(i32.eq (local.get $exit_code) (i32.const 0)) ;; ReturnCode::Success
)
;; Check that address has the expected length
(call $assert
(i32.eq (i32.load (i32.sub (get_local $sp) (i32.const 4))) (i32.const 32))
(i32.eq (i32.load (i32.sub (local.get $sp) (i32.const 4))) (i32.const 32))
)
;; Zero out destination buffer of output
(i32.store
(i32.sub (get_local $sp) (i32.const 4))
(i32.sub (local.get $sp) (i32.const 4))
(i32.const 0)
)
;; Length of the output buffer
(i32.store
(i32.sub (get_local $sp) (i32.const 8))
(i32.sub (local.get $sp) (i32.const 8))
(i32.const 4)
)
;; Call the new contract and expect it to return failing exit code.
(set_local $exit_code
(local.set $exit_code
(call $seal_call
(i32.const 0) ;; Set no flag
(i32.const 16) ;; Pointer to "callee" address.
@@ -172,29 +172,29 @@
(i32.const 0) ;; Pointer to the buffer with value to transfer
(i32.const 9) ;; Pointer to input data buffer address
(i32.const 7) ;; Length of input data buffer
(i32.sub (get_local $sp) (i32.const 4)) ;; Ptr to output buffer
(i32.sub (get_local $sp) (i32.const 8)) ;; Ptr to output buffer len
(i32.sub (local.get $sp) (i32.const 4)) ;; Ptr to output buffer
(i32.sub (local.get $sp) (i32.const 8)) ;; Ptr to output buffer len
)
)
;; Check non-zero exit status.
(call $assert
(i32.eq (get_local $exit_code) (i32.const 2)) ;; ReturnCode::CalleeReverted
(i32.eq (local.get $exit_code) (i32.const 2)) ;; ReturnCode::CalleeReverted
)
;; Check that output buffer contains the expected return data.
(call $assert
(i32.eq (i32.load (i32.sub (get_local $sp) (i32.const 8))) (i32.const 3))
(i32.eq (i32.load (i32.sub (local.get $sp) (i32.const 8))) (i32.const 3))
)
(call $assert
(i32.eq
(i32.load (i32.sub (get_local $sp) (i32.const 4)))
(i32.load (i32.sub (local.get $sp) (i32.const 4)))
(i32.const 0x00776655)
)
)
;; Fail to call the contract due to insufficient ref_time weight.
(set_local $exit_code
(local.set $exit_code
(call $seal_call
(i32.const 0) ;; Set no flag
(i32.const 16) ;; Pointer to "callee" address.
@@ -211,11 +211,11 @@
;; Check for special trap exit status.
(call $assert
(i32.eq (get_local $exit_code) (i32.const 1)) ;; ReturnCode::CalleeTrapped
(i32.eq (local.get $exit_code) (i32.const 1)) ;; ReturnCode::CalleeTrapped
)
;; Fail to call the contract due to insufficient proof_size weight.
(set_local $exit_code
(local.set $exit_code
(call $seal_call
(i32.const 0) ;; Set no flag
(i32.const 16) ;; Pointer to "callee" address.
@@ -232,23 +232,23 @@
;; Check for special trap exit status.
(call $assert
(i32.eq (get_local $exit_code) (i32.const 1)) ;; ReturnCode::CalleeTrapped
(i32.eq (local.get $exit_code) (i32.const 1)) ;; ReturnCode::CalleeTrapped
)
;; Zero out destination buffer of output
(i32.store
(i32.sub (get_local $sp) (i32.const 4))
(i32.sub (local.get $sp) (i32.const 4))
(i32.const 0)
)
;; Length of the output buffer
(i32.store
(i32.sub (get_local $sp) (i32.const 8))
(i32.sub (local.get $sp) (i32.const 8))
(i32.const 4)
)
;; Call the contract successfully.
(set_local $exit_code
(local.set $exit_code
(call $seal_call
(i32.const 0) ;; Set no flag
(i32.const 16) ;; Pointer to "callee" address.
@@ -258,23 +258,23 @@
(i32.const 0) ;; Pointer to the buffer with value to transfer
(i32.const 8) ;; Pointer to input data buffer address
(i32.const 8) ;; Length of input data buffer
(i32.sub (get_local $sp) (i32.const 4)) ;; Ptr to output buffer
(i32.sub (get_local $sp) (i32.const 8)) ;; Ptr to output buffer len
(i32.sub (local.get $sp) (i32.const 4)) ;; Ptr to output buffer
(i32.sub (local.get $sp) (i32.const 8)) ;; Ptr to output buffer len
)
)
;; Check for success exit status.
(call $assert
(i32.eq (get_local $exit_code) (i32.const 0)) ;; ReturnCode::Success
(i32.eq (local.get $exit_code) (i32.const 0)) ;; ReturnCode::Success
)
;; Check that the output buffer contains the expected return data.
(call $assert
(i32.eq (i32.load (i32.sub (get_local $sp) (i32.const 8))) (i32.const 4))
(i32.eq (i32.load (i32.sub (local.get $sp) (i32.const 8))) (i32.const 4))
)
(call $assert
(i32.eq
(i32.load (i32.sub (get_local $sp) (i32.const 4)))
(i32.load (i32.sub (local.get $sp) (i32.const 4)))
(i32.const 0x77665544)
)
)