pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-06-13 07:01:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rework the event system of sc-network (#1370)

Browse Source 
This commit introduces a new concept called `NotificationService` which
allows Polkadot protocols to communicate with the underlying
notification protocol implementation directly, without routing events
through `NetworkWorker`. This implies that each protocol has its own
service which it uses to communicate with remote peers and that each
`NotificationService` is unique with respect to the underlying
notification protocol, meaning `NotificationService` for the transaction
protocol can only be used to send and receive transaction-related
notifications.

The `NotificationService` concept introduces two additional benefits:
  * allow protocols to start using custom handshakes
  * allow protocols to accept/reject inbound peers

Previously the validation of inbound connections was solely the
responsibility of `ProtocolController`. This caused issues with light
peers and `SyncingEngine` as `ProtocolController` would accept more
peers than `SyncingEngine` could accept which caused peers to have
differing views of their own states. `SyncingEngine` would reject excess
peers but these rejections were not properly communicated to those peers
causing them to assume that they were accepted.

With `NotificationService`, the local handshake is not sent to remote
peer if peer is rejected which allows it to detect that it was rejected.

This commit also deprecates the use of `NetworkEventStream` for all
notification-related events and going forward only DHT events are
provided through `NetworkEventStream`. If protocols wish to follow each
other's events, they must introduce additional abtractions, as is done
for GRANDPA and transactions protocols by following the syncing protocol
through `SyncEventStream`.

Fixes https://github.com/paritytech/polkadot-sdk/issues/512
Fixes https://github.com/paritytech/polkadot-sdk/issues/514
Fixes https://github.com/paritytech/polkadot-sdk/issues/515
Fixes https://github.com/paritytech/polkadot-sdk/issues/554
Fixes https://github.com/paritytech/polkadot-sdk/issues/556

---
These changes are transferred from
https://github.com/paritytech/substrate/pull/14197 but there are no
functional changes compared to that PR

---------

Co-authored-by: Dmitry Markin <dmitry@markin.tech>
Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
This commit is contained in:
Aaro Altonen
2023-11-28 20:18:52 +02:00
committed by GitHub
parent ec3a61ed86
commit e71c484d5b
102 changed files with 5694 additions and 2603 deletions
Download Patch File Download Diff File Expand all files Collapse all files
substrate/frame/contracts/src/wasm/mod.rs
+27 -27
View File
@@ -1506,7 +1506,7 @@ mod tests {
(func $assert (param i32)
(block $ok
(br_if $ok
(get_local 0)
(local.get 0)
)
(unreachable)
)
@@ -1531,7 +1531,7 @@ mod tests {
)
;; Find out the size of the buffer
(set_local $buf_size
(local.set $buf_size
(i32.load (i32.const 32))
)
@@ -1539,7 +1539,7 @@ mod tests {
(call $seal_return
(i32.const 0)
(i32.const 36)
(get_local $buf_size)
(local.get $buf_size)
)
;; env:seal_return doesn't return, so this is effectively unreachable.
@@ -1575,7 +1575,7 @@ mod tests {
(func $assert (param i32)
(block $ok
(br_if $ok
(get_local 0)
(local.get 0)
)
(unreachable)
)
@@ -1633,7 +1633,7 @@ mod tests {
(func $assert (param i32)
(block $ok
(br_if $ok
(get_local 0)
(local.get 0)
)
(unreachable)
)
@@ -1680,7 +1680,7 @@ mod tests {
(func $assert (param i32)
(block $ok
(br_if $ok
(get_local 0)
(local.get 0)
)
(unreachable)
)
@@ -1726,7 +1726,7 @@ mod tests {
(func $assert (param i32)
(block $ok
(br_if $ok
(get_local 0)
(local.get 0)
)
(unreachable)
)
@@ -1773,7 +1773,7 @@ mod tests {
(func $assert (param i32)
(block $ok
(br_if $ok
(get_local 0)
(local.get 0)
)
(unreachable)
)
@@ -1836,7 +1836,7 @@ mod tests {
(func $assert (param i32)
(block $ok
(br_if $ok
(get_local 0)
(local.get 0)
)
(unreachable)
)
@@ -1925,7 +1925,7 @@ mod tests {
(func $assert (param i32)
(block $ok
(br_if $ok
(get_local 0)
(local.get 0)
)
(unreachable)
)
@@ -1966,7 +1966,7 @@ mod tests {
(func $assert (param i32)
(block $ok
(br_if $ok
(get_local 0)
(local.get 0)
)
(unreachable)
)
@@ -2013,7 +2013,7 @@ mod tests {
(func $assert (param i32)
(block $ok
(br_if $ok
(get_local 0)
(local.get 0)
)
(unreachable)
)
@@ -2067,7 +2067,7 @@ mod tests {
(func $assert (param i32)
(block $ok
(br_if $ok
(get_local 0)
(local.get 0)
)
(unreachable)
)
@@ -2137,7 +2137,7 @@ mod tests {
(func $assert (param i32)
(block $ok
(br_if $ok
(get_local 0)
(local.get 0)
)
(unreachable)
)
@@ -2327,7 +2327,7 @@ mod tests {
(func $assert (param i32)
(block $ok
(br_if $ok
(get_local 0)
(local.get 0)
)
(unreachable)
)
@@ -2995,7 +2995,7 @@ mod tests {
(func $assert (param i32)
(block $ok
(br_if $ok
(get_local 0)
(local.get 0)
)
(unreachable)
)
@@ -3047,7 +3047,7 @@ mod tests {
(func $assert (param i32)
(block $ok
(br_if $ok
(get_local 0)
(local.get 0)
)
(unreachable)
)
@@ -3162,18 +3162,18 @@ mod tests {
(func $assert (param i32)
(block $ok
(br_if $ok
(get_local 0)
(local.get 0)
)
(unreachable)
)
)
(func (export "call")
(local $exit_code i32)
(set_local $exit_code
(local.set $exit_code
(call $seal_set_code_hash (i32.const 0))
)
(call $assert
(i32.eq (get_local $exit_code) (i32.const 0)) ;; ReturnCode::Success
(i32.eq (local.get $exit_code) (i32.const 0)) ;; ReturnCode::Success
)
)
@@ -3202,18 +3202,18 @@ mod tests {
(func $assert (param i32)
(block $ok
(br_if $ok
(get_local 0)
(local.get 0)
)
(unreachable)
)
)
(func (export "call")
(local $return_val i32)
(set_local $return_val
(local.set $return_val
(call $reentrance_count)
)
(call $assert
(i32.eq (get_local $return_val) (i32.const 12))
(i32.eq (local.get $return_val) (i32.const 12))
)
)
@@ -3234,18 +3234,18 @@ mod tests {
(func $assert (param i32)
(block $ok
(br_if $ok
(get_local 0)
(local.get 0)
)
(unreachable)
)
)
(func (export "call")
(local $return_val i32)
(set_local $return_val
(local.set $return_val
(call $account_reentrance_count (i32.const 0))
)
(call $assert
(i32.eq (get_local $return_val) (i32.const 12))
(i32.eq (local.get $return_val) (i32.const 12))
)
)
@@ -3267,7 +3267,7 @@ mod tests {
(func $assert (param i32)
(block $ok
(br_if $ok
(get_local 0)
(local.get 0)
)
(unreachable)
)