pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-07-24 18:15:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Better timeout values now that we are going to be connected to all nodes. (#2778)

Browse Source 
* Better timeout values.

* Fix typo.

* Fix validator bandwidth.

* Fix compilation.
This commit is contained in:
Robert Klotzner
2021-03-31 22:34:12 +02:00
committed by GitHub
parent c56f9e0514
commit eb6786ad05
1 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
polkadot/node/network/protocol/src/request_response/mod.rs
+14 -4
View File
@@ -71,12 +71,21 @@ pub enum Protocol {
/// When decreasing this value, take into account that the very first request might need to open a /// When decreasing this value, take into account that the very first request might need to open a
/// connection, which can be slow. If this causes problems, we should ensure connectivity via peer /// connection, which can be slow. If this causes problems, we should ensure connectivity via peer
/// sets. /// sets.
#[allow(dead_code)]
const DEFAULT_REQUEST_TIMEOUT: Duration = Duration::from_secs(3); const DEFAULT_REQUEST_TIMEOUT: Duration = Duration::from_secs(3);
/// Request timeout where we can assume the connection is already open (e.g. we have peers in a /// Request timeout where we can assume the connection is already open (e.g. we have peers in a
/// peer set as well). /// peer set as well).
const DEFAULT_REQUEST_TIMEOUT_CONNECTED: Duration = Duration::from_secs(1); const DEFAULT_REQUEST_TIMEOUT_CONNECTED: Duration = Duration::from_secs(1);
/// Minimum bandwidth we expect for validators - 500Mbit/s is the recommendation, so approximately
/// 50Meg bytes per second:
const MIN_BANDWIDTH_BYTES: u64 = 50 * 1024 * 1024;
/// Timeout for PoV like data, 2 times what it should take, assuming we can fully utilize the
/// bandwidth. This amounts to two seconds right now.
const POV_REQUEST_TIMEOUT_CONNECTED: Duration =
Duration::from_millis(2 * 1000 * (MAX_COMPRESSED_POV_SIZE as u64) / MIN_BANDWIDTH_BYTES);
impl Protocol { impl Protocol {
/// Get a configuration for a given Request response protocol. /// Get a configuration for a given Request response protocol.
/// ///
@@ -98,7 +107,8 @@ impl Protocol {
name: p_name, name: p_name,
max_request_size: 10_000, max_request_size: 10_000,
max_response_size: 10_000_000, max_response_size: 10_000_000,
request_timeout: DEFAULT_REQUEST_TIMEOUT, // We are connected to all validators:
request_timeout: DEFAULT_REQUEST_TIMEOUT_CONNECTED,
inbound_queue: Some(tx), inbound_queue: Some(tx),
}, },
Protocol::CollationFetching => RequestResponseConfig { Protocol::CollationFetching => RequestResponseConfig {
@@ -106,14 +116,14 @@ impl Protocol {
max_request_size: 10_000, max_request_size: 10_000,
max_response_size: MAX_COMPRESSED_POV_SIZE as u64, max_response_size: MAX_COMPRESSED_POV_SIZE as u64,
// Taken from initial implementation in collator protocol: // Taken from initial implementation in collator protocol:
request_timeout: DEFAULT_REQUEST_TIMEOUT_CONNECTED, request_timeout: POV_REQUEST_TIMEOUT_CONNECTED,
inbound_queue: Some(tx), inbound_queue: Some(tx),
}, },
Protocol::PoVFetching => RequestResponseConfig { Protocol::PoVFetching => RequestResponseConfig {
name: p_name, name: p_name,
max_request_size: 1_000, max_request_size: 1_000,
max_response_size: MAX_COMPRESSED_POV_SIZE as u64, max_response_size: MAX_COMPRESSED_POV_SIZE as u64,
request_timeout: DEFAULT_REQUEST_TIMEOUT_CONNECTED, request_timeout: POV_REQUEST_TIMEOUT_CONNECTED,
inbound_queue: Some(tx), inbound_queue: Some(tx),
}, },
Protocol::AvailableDataFetching => RequestResponseConfig { Protocol::AvailableDataFetching => RequestResponseConfig {
@@ -121,7 +131,7 @@ impl Protocol {
max_request_size: 1_000, max_request_size: 1_000,
// Available data size is dominated by the PoV size. // Available data size is dominated by the PoV size.
max_response_size: MAX_COMPRESSED_POV_SIZE as u64, max_response_size: MAX_COMPRESSED_POV_SIZE as u64,
request_timeout: DEFAULT_REQUEST_TIMEOUT, request_timeout: POV_REQUEST_TIMEOUT_CONNECTED,
inbound_queue: Some(tx), inbound_queue: Some(tx),
}, },
}; };