Fixes PoV over-estimation (#13766)

* Align log

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Use max instead of sum

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Make comment ordering deterministic

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Dont add Pov overhead when all is ignored

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update test pallet weights

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Re-run weights on bm2

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix test

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Actually use new weights

Fucked up the merge for this file...

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update contract weights

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
This commit is contained in:
Oliver Tale-Yazdi
2023-04-13 15:11:58 +02:00
committed by GitHub
parent 46e2d3e5f8
commit ebfe00d590
54 changed files with 5526 additions and 5534 deletions
+102 -105
View File
@@ -18,9 +18,9 @@
//! Autogenerated weights for pallet_election_provider_multi_phase
//!
//! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 4.0.0-dev
//! DATE: 2023-03-16, STEPS: `50`, REPEAT: `20`, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! DATE: 2023-04-06, STEPS: `50`, REPEAT: `20`, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! WORST CASE MAP SIZE: `1000000`
//! HOSTNAME: `bm3`, CPU: `Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz`
//! HOSTNAME: `bm2`, CPU: `Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz`
//! EXECUTION: Some(Wasm), WASM-EXECUTION: Compiled, CHAIN: Some("dev"), DB CACHE: 1024
// Executed Command:
@@ -31,9 +31,6 @@
// --steps=50
// --repeat=20
// --pallet=pallet_election_provider_multi_phase
// --no-storage-info
// --no-median-slopes
// --no-min-squares
// --extrinsic=*
// --execution=wasm
// --wasm-execution=compiled
@@ -85,9 +82,9 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
fn on_initialize_nothing() -> Weight {
// Proof Size summary in bytes:
// Measured: `994`
// Estimated: `14903`
// Minimum execution time: 21_538_000 picoseconds.
Weight::from_parts(22_045_000, 14903)
// Estimated: `3481`
// Minimum execution time: 21_239_000 picoseconds.
Weight::from_parts(21_970_000, 3481)
.saturating_add(T::DbWeight::get().reads(8_u64))
}
/// Storage: ElectionProviderMultiPhase Round (r:1 w:0)
@@ -97,9 +94,9 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
fn on_initialize_open_signed() -> Weight {
// Proof Size summary in bytes:
// Measured: `114`
// Estimated: `3198`
// Minimum execution time: 12_696_000 picoseconds.
Weight::from_parts(12_950_000, 3198)
// Estimated: `1599`
// Minimum execution time: 13_913_000 picoseconds.
Weight::from_parts(14_329_000, 1599)
.saturating_add(T::DbWeight::get().reads(2_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
@@ -110,9 +107,9 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
fn on_initialize_open_unsigned() -> Weight {
// Proof Size summary in bytes:
// Measured: `114`
// Estimated: `3198`
// Minimum execution time: 14_029_000 picoseconds.
Weight::from_parts(14_288_000, 3198)
// Estimated: `1599`
// Minimum execution time: 15_377_000 picoseconds.
Weight::from_parts(15_714_000, 1599)
.saturating_add(T::DbWeight::get().reads(2_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
@@ -123,9 +120,9 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
fn finalize_signed_phase_accept_solution() -> Weight {
// Proof Size summary in bytes:
// Measured: `174`
// Estimated: `3767`
// Minimum execution time: 26_468_000 picoseconds.
Weight::from_parts(26_790_000, 3767)
// Estimated: `3593`
// Minimum execution time: 32_899_000 picoseconds.
Weight::from_parts(33_455_000, 3593)
.saturating_add(T::DbWeight::get().reads(1_u64))
.saturating_add(T::DbWeight::get().writes(2_u64))
}
@@ -135,8 +132,8 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
// Proof Size summary in bytes:
// Measured: `174`
// Estimated: `3593`
// Minimum execution time: 18_401_000 picoseconds.
Weight::from_parts(18_686_000, 3593)
// Minimum execution time: 22_532_000 picoseconds.
Weight::from_parts(23_039_000, 3593)
.saturating_add(T::DbWeight::get().reads(1_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
@@ -152,10 +149,10 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
// Proof Size summary in bytes:
// Measured: `0`
// Estimated: `0`
// Minimum execution time: 266_901_000 picoseconds.
Weight::from_parts(270_251_000, 0)
// Standard Error: 1_758
.saturating_add(Weight::from_parts(167_310, 0).saturating_mul(v.into()))
// Minimum execution time: 253_511_000 picoseconds.
Weight::from_parts(261_190_000, 0)
// Standard Error: 1_621
.saturating_add(Weight::from_parts(157_608, 0).saturating_mul(v.into()))
.saturating_add(T::DbWeight::get().writes(3_u64))
}
/// Storage: ElectionProviderMultiPhase SignedSubmissionIndices (r:1 w:1)
@@ -181,17 +178,17 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
fn elect_queued(a: u32, d: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `337 + a * (768 ±0) + d * (48 ±0)`
// Estimated: `16191 + a * (6912 ±0) + d * (441 ±0)`
// Minimum execution time: 286_523_000 picoseconds.
Weight::from_parts(19_101_753, 16191)
// Standard Error: 4_194
.saturating_add(Weight::from_parts(398_102, 0).saturating_mul(a.into()))
// Standard Error: 6_287
.saturating_add(Weight::from_parts(188_928, 0).saturating_mul(d.into()))
// Estimated: `3889 + a * (768 ±0) + d * (49 ±0)`
// Minimum execution time: 284_994_000 picoseconds.
Weight::from_parts(97_696_734, 3889)
// Standard Error: 4_172
.saturating_add(Weight::from_parts(331_569, 0).saturating_mul(a.into()))
// Standard Error: 6_254
.saturating_add(Weight::from_parts(92_198, 0).saturating_mul(d.into()))
.saturating_add(T::DbWeight::get().reads(7_u64))
.saturating_add(T::DbWeight::get().writes(8_u64))
.saturating_add(Weight::from_parts(0, 6912).saturating_mul(a.into()))
.saturating_add(Weight::from_parts(0, 441).saturating_mul(d.into()))
.saturating_add(Weight::from_parts(0, 768).saturating_mul(a.into()))
.saturating_add(Weight::from_parts(0, 49).saturating_mul(d.into()))
}
/// Storage: ElectionProviderMultiPhase CurrentPhase (r:1 w:0)
/// Proof Skipped: ElectionProviderMultiPhase CurrentPhase (max_values: Some(1), max_size: None, mode: Measured)
@@ -208,9 +205,9 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
fn submit() -> Weight {
// Proof Size summary in bytes:
// Measured: `893`
// Estimated: `11906`
// Minimum execution time: 47_876_000 picoseconds.
Weight::from_parts(48_464_000, 11906)
// Estimated: `2378`
// Minimum execution time: 52_194_000 picoseconds.
Weight::from_parts(53_062_000, 2378)
.saturating_add(T::DbWeight::get().reads(5_u64))
.saturating_add(T::DbWeight::get().writes(3_u64))
}
@@ -234,18 +231,18 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
/// The range of component `d` is `[200, 400]`.
fn submit_unsigned(v: u32, t: u32, a: u32, _d: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `219 + v * (553 ±0) + t * (32 ±0)`
// Estimated: `11928 + v * (3871 ±0) + t * (224 ±0)`
// Minimum execution time: 4_702_825_000 picoseconds.
Weight::from_parts(4_752_015_000, 11928)
// Standard Error: 14_906
.saturating_add(Weight::from_parts(131_585, 0).saturating_mul(v.into()))
// Standard Error: 44_174
.saturating_add(Weight::from_parts(4_167_676, 0).saturating_mul(a.into()))
// Measured: `219 + t * (32 ±0) + v * (553 ±0)`
// Estimated: `1704 + t * (32 ±0) + v * (553 ±0)`
// Minimum execution time: 4_843_067_000 picoseconds.
Weight::from_parts(4_860_833_000, 1704)
// Standard Error: 14_594
.saturating_add(Weight::from_parts(76_611, 0).saturating_mul(v.into()))
// Standard Error: 43_249
.saturating_add(Weight::from_parts(4_347_887, 0).saturating_mul(a.into()))
.saturating_add(T::DbWeight::get().reads(7_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
.saturating_add(Weight::from_parts(0, 3871).saturating_mul(v.into()))
.saturating_add(Weight::from_parts(0, 224).saturating_mul(t.into()))
.saturating_add(Weight::from_parts(0, 32).saturating_mul(t.into()))
.saturating_add(Weight::from_parts(0, 553).saturating_mul(v.into()))
}
/// Storage: ElectionProviderMultiPhase DesiredTargets (r:1 w:0)
/// Proof Skipped: ElectionProviderMultiPhase DesiredTargets (max_values: Some(1), max_size: None, mode: Measured)
@@ -261,17 +258,17 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
/// The range of component `d` is `[200, 400]`.
fn feasibility_check(v: u32, t: u32, a: u32, _d: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `194 + v * (553 ±0) + t * (32 ±0)`
// Estimated: `6716 + v * (2212 ±0) + t * (128 ±0)`
// Minimum execution time: 4_069_075_000 picoseconds.
Weight::from_parts(4_105_635_000, 6716)
// Standard Error: 12_539
.saturating_add(Weight::from_parts(163_040, 0).saturating_mul(v.into()))
// Standard Error: 37_160
.saturating_add(Weight::from_parts(3_343_858, 0).saturating_mul(a.into()))
// Measured: `194 + t * (32 ±0) + v * (553 ±0)`
// Estimated: `1679 + t * (32 ±0) + v * (553 ±0)`
// Minimum execution time: 4_190_524_000 picoseconds.
Weight::from_parts(4_200_207_000, 1679)
// Standard Error: 12_454
.saturating_add(Weight::from_parts(166_342, 0).saturating_mul(v.into()))
// Standard Error: 36_906
.saturating_add(Weight::from_parts(3_493_372, 0).saturating_mul(a.into()))
.saturating_add(T::DbWeight::get().reads(4_u64))
.saturating_add(Weight::from_parts(0, 2212).saturating_mul(v.into()))
.saturating_add(Weight::from_parts(0, 128).saturating_mul(t.into()))
.saturating_add(Weight::from_parts(0, 32).saturating_mul(t.into()))
.saturating_add(Weight::from_parts(0, 553).saturating_mul(v.into()))
}
}
@@ -296,9 +293,9 @@ impl WeightInfo for () {
fn on_initialize_nothing() -> Weight {
// Proof Size summary in bytes:
// Measured: `994`
// Estimated: `14903`
// Minimum execution time: 21_538_000 picoseconds.
Weight::from_parts(22_045_000, 14903)
// Estimated: `3481`
// Minimum execution time: 21_239_000 picoseconds.
Weight::from_parts(21_970_000, 3481)
.saturating_add(RocksDbWeight::get().reads(8_u64))
}
/// Storage: ElectionProviderMultiPhase Round (r:1 w:0)
@@ -308,9 +305,9 @@ impl WeightInfo for () {
fn on_initialize_open_signed() -> Weight {
// Proof Size summary in bytes:
// Measured: `114`
// Estimated: `3198`
// Minimum execution time: 12_696_000 picoseconds.
Weight::from_parts(12_950_000, 3198)
// Estimated: `1599`
// Minimum execution time: 13_913_000 picoseconds.
Weight::from_parts(14_329_000, 1599)
.saturating_add(RocksDbWeight::get().reads(2_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
@@ -321,9 +318,9 @@ impl WeightInfo for () {
fn on_initialize_open_unsigned() -> Weight {
// Proof Size summary in bytes:
// Measured: `114`
// Estimated: `3198`
// Minimum execution time: 14_029_000 picoseconds.
Weight::from_parts(14_288_000, 3198)
// Estimated: `1599`
// Minimum execution time: 15_377_000 picoseconds.
Weight::from_parts(15_714_000, 1599)
.saturating_add(RocksDbWeight::get().reads(2_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
@@ -334,9 +331,9 @@ impl WeightInfo for () {
fn finalize_signed_phase_accept_solution() -> Weight {
// Proof Size summary in bytes:
// Measured: `174`
// Estimated: `3767`
// Minimum execution time: 26_468_000 picoseconds.
Weight::from_parts(26_790_000, 3767)
// Estimated: `3593`
// Minimum execution time: 32_899_000 picoseconds.
Weight::from_parts(33_455_000, 3593)
.saturating_add(RocksDbWeight::get().reads(1_u64))
.saturating_add(RocksDbWeight::get().writes(2_u64))
}
@@ -346,8 +343,8 @@ impl WeightInfo for () {
// Proof Size summary in bytes:
// Measured: `174`
// Estimated: `3593`
// Minimum execution time: 18_401_000 picoseconds.
Weight::from_parts(18_686_000, 3593)
// Minimum execution time: 22_532_000 picoseconds.
Weight::from_parts(23_039_000, 3593)
.saturating_add(RocksDbWeight::get().reads(1_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
@@ -363,10 +360,10 @@ impl WeightInfo for () {
// Proof Size summary in bytes:
// Measured: `0`
// Estimated: `0`
// Minimum execution time: 266_901_000 picoseconds.
Weight::from_parts(270_251_000, 0)
// Standard Error: 1_758
.saturating_add(Weight::from_parts(167_310, 0).saturating_mul(v.into()))
// Minimum execution time: 253_511_000 picoseconds.
Weight::from_parts(261_190_000, 0)
// Standard Error: 1_621
.saturating_add(Weight::from_parts(157_608, 0).saturating_mul(v.into()))
.saturating_add(RocksDbWeight::get().writes(3_u64))
}
/// Storage: ElectionProviderMultiPhase SignedSubmissionIndices (r:1 w:1)
@@ -392,17 +389,17 @@ impl WeightInfo for () {
fn elect_queued(a: u32, d: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `337 + a * (768 ±0) + d * (48 ±0)`
// Estimated: `16191 + a * (6912 ±0) + d * (441 ±0)`
// Minimum execution time: 286_523_000 picoseconds.
Weight::from_parts(19_101_753, 16191)
// Standard Error: 4_194
.saturating_add(Weight::from_parts(398_102, 0).saturating_mul(a.into()))
// Standard Error: 6_287
.saturating_add(Weight::from_parts(188_928, 0).saturating_mul(d.into()))
// Estimated: `3889 + a * (768 ±0) + d * (49 ±0)`
// Minimum execution time: 284_994_000 picoseconds.
Weight::from_parts(97_696_734, 3889)
// Standard Error: 4_172
.saturating_add(Weight::from_parts(331_569, 0).saturating_mul(a.into()))
// Standard Error: 6_254
.saturating_add(Weight::from_parts(92_198, 0).saturating_mul(d.into()))
.saturating_add(RocksDbWeight::get().reads(7_u64))
.saturating_add(RocksDbWeight::get().writes(8_u64))
.saturating_add(Weight::from_parts(0, 6912).saturating_mul(a.into()))
.saturating_add(Weight::from_parts(0, 441).saturating_mul(d.into()))
.saturating_add(Weight::from_parts(0, 768).saturating_mul(a.into()))
.saturating_add(Weight::from_parts(0, 49).saturating_mul(d.into()))
}
/// Storage: ElectionProviderMultiPhase CurrentPhase (r:1 w:0)
/// Proof Skipped: ElectionProviderMultiPhase CurrentPhase (max_values: Some(1), max_size: None, mode: Measured)
@@ -419,9 +416,9 @@ impl WeightInfo for () {
fn submit() -> Weight {
// Proof Size summary in bytes:
// Measured: `893`
// Estimated: `11906`
// Minimum execution time: 47_876_000 picoseconds.
Weight::from_parts(48_464_000, 11906)
// Estimated: `2378`
// Minimum execution time: 52_194_000 picoseconds.
Weight::from_parts(53_062_000, 2378)
.saturating_add(RocksDbWeight::get().reads(5_u64))
.saturating_add(RocksDbWeight::get().writes(3_u64))
}
@@ -445,18 +442,18 @@ impl WeightInfo for () {
/// The range of component `d` is `[200, 400]`.
fn submit_unsigned(v: u32, t: u32, a: u32, _d: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `219 + v * (553 ±0) + t * (32 ±0)`
// Estimated: `11928 + v * (3871 ±0) + t * (224 ±0)`
// Minimum execution time: 4_702_825_000 picoseconds.
Weight::from_parts(4_752_015_000, 11928)
// Standard Error: 14_906
.saturating_add(Weight::from_parts(131_585, 0).saturating_mul(v.into()))
// Standard Error: 44_174
.saturating_add(Weight::from_parts(4_167_676, 0).saturating_mul(a.into()))
// Measured: `219 + t * (32 ±0) + v * (553 ±0)`
// Estimated: `1704 + t * (32 ±0) + v * (553 ±0)`
// Minimum execution time: 4_843_067_000 picoseconds.
Weight::from_parts(4_860_833_000, 1704)
// Standard Error: 14_594
.saturating_add(Weight::from_parts(76_611, 0).saturating_mul(v.into()))
// Standard Error: 43_249
.saturating_add(Weight::from_parts(4_347_887, 0).saturating_mul(a.into()))
.saturating_add(RocksDbWeight::get().reads(7_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
.saturating_add(Weight::from_parts(0, 3871).saturating_mul(v.into()))
.saturating_add(Weight::from_parts(0, 224).saturating_mul(t.into()))
.saturating_add(Weight::from_parts(0, 32).saturating_mul(t.into()))
.saturating_add(Weight::from_parts(0, 553).saturating_mul(v.into()))
}
/// Storage: ElectionProviderMultiPhase DesiredTargets (r:1 w:0)
/// Proof Skipped: ElectionProviderMultiPhase DesiredTargets (max_values: Some(1), max_size: None, mode: Measured)
@@ -472,16 +469,16 @@ impl WeightInfo for () {
/// The range of component `d` is `[200, 400]`.
fn feasibility_check(v: u32, t: u32, a: u32, _d: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `194 + v * (553 ±0) + t * (32 ±0)`
// Estimated: `6716 + v * (2212 ±0) + t * (128 ±0)`
// Minimum execution time: 4_069_075_000 picoseconds.
Weight::from_parts(4_105_635_000, 6716)
// Standard Error: 12_539
.saturating_add(Weight::from_parts(163_040, 0).saturating_mul(v.into()))
// Standard Error: 37_160
.saturating_add(Weight::from_parts(3_343_858, 0).saturating_mul(a.into()))
// Measured: `194 + t * (32 ±0) + v * (553 ±0)`
// Estimated: `1679 + t * (32 ±0) + v * (553 ±0)`
// Minimum execution time: 4_190_524_000 picoseconds.
Weight::from_parts(4_200_207_000, 1679)
// Standard Error: 12_454
.saturating_add(Weight::from_parts(166_342, 0).saturating_mul(v.into()))
// Standard Error: 36_906
.saturating_add(Weight::from_parts(3_493_372, 0).saturating_mul(a.into()))
.saturating_add(RocksDbWeight::get().reads(4_u64))
.saturating_add(Weight::from_parts(0, 2212).saturating_mul(v.into()))
.saturating_add(Weight::from_parts(0, 128).saturating_mul(t.into()))
.saturating_add(Weight::from_parts(0, 32).saturating_mul(t.into()))
.saturating_add(Weight::from_parts(0, 553).saturating_mul(v.into()))
}
}