Fixes PoV over-estimation (#13766)

* Align log

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Use max instead of sum

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Make comment ordering deterministic

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Dont add Pov overhead when all is ignored

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update test pallet weights

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Re-run weights on bm2

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix test

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Actually use new weights

Fucked up the merge for this file...

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update contract weights

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
This commit is contained in:
Oliver Tale-Yazdi
2023-04-13 15:11:58 +02:00
committed by GitHub
parent 46e2d3e5f8
commit ebfe00d590
54 changed files with 5526 additions and 5534 deletions
+102 -113
View File
@@ -18,9 +18,9 @@
//! Autogenerated weights for pallet_proxy
//!
//! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 4.0.0-dev
//! DATE: 2023-03-16, STEPS: `50`, REPEAT: `20`, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! DATE: 2023-04-06, STEPS: `50`, REPEAT: `20`, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! WORST CASE MAP SIZE: `1000000`
//! HOSTNAME: `bm3`, CPU: `Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz`
//! HOSTNAME: `bm2`, CPU: `Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz`
//! EXECUTION: Some(Wasm), WASM-EXECUTION: Compiled, CHAIN: Some("dev"), DB CACHE: 1024
// Executed Command:
@@ -31,9 +31,6 @@
// --steps=50
// --repeat=20
// --pallet=pallet_proxy
// --no-storage-info
// --no-median-slopes
// --no-min-squares
// --extrinsic=*
// --execution=wasm
// --wasm-execution=compiled
@@ -73,10 +70,10 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
// Proof Size summary in bytes:
// Measured: `161 + p * (37 ±0)`
// Estimated: `4706`
// Minimum execution time: 16_407_000 picoseconds.
Weight::from_parts(17_044_509, 4706)
// Standard Error: 1_177
.saturating_add(Weight::from_parts(36_533, 0).saturating_mul(p.into()))
// Minimum execution time: 16_542_000 picoseconds.
Weight::from_parts(17_131_651, 4706)
// Standard Error: 1_279
.saturating_add(Weight::from_parts(31_622, 0).saturating_mul(p.into()))
.saturating_add(T::DbWeight::get().reads(1_u64))
}
/// Storage: Proxy Proxies (r:1 w:0)
@@ -90,13 +87,13 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
fn proxy_announced(a: u32, p: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `488 + a * (68 ±0) + p * (37 ±0)`
// Estimated: `13997`
// Minimum execution time: 38_523_000 picoseconds.
Weight::from_parts(39_227_232, 13997)
// Standard Error: 5_703
.saturating_add(Weight::from_parts(136_003, 0).saturating_mul(a.into()))
// Standard Error: 5_893
.saturating_add(Weight::from_parts(42_397, 0).saturating_mul(p.into()))
// Estimated: `5698`
// Minimum execution time: 41_702_000 picoseconds.
Weight::from_parts(41_868_091, 5698)
// Standard Error: 3_771
.saturating_add(Weight::from_parts(135_604, 0).saturating_mul(a.into()))
// Standard Error: 3_896
.saturating_add(Weight::from_parts(32_615, 0).saturating_mul(p.into()))
.saturating_add(T::DbWeight::get().reads(3_u64))
.saturating_add(T::DbWeight::get().writes(2_u64))
}
@@ -106,16 +103,14 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
/// Proof: System Account (max_values: None, max_size: Some(128), added: 2603, mode: MaxEncodedLen)
/// The range of component `a` is `[0, 31]`.
/// The range of component `p` is `[1, 31]`.
fn remove_announcement(a: u32, p: u32, ) -> Weight {
fn remove_announcement(a: u32, _p: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `403 + a * (68 ±0)`
// Estimated: `9291`
// Minimum execution time: 22_541_000 picoseconds.
Weight::from_parts(23_402_268, 9291)
// Standard Error: 3_242
.saturating_add(Weight::from_parts(178_017, 0).saturating_mul(a.into()))
// Standard Error: 3_349
.saturating_add(Weight::from_parts(6_230, 0).saturating_mul(p.into()))
// Estimated: `5698`
// Minimum execution time: 25_432_000 picoseconds.
Weight::from_parts(26_301_674, 5698)
// Standard Error: 1_413
.saturating_add(Weight::from_parts(167_176, 0).saturating_mul(a.into()))
.saturating_add(T::DbWeight::get().reads(2_u64))
.saturating_add(T::DbWeight::get().writes(2_u64))
}
@@ -128,13 +123,13 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
fn reject_announcement(a: u32, p: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `403 + a * (68 ±0)`
// Estimated: `9291`
// Minimum execution time: 22_539_000 picoseconds.
Weight::from_parts(23_479_286, 9291)
// Standard Error: 1_329
.saturating_add(Weight::from_parts(174_021, 0).saturating_mul(a.into()))
// Standard Error: 1_373
.saturating_add(Weight::from_parts(6_465, 0).saturating_mul(p.into()))
// Estimated: `5698`
// Minimum execution time: 25_280_000 picoseconds.
Weight::from_parts(26_099_549, 5698)
// Standard Error: 1_458
.saturating_add(Weight::from_parts(168_724, 0).saturating_mul(a.into()))
// Standard Error: 1_507
.saturating_add(Weight::from_parts(2_212, 0).saturating_mul(p.into()))
.saturating_add(T::DbWeight::get().reads(2_u64))
.saturating_add(T::DbWeight::get().writes(2_u64))
}
@@ -149,13 +144,13 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
fn announce(a: u32, p: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `420 + a * (68 ±0) + p * (37 ±0)`
// Estimated: `13997`
// Minimum execution time: 32_049_000 picoseconds.
Weight::from_parts(35_352_453, 13997)
// Standard Error: 4_389
.saturating_add(Weight::from_parts(144_573, 0).saturating_mul(a.into()))
// Standard Error: 4_535
.saturating_add(Weight::from_parts(41_849, 0).saturating_mul(p.into()))
// Estimated: `5698`
// Minimum execution time: 35_889_000 picoseconds.
Weight::from_parts(37_535_424, 5698)
// Standard Error: 3_899
.saturating_add(Weight::from_parts(138_757, 0).saturating_mul(a.into()))
// Standard Error: 4_028
.saturating_add(Weight::from_parts(46_196, 0).saturating_mul(p.into()))
.saturating_add(T::DbWeight::get().reads(3_u64))
.saturating_add(T::DbWeight::get().writes(2_u64))
}
@@ -166,10 +161,10 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
// Proof Size summary in bytes:
// Measured: `161 + p * (37 ±0)`
// Estimated: `4706`
// Minimum execution time: 24_491_000 picoseconds.
Weight::from_parts(25_291_582, 4706)
// Standard Error: 11_080
.saturating_add(Weight::from_parts(68_024, 0).saturating_mul(p.into()))
// Minimum execution time: 26_876_000 picoseconds.
Weight::from_parts(27_356_694, 4706)
// Standard Error: 1_437
.saturating_add(Weight::from_parts(68_994, 0).saturating_mul(p.into()))
.saturating_add(T::DbWeight::get().reads(1_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
@@ -180,10 +175,10 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
// Proof Size summary in bytes:
// Measured: `161 + p * (37 ±0)`
// Estimated: `4706`
// Minimum execution time: 23_849_000 picoseconds.
Weight::from_parts(25_370_806, 4706)
// Standard Error: 8_763
.saturating_add(Weight::from_parts(63_413, 0).saturating_mul(p.into()))
// Minimum execution time: 26_655_000 picoseconds.
Weight::from_parts(27_726_692, 4706)
// Standard Error: 1_980
.saturating_add(Weight::from_parts(55_932, 0).saturating_mul(p.into()))
.saturating_add(T::DbWeight::get().reads(1_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
@@ -194,24 +189,22 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
// Proof Size summary in bytes:
// Measured: `161 + p * (37 ±0)`
// Estimated: `4706`
// Minimum execution time: 19_488_000 picoseconds.
Weight::from_parts(20_219_817, 4706)
// Standard Error: 1_385
.saturating_add(Weight::from_parts(30_354, 0).saturating_mul(p.into()))
// Minimum execution time: 23_716_000 picoseconds.
Weight::from_parts(24_660_737, 4706)
// Standard Error: 1_400
.saturating_add(Weight::from_parts(31_679, 0).saturating_mul(p.into()))
.saturating_add(T::DbWeight::get().reads(1_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
/// Storage: Proxy Proxies (r:1 w:1)
/// Proof: Proxy Proxies (max_values: None, max_size: Some(1241), added: 3716, mode: MaxEncodedLen)
/// The range of component `p` is `[1, 31]`.
fn create_pure(p: u32, ) -> Weight {
fn create_pure(_p: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `173`
// Estimated: `4706`
// Minimum execution time: 25_864_000 picoseconds.
Weight::from_parts(26_712_232, 4706)
// Standard Error: 1_331
.saturating_add(Weight::from_parts(4_401, 0).saturating_mul(p.into()))
// Minimum execution time: 28_233_000 picoseconds.
Weight::from_parts(29_602_422, 4706)
.saturating_add(T::DbWeight::get().reads(1_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
@@ -222,10 +215,10 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
// Proof Size summary in bytes:
// Measured: `198 + p * (37 ±0)`
// Estimated: `4706`
// Minimum execution time: 20_488_000 picoseconds.
Weight::from_parts(21_135_155, 4706)
// Standard Error: 1_255
.saturating_add(Weight::from_parts(36_312, 0).saturating_mul(p.into()))
// Minimum execution time: 24_759_000 picoseconds.
Weight::from_parts(25_533_053, 4706)
// Standard Error: 1_254
.saturating_add(Weight::from_parts(36_331, 0).saturating_mul(p.into()))
.saturating_add(T::DbWeight::get().reads(1_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
@@ -240,10 +233,10 @@ impl WeightInfo for () {
// Proof Size summary in bytes:
// Measured: `161 + p * (37 ±0)`
// Estimated: `4706`
// Minimum execution time: 16_407_000 picoseconds.
Weight::from_parts(17_044_509, 4706)
// Standard Error: 1_177
.saturating_add(Weight::from_parts(36_533, 0).saturating_mul(p.into()))
// Minimum execution time: 16_542_000 picoseconds.
Weight::from_parts(17_131_651, 4706)
// Standard Error: 1_279
.saturating_add(Weight::from_parts(31_622, 0).saturating_mul(p.into()))
.saturating_add(RocksDbWeight::get().reads(1_u64))
}
/// Storage: Proxy Proxies (r:1 w:0)
@@ -257,13 +250,13 @@ impl WeightInfo for () {
fn proxy_announced(a: u32, p: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `488 + a * (68 ±0) + p * (37 ±0)`
// Estimated: `13997`
// Minimum execution time: 38_523_000 picoseconds.
Weight::from_parts(39_227_232, 13997)
// Standard Error: 5_703
.saturating_add(Weight::from_parts(136_003, 0).saturating_mul(a.into()))
// Standard Error: 5_893
.saturating_add(Weight::from_parts(42_397, 0).saturating_mul(p.into()))
// Estimated: `5698`
// Minimum execution time: 41_702_000 picoseconds.
Weight::from_parts(41_868_091, 5698)
// Standard Error: 3_771
.saturating_add(Weight::from_parts(135_604, 0).saturating_mul(a.into()))
// Standard Error: 3_896
.saturating_add(Weight::from_parts(32_615, 0).saturating_mul(p.into()))
.saturating_add(RocksDbWeight::get().reads(3_u64))
.saturating_add(RocksDbWeight::get().writes(2_u64))
}
@@ -273,16 +266,14 @@ impl WeightInfo for () {
/// Proof: System Account (max_values: None, max_size: Some(128), added: 2603, mode: MaxEncodedLen)
/// The range of component `a` is `[0, 31]`.
/// The range of component `p` is `[1, 31]`.
fn remove_announcement(a: u32, p: u32, ) -> Weight {
fn remove_announcement(a: u32, _p: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `403 + a * (68 ±0)`
// Estimated: `9291`
// Minimum execution time: 22_541_000 picoseconds.
Weight::from_parts(23_402_268, 9291)
// Standard Error: 3_242
.saturating_add(Weight::from_parts(178_017, 0).saturating_mul(a.into()))
// Standard Error: 3_349
.saturating_add(Weight::from_parts(6_230, 0).saturating_mul(p.into()))
// Estimated: `5698`
// Minimum execution time: 25_432_000 picoseconds.
Weight::from_parts(26_301_674, 5698)
// Standard Error: 1_413
.saturating_add(Weight::from_parts(167_176, 0).saturating_mul(a.into()))
.saturating_add(RocksDbWeight::get().reads(2_u64))
.saturating_add(RocksDbWeight::get().writes(2_u64))
}
@@ -295,13 +286,13 @@ impl WeightInfo for () {
fn reject_announcement(a: u32, p: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `403 + a * (68 ±0)`
// Estimated: `9291`
// Minimum execution time: 22_539_000 picoseconds.
Weight::from_parts(23_479_286, 9291)
// Standard Error: 1_329
.saturating_add(Weight::from_parts(174_021, 0).saturating_mul(a.into()))
// Standard Error: 1_373
.saturating_add(Weight::from_parts(6_465, 0).saturating_mul(p.into()))
// Estimated: `5698`
// Minimum execution time: 25_280_000 picoseconds.
Weight::from_parts(26_099_549, 5698)
// Standard Error: 1_458
.saturating_add(Weight::from_parts(168_724, 0).saturating_mul(a.into()))
// Standard Error: 1_507
.saturating_add(Weight::from_parts(2_212, 0).saturating_mul(p.into()))
.saturating_add(RocksDbWeight::get().reads(2_u64))
.saturating_add(RocksDbWeight::get().writes(2_u64))
}
@@ -316,13 +307,13 @@ impl WeightInfo for () {
fn announce(a: u32, p: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `420 + a * (68 ±0) + p * (37 ±0)`
// Estimated: `13997`
// Minimum execution time: 32_049_000 picoseconds.
Weight::from_parts(35_352_453, 13997)
// Standard Error: 4_389
.saturating_add(Weight::from_parts(144_573, 0).saturating_mul(a.into()))
// Standard Error: 4_535
.saturating_add(Weight::from_parts(41_849, 0).saturating_mul(p.into()))
// Estimated: `5698`
// Minimum execution time: 35_889_000 picoseconds.
Weight::from_parts(37_535_424, 5698)
// Standard Error: 3_899
.saturating_add(Weight::from_parts(138_757, 0).saturating_mul(a.into()))
// Standard Error: 4_028
.saturating_add(Weight::from_parts(46_196, 0).saturating_mul(p.into()))
.saturating_add(RocksDbWeight::get().reads(3_u64))
.saturating_add(RocksDbWeight::get().writes(2_u64))
}
@@ -333,10 +324,10 @@ impl WeightInfo for () {
// Proof Size summary in bytes:
// Measured: `161 + p * (37 ±0)`
// Estimated: `4706`
// Minimum execution time: 24_491_000 picoseconds.
Weight::from_parts(25_291_582, 4706)
// Standard Error: 11_080
.saturating_add(Weight::from_parts(68_024, 0).saturating_mul(p.into()))
// Minimum execution time: 26_876_000 picoseconds.
Weight::from_parts(27_356_694, 4706)
// Standard Error: 1_437
.saturating_add(Weight::from_parts(68_994, 0).saturating_mul(p.into()))
.saturating_add(RocksDbWeight::get().reads(1_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
@@ -347,10 +338,10 @@ impl WeightInfo for () {
// Proof Size summary in bytes:
// Measured: `161 + p * (37 ±0)`
// Estimated: `4706`
// Minimum execution time: 23_849_000 picoseconds.
Weight::from_parts(25_370_806, 4706)
// Standard Error: 8_763
.saturating_add(Weight::from_parts(63_413, 0).saturating_mul(p.into()))
// Minimum execution time: 26_655_000 picoseconds.
Weight::from_parts(27_726_692, 4706)
// Standard Error: 1_980
.saturating_add(Weight::from_parts(55_932, 0).saturating_mul(p.into()))
.saturating_add(RocksDbWeight::get().reads(1_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
@@ -361,24 +352,22 @@ impl WeightInfo for () {
// Proof Size summary in bytes:
// Measured: `161 + p * (37 ±0)`
// Estimated: `4706`
// Minimum execution time: 19_488_000 picoseconds.
Weight::from_parts(20_219_817, 4706)
// Standard Error: 1_385
.saturating_add(Weight::from_parts(30_354, 0).saturating_mul(p.into()))
// Minimum execution time: 23_716_000 picoseconds.
Weight::from_parts(24_660_737, 4706)
// Standard Error: 1_400
.saturating_add(Weight::from_parts(31_679, 0).saturating_mul(p.into()))
.saturating_add(RocksDbWeight::get().reads(1_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
/// Storage: Proxy Proxies (r:1 w:1)
/// Proof: Proxy Proxies (max_values: None, max_size: Some(1241), added: 3716, mode: MaxEncodedLen)
/// The range of component `p` is `[1, 31]`.
fn create_pure(p: u32, ) -> Weight {
fn create_pure(_p: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `173`
// Estimated: `4706`
// Minimum execution time: 25_864_000 picoseconds.
Weight::from_parts(26_712_232, 4706)
// Standard Error: 1_331
.saturating_add(Weight::from_parts(4_401, 0).saturating_mul(p.into()))
// Minimum execution time: 28_233_000 picoseconds.
Weight::from_parts(29_602_422, 4706)
.saturating_add(RocksDbWeight::get().reads(1_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
@@ -389,10 +378,10 @@ impl WeightInfo for () {
// Proof Size summary in bytes:
// Measured: `198 + p * (37 ±0)`
// Estimated: `4706`
// Minimum execution time: 20_488_000 picoseconds.
Weight::from_parts(21_135_155, 4706)
// Standard Error: 1_255
.saturating_add(Weight::from_parts(36_312, 0).saturating_mul(p.into()))
// Minimum execution time: 24_759_000 picoseconds.
Weight::from_parts(25_533_053, 4706)
// Standard Error: 1_254
.saturating_add(Weight::from_parts(36_331, 0).saturating_mul(p.into()))
.saturating_add(RocksDbWeight::get().reads(1_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}