Fixes PoV over-estimation (#13766)

* Align log

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Use max instead of sum

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Make comment ordering deterministic

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Dont add Pov overhead when all is ignored

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update test pallet weights

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Re-run weights on bm2

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix test

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Actually use new weights

Fucked up the merge for this file...

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update contract weights

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
This commit is contained in:
Oliver Tale-Yazdi
2023-04-13 15:11:58 +02:00
committed by GitHub
parent 46e2d3e5f8
commit ebfe00d590
54 changed files with 5526 additions and 5534 deletions
+80 -83
View File
@@ -18,9 +18,9 @@
//! Autogenerated weights for pallet_scheduler
//!
//! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 4.0.0-dev
//! DATE: 2023-03-16, STEPS: `50`, REPEAT: `20`, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! DATE: 2023-04-06, STEPS: `50`, REPEAT: `20`, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! WORST CASE MAP SIZE: `1000000`
//! HOSTNAME: `bm3`, CPU: `Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz`
//! HOSTNAME: `bm2`, CPU: `Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz`
//! EXECUTION: Some(Wasm), WASM-EXECUTION: Compiled, CHAIN: Some("dev"), DB CACHE: 1024
// Executed Command:
@@ -31,9 +31,6 @@
// --steps=50
// --repeat=20
// --pallet=pallet_scheduler
// --no-storage-info
// --no-median-slopes
// --no-min-squares
// --extrinsic=*
// --execution=wasm
// --wasm-execution=compiled
@@ -74,8 +71,8 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
// Proof Size summary in bytes:
// Measured: `31`
// Estimated: `1489`
// Minimum execution time: 3_965_000 picoseconds.
Weight::from_parts(4_126_000, 1489)
// Minimum execution time: 3_776_000 picoseconds.
Weight::from_parts(3_992_000, 1489)
.saturating_add(T::DbWeight::get().reads(1_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
@@ -86,10 +83,10 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
// Proof Size summary in bytes:
// Measured: `81 + s * (177 ±0)`
// Estimated: `110487`
// Minimum execution time: 3_662_000 picoseconds.
Weight::from_parts(8_746_597, 110487)
// Standard Error: 754
.saturating_add(Weight::from_parts(309_350, 0).saturating_mul(s.into()))
// Minimum execution time: 3_418_000 picoseconds.
Weight::from_parts(8_606_012, 110487)
// Standard Error: 769
.saturating_add(Weight::from_parts(309_376, 0).saturating_mul(s.into()))
.saturating_add(T::DbWeight::get().reads(1_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
@@ -97,8 +94,8 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
// Proof Size summary in bytes:
// Measured: `0`
// Estimated: `0`
// Minimum execution time: 5_807_000 picoseconds.
Weight::from_parts(5_963_000, 0)
// Minimum execution time: 5_624_000 picoseconds.
Weight::from_parts(5_758_000, 0)
}
/// Storage: Preimage PreimageFor (r:1 w:1)
/// Proof: Preimage PreimageFor (max_values: None, max_size: Some(4194344), added: 4196819, mode: Measured)
@@ -108,11 +105,11 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
fn service_task_fetched(s: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `179 + s * (1 ±0)`
// Estimated: `7200 + s * (1 ±0)`
// Minimum execution time: 20_188_000 picoseconds.
Weight::from_parts(20_422_000, 7200)
// Standard Error: 1
.saturating_add(Weight::from_parts(1_143, 0).saturating_mul(s.into()))
// Estimated: `3644 + s * (1 ±0)`
// Minimum execution time: 20_150_000 picoseconds.
Weight::from_parts(20_271_000, 3644)
// Standard Error: 0
.saturating_add(Weight::from_parts(1_132, 0).saturating_mul(s.into()))
.saturating_add(T::DbWeight::get().reads(2_u64))
.saturating_add(T::DbWeight::get().writes(2_u64))
.saturating_add(Weight::from_parts(0, 1).saturating_mul(s.into()))
@@ -123,30 +120,30 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
// Proof Size summary in bytes:
// Measured: `0`
// Estimated: `0`
// Minimum execution time: 7_787_000 picoseconds.
Weight::from_parts(8_046_000, 0)
// Minimum execution time: 7_451_000 picoseconds.
Weight::from_parts(7_693_000, 0)
.saturating_add(T::DbWeight::get().writes(1_u64))
}
fn service_task_periodic() -> Weight {
// Proof Size summary in bytes:
// Measured: `0`
// Estimated: `0`
// Minimum execution time: 5_730_000 picoseconds.
Weight::from_parts(5_901_000, 0)
// Minimum execution time: 5_477_000 picoseconds.
Weight::from_parts(5_733_000, 0)
}
fn execute_dispatch_signed() -> Weight {
// Proof Size summary in bytes:
// Measured: `0`
// Estimated: `0`
// Minimum execution time: 2_569_000 picoseconds.
Weight::from_parts(2_710_000, 0)
// Minimum execution time: 2_675_000 picoseconds.
Weight::from_parts(2_870_000, 0)
}
fn execute_dispatch_unsigned() -> Weight {
// Proof Size summary in bytes:
// Measured: `0`
// Estimated: `0`
// Minimum execution time: 2_611_000 picoseconds.
Weight::from_parts(2_765_000, 0)
// Minimum execution time: 2_697_000 picoseconds.
Weight::from_parts(2_807_000, 0)
}
/// Storage: Scheduler Agenda (r:1 w:1)
/// Proof: Scheduler Agenda (max_values: None, max_size: Some(107022), added: 109497, mode: MaxEncodedLen)
@@ -155,10 +152,10 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
// Proof Size summary in bytes:
// Measured: `81 + s * (177 ±0)`
// Estimated: `110487`
// Minimum execution time: 14_237_000 picoseconds.
Weight::from_parts(18_553_929, 110487)
// Standard Error: 757
.saturating_add(Weight::from_parts(327_347, 0).saturating_mul(s.into()))
// Minimum execution time: 13_921_000 picoseconds.
Weight::from_parts(18_717_223, 110487)
// Standard Error: 771
.saturating_add(Weight::from_parts(333_102, 0).saturating_mul(s.into()))
.saturating_add(T::DbWeight::get().reads(1_u64))
.saturating_add(T::DbWeight::get().writes(1_u64))
}
@@ -171,10 +168,10 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
// Proof Size summary in bytes:
// Measured: `81 + s * (177 ±0)`
// Estimated: `110487`
// Minimum execution time: 18_003_000 picoseconds.
Weight::from_parts(19_521_283, 110487)
// Standard Error: 901
.saturating_add(Weight::from_parts(496_401, 0).saturating_mul(s.into()))
// Minimum execution time: 17_552_000 picoseconds.
Weight::from_parts(19_006_016, 110487)
// Standard Error: 1_115
.saturating_add(Weight::from_parts(495_979, 0).saturating_mul(s.into()))
.saturating_add(T::DbWeight::get().reads(1_u64))
.saturating_add(T::DbWeight::get().writes(2_u64))
}
@@ -186,11 +183,11 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
fn schedule_named(s: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `596 + s * (178 ±0)`
// Estimated: `114000`
// Minimum execution time: 17_713_000 picoseconds.
Weight::from_parts(24_442_945, 114000)
// Standard Error: 764
.saturating_add(Weight::from_parts(330_307, 0).saturating_mul(s.into()))
// Estimated: `110487`
// Minimum execution time: 17_240_000 picoseconds.
Weight::from_parts(24_376_370, 110487)
// Standard Error: 928
.saturating_add(Weight::from_parts(331_209, 0).saturating_mul(s.into()))
.saturating_add(T::DbWeight::get().reads(2_u64))
.saturating_add(T::DbWeight::get().writes(2_u64))
}
@@ -202,11 +199,11 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
fn cancel_named(s: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `709 + s * (177 ±0)`
// Estimated: `114000`
// Minimum execution time: 19_808_000 picoseconds.
Weight::from_parts(22_601_896, 114000)
// Standard Error: 991
.saturating_add(Weight::from_parts(496_702, 0).saturating_mul(s.into()))
// Estimated: `110487`
// Minimum execution time: 19_731_000 picoseconds.
Weight::from_parts(23_787_948, 110487)
// Standard Error: 1_133
.saturating_add(Weight::from_parts(503_805, 0).saturating_mul(s.into()))
.saturating_add(T::DbWeight::get().reads(2_u64))
.saturating_add(T::DbWeight::get().writes(2_u64))
}
@@ -220,8 +217,8 @@ impl WeightInfo for () {
// Proof Size summary in bytes:
// Measured: `31`
// Estimated: `1489`
// Minimum execution time: 3_965_000 picoseconds.
Weight::from_parts(4_126_000, 1489)
// Minimum execution time: 3_776_000 picoseconds.
Weight::from_parts(3_992_000, 1489)
.saturating_add(RocksDbWeight::get().reads(1_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
@@ -232,10 +229,10 @@ impl WeightInfo for () {
// Proof Size summary in bytes:
// Measured: `81 + s * (177 ±0)`
// Estimated: `110487`
// Minimum execution time: 3_662_000 picoseconds.
Weight::from_parts(8_746_597, 110487)
// Standard Error: 754
.saturating_add(Weight::from_parts(309_350, 0).saturating_mul(s.into()))
// Minimum execution time: 3_418_000 picoseconds.
Weight::from_parts(8_606_012, 110487)
// Standard Error: 769
.saturating_add(Weight::from_parts(309_376, 0).saturating_mul(s.into()))
.saturating_add(RocksDbWeight::get().reads(1_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
@@ -243,8 +240,8 @@ impl WeightInfo for () {
// Proof Size summary in bytes:
// Measured: `0`
// Estimated: `0`
// Minimum execution time: 5_807_000 picoseconds.
Weight::from_parts(5_963_000, 0)
// Minimum execution time: 5_624_000 picoseconds.
Weight::from_parts(5_758_000, 0)
}
/// Storage: Preimage PreimageFor (r:1 w:1)
/// Proof: Preimage PreimageFor (max_values: None, max_size: Some(4194344), added: 4196819, mode: Measured)
@@ -254,11 +251,11 @@ impl WeightInfo for () {
fn service_task_fetched(s: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `179 + s * (1 ±0)`
// Estimated: `7200 + s * (1 ±0)`
// Minimum execution time: 20_188_000 picoseconds.
Weight::from_parts(20_422_000, 7200)
// Standard Error: 1
.saturating_add(Weight::from_parts(1_143, 0).saturating_mul(s.into()))
// Estimated: `3644 + s * (1 ±0)`
// Minimum execution time: 20_150_000 picoseconds.
Weight::from_parts(20_271_000, 3644)
// Standard Error: 0
.saturating_add(Weight::from_parts(1_132, 0).saturating_mul(s.into()))
.saturating_add(RocksDbWeight::get().reads(2_u64))
.saturating_add(RocksDbWeight::get().writes(2_u64))
.saturating_add(Weight::from_parts(0, 1).saturating_mul(s.into()))
@@ -269,30 +266,30 @@ impl WeightInfo for () {
// Proof Size summary in bytes:
// Measured: `0`
// Estimated: `0`
// Minimum execution time: 7_787_000 picoseconds.
Weight::from_parts(8_046_000, 0)
// Minimum execution time: 7_451_000 picoseconds.
Weight::from_parts(7_693_000, 0)
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
fn service_task_periodic() -> Weight {
// Proof Size summary in bytes:
// Measured: `0`
// Estimated: `0`
// Minimum execution time: 5_730_000 picoseconds.
Weight::from_parts(5_901_000, 0)
// Minimum execution time: 5_477_000 picoseconds.
Weight::from_parts(5_733_000, 0)
}
fn execute_dispatch_signed() -> Weight {
// Proof Size summary in bytes:
// Measured: `0`
// Estimated: `0`
// Minimum execution time: 2_569_000 picoseconds.
Weight::from_parts(2_710_000, 0)
// Minimum execution time: 2_675_000 picoseconds.
Weight::from_parts(2_870_000, 0)
}
fn execute_dispatch_unsigned() -> Weight {
// Proof Size summary in bytes:
// Measured: `0`
// Estimated: `0`
// Minimum execution time: 2_611_000 picoseconds.
Weight::from_parts(2_765_000, 0)
// Minimum execution time: 2_697_000 picoseconds.
Weight::from_parts(2_807_000, 0)
}
/// Storage: Scheduler Agenda (r:1 w:1)
/// Proof: Scheduler Agenda (max_values: None, max_size: Some(107022), added: 109497, mode: MaxEncodedLen)
@@ -301,10 +298,10 @@ impl WeightInfo for () {
// Proof Size summary in bytes:
// Measured: `81 + s * (177 ±0)`
// Estimated: `110487`
// Minimum execution time: 14_237_000 picoseconds.
Weight::from_parts(18_553_929, 110487)
// Standard Error: 757
.saturating_add(Weight::from_parts(327_347, 0).saturating_mul(s.into()))
// Minimum execution time: 13_921_000 picoseconds.
Weight::from_parts(18_717_223, 110487)
// Standard Error: 771
.saturating_add(Weight::from_parts(333_102, 0).saturating_mul(s.into()))
.saturating_add(RocksDbWeight::get().reads(1_u64))
.saturating_add(RocksDbWeight::get().writes(1_u64))
}
@@ -317,10 +314,10 @@ impl WeightInfo for () {
// Proof Size summary in bytes:
// Measured: `81 + s * (177 ±0)`
// Estimated: `110487`
// Minimum execution time: 18_003_000 picoseconds.
Weight::from_parts(19_521_283, 110487)
// Standard Error: 901
.saturating_add(Weight::from_parts(496_401, 0).saturating_mul(s.into()))
// Minimum execution time: 17_552_000 picoseconds.
Weight::from_parts(19_006_016, 110487)
// Standard Error: 1_115
.saturating_add(Weight::from_parts(495_979, 0).saturating_mul(s.into()))
.saturating_add(RocksDbWeight::get().reads(1_u64))
.saturating_add(RocksDbWeight::get().writes(2_u64))
}
@@ -332,11 +329,11 @@ impl WeightInfo for () {
fn schedule_named(s: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `596 + s * (178 ±0)`
// Estimated: `114000`
// Minimum execution time: 17_713_000 picoseconds.
Weight::from_parts(24_442_945, 114000)
// Standard Error: 764
.saturating_add(Weight::from_parts(330_307, 0).saturating_mul(s.into()))
// Estimated: `110487`
// Minimum execution time: 17_240_000 picoseconds.
Weight::from_parts(24_376_370, 110487)
// Standard Error: 928
.saturating_add(Weight::from_parts(331_209, 0).saturating_mul(s.into()))
.saturating_add(RocksDbWeight::get().reads(2_u64))
.saturating_add(RocksDbWeight::get().writes(2_u64))
}
@@ -348,11 +345,11 @@ impl WeightInfo for () {
fn cancel_named(s: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `709 + s * (177 ±0)`
// Estimated: `114000`
// Minimum execution time: 19_808_000 picoseconds.
Weight::from_parts(22_601_896, 114000)
// Standard Error: 991
.saturating_add(Weight::from_parts(496_702, 0).saturating_mul(s.into()))
// Estimated: `110487`
// Minimum execution time: 19_731_000 picoseconds.
Weight::from_parts(23_787_948, 110487)
// Standard Error: 1_133
.saturating_add(Weight::from_parts(503_805, 0).saturating_mul(s.into()))
.saturating_add(RocksDbWeight::get().reads(2_u64))
.saturating_add(RocksDbWeight::get().writes(2_u64))
}