pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-04-26 06:27:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Re-add deprecated --execution arg on benchmark pallet (#14567)

Browse Source 
* Add DeferGuard::new

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Re-add deprecated 'execution' arg to benchmark pallet cmd.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Extend tests

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Remove from tests

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
This commit is contained in:
Oliver Tale-Yazdi
2023-07-13 19:41:56 +02:00
committed by GitHub
parent c4e880c155
commit ee0be2bab7
7 changed files with 34 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
substrate/bin/node/cli/tests/benchmark_block_works.rs
+1 -1
View File
@@ -39,7 +39,7 @@ async fn benchmark_block_works() {
.arg(base_dir.path())
.args(["--from", "1", "--to", "1"])
.args(["--repeat", "1"])
.args(["--wasm-execution", "compiled"])
.args(["--wasm-execution=compiled"])
.status()
.unwrap();
substrate/bin/node/cli/tests/benchmark_extrinsic_works.rs
+1
View File
@@ -39,6 +39,7 @@ fn benchmark_extrinsic(pallet: &str, extrinsic: &str) {
.args(&["--pallet", pallet, "--extrinsic", extrinsic])
// Run with low repeats for faster execution.
.args(["--warmup=10", "--repeat=10", "--max-ext-per-block=10"])
.args(["--wasm-execution=compiled"])
.status()
.unwrap();
substrate/bin/node/cli/tests/benchmark_overhead_works.rs
+1
View File
@@ -36,6 +36,7 @@ fn benchmark_overhead_works() {
.args(["--warmup", "10", "--repeat", "10"])
.args(["--add", "100", "--mul", "1.2", "--metric", "p75"])
.args(["--max-ext-per-block", "10"])
.args(["--wasm-execution=compiled"])
.status()
.unwrap();
assert!(status.success());
substrate/bin/node/cli/tests/benchmark_pallet_works.rs
+10 -6
View File
@@ -34,16 +34,20 @@ fn benchmark_pallet_works() {
}
fn benchmark_pallet(steps: u32, repeat: u32, should_work: bool) {
let output = Command::new(cargo_bin("substrate"))
let status = Command::new(cargo_bin("substrate"))
.args(["benchmark", "pallet", "--dev"])
// Use the `addition` benchmark since is the fastest.
.args(["--pallet", "frame-benchmarking", "--extrinsic", "addition"])
.args(["--steps", &format!("{}", steps), "--repeat", &format!("{}", repeat)])
.output()
.args([
"--wasm-execution=compiled",
"--no-storage-info",
"--no-median-slopes",
"--no-min-squares",
"--heap-pages=4096",
])
.status()
.unwrap();
if output.status.success() != should_work {
let log = String::from_utf8_lossy(&output.stderr).to_string();
panic!("Test failed:\n{}", log);
}
assert_eq!(status.success(), should_work);
}