contracts: Fix double charge of gas for host functions (#3361)

This PR is fixing a bug in the sync mechanism between wasmi and
pallet-contracts. This bug leads to essentially double charging all the
gas that was used during the execution of the host function. When the
`call` host function is used for recursion this will lead to a quadratic
amount of gas consumption with regard to the nesting depth.We also took
the chance to refactor the code in question and improve the rust docs.

The bug was caused by not updating `GasMeter::executor_consumed`
(previously `engine_consumed`) when leaving the host function. This lead
to the value being stale (too low) when entering another host function.

---------

Co-authored-by: PG Herveou <pgherveou@gmail.com>
This commit is contained in:
Alexander TheißenandPG Herveou authored and GitHub committed 2024-02-21 10:14:48 +00:00
1 parent 579ef32ddd
commit f3a6b6dcea
6 files changed
+193 -51

No files matched your search

+1 -1
View File
@@ -386,7 +386,7 @@ impl<T: Config> Executable<T> for WasmBlob<T> {
let engine_consumed_total =
store.fuel_consumed().expect("Fuel metering is enabled; qed");
let gas_meter = store.data_mut().ext().gas_meter_mut();
gas_meter.charge_fuel(engine_consumed_total)?;
let _ = gas_meter.sync_from_executor(engine_consumed_total)?;
store.into_data().to_execution_result(result)
};