pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-04-26 09:57:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

benchmarking f32 step calculation (#11890)

Browse Source 
* benchmark steps with f32

* divide by self.steps - 1

* avoid steps <= 1

* Fix step size

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix 'steps' print and print number of args

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add Test

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* fix comments

* Remove unneeded comment

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: parity-processbot <>
This commit is contained in:
bernardo
2022-08-02 13:43:57 +01:00
committed by GitHub
parent 795afe2747
commit f5c644f272
2 changed files with 67 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
substrate/utils/frame/benchmarking-cli/src/pallet/command.rs
+18 -9
View File
@@ -236,14 +236,22 @@ impl PalletCmd {
let lowest = self.lowest_range_values.get(idx).cloned().unwrap_or(*low);
let highest = self.highest_range_values.get(idx).cloned().unwrap_or(*high);
let diff = highest - lowest;
let diff =
highest.checked_sub(lowest).ok_or("`low` cannot be higher than `high`")?;
// Create up to `STEPS` steps for that component between high and low.
let step_size = (diff / self.steps).max(1);
let num_of_steps = diff / step_size + 1;
for s in 0..num_of_steps {
// The slope logic needs at least two points
// to compute a slope.
if self.steps < 2 {
return Err("`steps` must be at least 2.".into())
}
let step_size = (diff as f32 / (self.steps - 1) as f32).max(0.0);
for s in 0..self.steps {
// This is the value we will be testing for component `name`
let component_value = lowest + step_size * s;
let component_value = ((lowest as f32 + step_size * s as f32) as u32)
.min(highest)
.max(lowest);
// Select the max value for all the other components.
let c: Vec<(BenchmarkParameter, u32)> = components
@@ -364,13 +372,14 @@ impl PalletCmd {
if elapsed >= time::Duration::from_secs(5) {
timer = time::SystemTime::now();
log::info!(
"Running Benchmark: {}.{} {}/{} {}/{}",
"Running Benchmark: {}.{}({} args) {}/{} {}/{}",
String::from_utf8(pallet.clone())
.expect("Encoded from String; qed"),
String::from_utf8(extrinsic.clone())
.expect("Encoded from String; qed"),
s + 1, // s starts at 0. todo show step
self.steps,
components.len(),
s + 1, // s starts at 0.
all_components.len(),
r + 1,
self.external_repeat,
);