Bump clap to 4.0.x and adjust to best practices (#12381)

* Bump clap to 3.2.22

* Replace `from_os_str` with `value_parser`

* Replace `from_str` and `try_from_str` with `value_parser`

* Move possible_values to the new format

* Remove unwanted print

* Add missing match branch

* Update clap to 4.0.9 and make it compile

* Replace deprecated `clap` macro with `command` and `value`

* Move remaining `clap` attributes to `arg`

* Remove no-op value_parsers

* Adjust value_parser for state_version

* Remove "deprecated" feature flag and bump to 4.0.11

* Improve range

Co-authored-by: Bastian Köcher <git@kchr.de>

* Apply suggestions

* Trigger CI

* Fix unused error warning

* Fix doc errors

* Fix ArgGroup naming conflict

* Change default_value to default_value_t

* Use 1.. instead of 0..

Co-authored-by: Bastian Köcher <git@kchr.de>

substrate/client/cli/src/commands/generate_node_key.rs

@@ -28,7 +28,7 @@ use std::{
 
 /// The `generate-node-key` command
 #[derive(Debug, Parser)]
-#[clap(
+#[command(
 	name = "generate-node-key",
 	about = "Generate a random node key, write it to a file or stdout \
 		 	and write the corresponding peer-id to stderr"
@@ -37,13 +37,13 @@ pub struct GenerateNodeKeyCmd {
 	/// Name of file to save secret key to.
 	///
 	/// If not given, the secret key is printed to stdout.
-	#[clap(long)]
+	#[arg(long)]
 	file: Option<PathBuf>,
 
 	/// The output is in raw binary format.
 	///
 	/// If not given, the output is written as an hex encoded string.
-	#[clap(long)]
+	#[arg(long)]
 	bin: bool,
 }