pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-06-13 01:11:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

erasure-coding: do not panic on 1 validator (#2022)

Browse Source 
* erasure-coding: do not panic on 1 validator

* tabify fuzz tests

* remove num_validators length check

* remove unused import

* move erasure_coding_fuzzer to fuzzer

* change the authors to admit (at) parity.io

* Apply suggestions from code review

Co-authored-by: Sergei Shulepov <sergei@parity.io>

Co-authored-by: Sergei Shulepov <sergei@parity.io>
This commit is contained in:
Andronik Ordian
2020-11-27 22:49:00 +01:00
committed by GitHub
parent 700b40679c
commit f8181fa1f2
7 changed files with 72 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files
polkadot/erasure-coding/src/lib.rs
+15 -9
View File
@@ -45,9 +45,9 @@ pub enum Error {
/// Returned when there are too many validators.
#[error("There are too many validators")]
TooManyValidators,
/// Cannot encode something for no validators
#[error("Validator set is empty")]
EmptyValidators,
/// Cannot encode something for zero or one validator
#[error("Expected at least 2 validators")]
NotEnoughValidators,
/// Cannot reconstruct: wrong number of validators.
#[error("Validator count mismatches between encoding and decoding")]
WrongValidatorCount,
@@ -122,7 +122,7 @@ impl CodeParams {
fn code_params(n_validators: usize) -> Result<CodeParams, Error> {
if n_validators > MAX_VALIDATORS { return Err(Error::TooManyValidators) }
if n_validators == 0 { return Err(Error::EmptyValidators) }
if n_validators <= 1 { return Err(Error::NotEnoughValidators) }
let n_faulty = n_validators.saturating_sub(1) / 3;
let n_good = n_validators - n_faulty;
@@ -406,12 +406,9 @@ mod tests {
#[test]
fn test_code_params() {
assert_eq!(code_params(0), Err(Error::EmptyValidators));
assert_eq!(code_params(0), Err(Error::NotEnoughValidators));
assert_eq!(code_params(1), Ok(CodeParams {
data_shards: 1,
parity_shards: 0,
}));
assert_eq!(code_params(1), Err(Error::NotEnoughValidators));
assert_eq!(code_params(2), Ok(CodeParams {
data_shards: 1,
@@ -487,6 +484,15 @@ mod tests {
assert_eq!(reconstructed, available_data);
}
#[test]
fn reconstruct_does_not_panic_on_low_validator_count() {
let reconstructed = reconstruct_v1(
1,
[].iter().cloned(),
);
assert_eq!(reconstructed, Err(Error::NotEnoughValidators));
}
#[test]
fn construct_valid_branches() {
let pov_block = PoVBlock {