FRAME: Create TransactionExtension as a replacement for SignedExtension (#2280)

Closes #2160

First part of [Extrinsic
Horizon](https://github.com/paritytech/polkadot-sdk/issues/2415)

Introduces a new trait `TransactionExtension` to replace
`SignedExtension`. Introduce the idea of transactions which obey the
runtime's extensions and have according Extension data (né Extra data)
yet do not have hard-coded signatures.

Deprecate the terminology of "Unsigned" when used for
transactions/extrinsics owing to there now being "proper" unsigned
transactions which obey the extension framework and "old-style" unsigned
which do not. Instead we have __*General*__ for the former and
__*Bare*__ for the latter. (Ultimately, the latter will be phased out as
a type of transaction, and Bare will only be used for Inherents.)

Types of extrinsic are now therefore:
- Bare (no hardcoded signature, no Extra data; used to be known as
"Unsigned")
- Bare transactions (deprecated): Gossiped, validated with
`ValidateUnsigned` (deprecated) and the `_bare_compat` bits of
`TransactionExtension` (deprecated).
  - Inherents: Not gossiped, validated with `ProvideInherent`.
- Extended (Extra data): Gossiped, validated via `TransactionExtension`.
  - Signed transactions (with a hardcoded signature).
  - General transactions (without a hardcoded signature).

`TransactionExtension` differs from `SignedExtension` because:
- A signature on the underlying transaction may validly not be present.
- It may alter the origin during validation.
- `pre_dispatch` is renamed to `prepare` and need not contain the checks
present in `validate`.
- `validate` and `prepare` is passed an `Origin` rather than a
`AccountId`.
- `validate` may pass arbitrary information into `prepare` via a new
user-specifiable type `Val`.
- `AdditionalSigned`/`additional_signed` is renamed to
`Implicit`/`implicit`. It is encoded *for the entire transaction* and
passed in to each extension as a new argument to `validate`. This
facilitates the ability of extensions to acts as underlying crypto.

There is a new `DispatchTransaction` trait which contains only default
function impls and is impl'ed for any `TransactionExtension` impler. It
provides several utility functions which reduce some of the tedium from
using `TransactionExtension` (indeed, none of its regular functions
should now need to be called directly).

Three transaction version discriminator ("versions") are now
permissible:
- 0b000000100: Bare (used to be called "Unsigned"): contains Signature
or Extra (extension data). After bare transactions are no longer
supported, this will strictly identify an Inherents only.
- 0b100000100: Old-school "Signed" Transaction: contains Signature and
Extra (extension data).
- 0b010000100: New-school "General" Transaction: contains Extra
(extension data), but no Signature.

For the New-school General Transaction, it becomes trivial for authors
to publish extensions to the mechanism for authorizing an Origin, e.g.
through new kinds of key-signing schemes, ZK proofs, pallet state,
mutations over pre-authenticated origins or any combination of the
above.

## Code Migration

### NOW: Getting it to build

Wrap your `SignedExtension`s in `AsTransactionExtension`. This should be
accompanied by renaming your aggregate type in line with the new
terminology. E.g. Before:

```rust
/// The SignedExtension to the basic transaction logic.
pub type SignedExtra = (
	/* snip */
	MySpecialSignedExtension,
);
/// Unchecked extrinsic type as expected by this runtime.
pub type UncheckedExtrinsic =
	generic::UncheckedExtrinsic<Address, RuntimeCall, Signature, SignedExtra>;
```

After:

```rust
/// The extension to the basic transaction logic.
pub type TxExtension = (
	/* snip */
	AsTransactionExtension<MySpecialSignedExtension>,
);
/// Unchecked extrinsic type as expected by this runtime.
pub type UncheckedExtrinsic =
	generic::UncheckedExtrinsic<Address, RuntimeCall, Signature, TxExtension>;
```

You'll also need to alter any transaction building logic to add a
`.into()` to make the conversion happen. E.g. Before:

```rust
fn construct_extrinsic(
		/* snip */
) -> UncheckedExtrinsic {
	let extra: SignedExtra = (
		/* snip */
		MySpecialSignedExtension::new(/* snip */),
	);
	let payload = SignedPayload::new(call.clone(), extra.clone()).unwrap();
	let signature = payload.using_encoded(|e| sender.sign(e));
	UncheckedExtrinsic::new_signed(
		/* snip */
		Signature::Sr25519(signature),
		extra,
	)
}
```

After:

```rust
fn construct_extrinsic(
		/* snip */
) -> UncheckedExtrinsic {
	let tx_ext: TxExtension = (
		/* snip */
		MySpecialSignedExtension::new(/* snip */).into(),
	);
	let payload = SignedPayload::new(call.clone(), tx_ext.clone()).unwrap();
	let signature = payload.using_encoded(|e| sender.sign(e));
	UncheckedExtrinsic::new_signed(
		/* snip */
		Signature::Sr25519(signature),
		tx_ext,
	)
}
```

### SOON: Migrating to `TransactionExtension`

Most `SignedExtension`s can be trivially converted to become a
`TransactionExtension`. There are a few things to know.

- Instead of a single trait like `SignedExtension`, you should now
implement two traits individually: `TransactionExtensionBase` and
`TransactionExtension`.
- Weights are now a thing and must be provided via the new function `fn
weight`.

#### `TransactionExtensionBase`

This trait takes care of anything which is not dependent on types
specific to your runtime, most notably `Call`.

- `AdditionalSigned`/`additional_signed` is renamed to
`Implicit`/`implicit`.
- Weight must be returned by implementing the `weight` function. If your
extension is associated with a pallet, you'll probably want to do this
via the pallet's existing benchmarking infrastructure.

#### `TransactionExtension`

Generally:
- `pre_dispatch` is now `prepare` and you *should not reexecute the
`validate` functionality in there*!
- You don't get an account ID any more; you get an origin instead. If
you need to presume an account ID, then you can use the trait function
`AsSystemOriginSigner::as_system_origin_signer`.
- You get an additional ticket, similar to `Pre`, called `Val`. This
defines data which is passed from `validate` into `prepare`. This is
important since you should not be duplicating logic from `validate` to
`prepare`, you need a way of passing your working from the former into
the latter. This is it.
- This trait takes two type parameters: `Call` and `Context`. `Call` is
the runtime call type which used to be an associated type; you can just
move it to become a type parameter for your trait impl. `Context` is not
currently used and you can safely implement over it as an unbounded
type.
- There's no `AccountId` associated type any more. Just remove it.

Regarding `validate`:
- You get three new parameters in `validate`; all can be ignored when
migrating from `SignedExtension`.
- `validate` returns a tuple on success; the second item in the tuple is
the new ticket type `Self::Val` which gets passed in to `prepare`. If
you use any information extracted during `validate` (off-chain and
on-chain, non-mutating) in `prepare` (on-chain, mutating) then you can
pass it through with this. For the tuple's last item, just return the
`origin` argument.

Regarding `prepare`:
- This is renamed from `pre_dispatch`, but there is one change:
- FUNCTIONALITY TO VALIDATE THE TRANSACTION NEED NOT BE DUPLICATED FROM
`validate`!!
- (This is different to `SignedExtension` which was required to run the
same checks in `pre_dispatch` as in `validate`.)

Regarding `post_dispatch`:
- Since there are no unsigned transactions handled by
`TransactionExtension`, `Pre` is always defined, so the first parameter
is `Self::Pre` rather than `Option<Self::Pre>`.

If you make use of `SignedExtension::validate_unsigned` or
`SignedExtension::pre_dispatch_unsigned`, then:
- Just use the regular versions of these functions instead.
- Have your logic execute in the case that the `origin` is `None`.
- Ensure your transaction creation logic creates a General Transaction
rather than a Bare Transaction; this means having to include all
`TransactionExtension`s' data.
- `ValidateUnsigned` can still be used (for now) if you need to be able
to construct transactions which contain none of the extension data,
however these will be phased out in stage 2 of the Transactions Horizon,
so you should consider moving to an extension-centric design.

## TODO

- [x] Introduce `CheckSignature` impl of `TransactionExtension` to
ensure it's possible to have crypto be done wholly in a
`TransactionExtension`.
- [x] Deprecate `SignedExtension` and move all uses in codebase to
`TransactionExtension`.
  - [x] `ChargeTransactionPayment`
  - [x] `DummyExtension`
  - [x] `ChargeAssetTxPayment` (asset-tx-payment)
  - [x] `ChargeAssetTxPayment` (asset-conversion-tx-payment)
  - [x] `CheckWeight`
  - [x] `CheckTxVersion`
  - [x] `CheckSpecVersion`
  - [x] `CheckNonce`
  - [x] `CheckNonZeroSender`
  - [x] `CheckMortality`
  - [x] `CheckGenesis`
  - [x] `CheckOnlySudoAccount`
  - [x] `WatchDummy`
  - [x] `PrevalidateAttests`
  - [x] `GenericSignedExtension`
  - [x] `SignedExtension` (chain-polkadot-bulletin)
  - [x] `RefundSignedExtensionAdapter`
- [x] Implement `fn weight` across the board.
- [ ] Go through all pre-existing extensions which assume an account
signer and explicitly handle the possibility of another kind of origin.
- [x] `CheckNonce` should probably succeed in the case of a non-account
origin.
- [x] `CheckNonZeroSender` should succeed in the case of a non-account
origin.
- [x] `ChargeTransactionPayment` and family should fail in the case of a
non-account origin.
  - [ ] 
- [x] Fix any broken tests.

---------

Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Co-authored-by: Nikhil Gupta <17176722+gupnik@users.noreply.github.com>
Co-authored-by: georgepisaltu <52418509+georgepisaltu@users.noreply.github.com>
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Maciej <maciej.zyszkiewicz@parity.io>
Co-authored-by: Javier Viola <javier@parity.io>
Co-authored-by: Marcin S. <marcin@realemail.net>
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
Co-authored-by: Javier Bullrich <javier@bullrich.dev>
Co-authored-by: Koute <koute@users.noreply.github.com>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: Vladimir Istyufeev <vladimir@parity.io>
Co-authored-by: Ross Bulat <ross@parity.io>
Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com>
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: s0me0ne-unkn0wn <48632512+s0me0ne-unkn0wn@users.noreply.github.com>
Co-authored-by: ordian <write@reusable.software>
Co-authored-by: Sebastian Kunert <skunert49@gmail.com>
Co-authored-by: Aaro Altonen <48052676+altonen@users.noreply.github.com>
Co-authored-by: Dmitry Markin <dmitry@markin.tech>
Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Co-authored-by: Julian Eager <eagr@tutanota.com>
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
Co-authored-by: Davide Galassi <davxy@datawok.net>
Co-authored-by: Dónal Murray <donal.murray@parity.io>
Co-authored-by: yjh <yjh465402634@gmail.com>
Co-authored-by: Tom Mi <tommi@niemi.lol>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Will | Paradox | ParaNodes.io <79228812+paradox-tt@users.noreply.github.com>
Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
Co-authored-by: Joshy Orndorff <git-user-email.h0ly5@simplelogin.com>
Co-authored-by: PG Herveou <pgherveou@gmail.com>
Co-authored-by: Alexander Theißen <alex.theissen@me.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Juan Girini <juangirini@gmail.com>
Co-authored-by: bader y <ibnbassem@gmail.com>
Co-authored-by: James Wilson <james@jsdw.me>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: asynchronous rob <rphmeier@gmail.com>
Co-authored-by: Parth <desaiparth08@gmail.com>
Co-authored-by: Andrew Jones <ascjones@gmail.com>
Co-authored-by: Jonathan Udd <jonathan@dwellir.com>
Co-authored-by: Serban Iorga <serban@parity.io>
Co-authored-by: Egor_P <egor@parity.io>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Evgeny Snitko <evgeny@parity.io>
Co-authored-by: Just van Stam <vstam1@users.noreply.github.com>
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
Co-authored-by: gupnik <nikhilgupta.iitk@gmail.com>
Co-authored-by: dzmitry-lahoda <dzmitry@lahoda.pro>
Co-authored-by: zhiqiangxu <652732310@qq.com>
Co-authored-by: Nazar Mokrynskyi <nazar@mokrynskyi.com>
Co-authored-by: Anwesh <anweshknayak@gmail.com>
Co-authored-by: cheme <emericchevalier.pro@gmail.com>
Co-authored-by: Sam Johnson <sam@durosoft.com>
Co-authored-by: kianenigma <kian@parity.io>
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com>
Co-authored-by: Muharem <ismailov.m.h@gmail.com>
Co-authored-by: joepetrowski <joe@parity.io>
Co-authored-by: Alexandru Gheorghe <49718502+alexggh@users.noreply.github.com>
Co-authored-by: Gabriel Facco de Arruda <arrudagates@gmail.com>
Co-authored-by: Squirrel <gilescope@gmail.com>
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
Co-authored-by: georgepisaltu <george.pisaltu@parity.io>
Co-authored-by: command-bot <>
This commit is contained in:
Gavin Wood
2024-03-04 20:12:43 +01:00
committed by GitHub
parent b0741d4f78
commit fd5f9292f5
349 changed files with 25581 additions and 17082 deletions
+200 -62
View File
@@ -2573,7 +2573,8 @@ pub(crate) mod tests {
use sp_blockchain::{lowest_common_ancestor, tree_route};
use sp_core::H256;
use sp_runtime::{
testing::{Block as RawBlock, ExtrinsicWrapper, Header},
generic::UncheckedExtrinsic,
testing::{Block as RawBlock, Header, MockCallU64},
traits::{BlakeTwo256, Hash},
ConsensusEngineId, StateVersion,
};
@@ -2581,7 +2582,8 @@ pub(crate) mod tests {
const CONS0_ENGINE_ID: ConsensusEngineId = *b"CON0";
const CONS1_ENGINE_ID: ConsensusEngineId = *b"CON1";
pub(crate) type Block = RawBlock<ExtrinsicWrapper<u64>>;
type UncheckedXt = UncheckedExtrinsic<u64, MockCallU64, (), ()>;
pub(crate) type Block = RawBlock<UncheckedXt>;
pub fn insert_header(
backend: &Backend<Block>,
@@ -2600,7 +2602,7 @@ pub(crate) mod tests {
parent_hash: H256,
_changes: Option<Vec<(Vec<u8>, Vec<u8>)>>,
extrinsics_root: H256,
body: Vec<ExtrinsicWrapper<u64>>,
body: Vec<UncheckedXt>,
transaction_index: Option<Vec<IndexOperation>>,
) -> Result<H256, sp_blockchain::Error> {
use sp_runtime::testing::Digest;
@@ -3414,7 +3416,7 @@ pub(crate) mod tests {
prev_hash,
None,
Default::default(),
vec![i.into()],
vec![UncheckedXt::new_transaction(i.into(), ())],
None,
)
.unwrap();
@@ -3436,11 +3438,20 @@ pub(crate) mod tests {
assert_eq!(None, bc.body(blocks[0]).unwrap());
assert_eq!(None, bc.body(blocks[1]).unwrap());
assert_eq!(None, bc.body(blocks[2]).unwrap());
assert_eq!(Some(vec![3.into()]), bc.body(blocks[3]).unwrap());
assert_eq!(Some(vec![4.into()]), bc.body(blocks[4]).unwrap());
assert_eq!(
Some(vec![UncheckedXt::new_transaction(3.into(), ())]),
bc.body(blocks[3]).unwrap()
);
assert_eq!(
Some(vec![UncheckedXt::new_transaction(4.into(), ())]),
bc.body(blocks[4]).unwrap()
);
} else {
for i in 0..5 {
assert_eq!(Some(vec![(i as u64).into()]), bc.body(blocks[i]).unwrap());
assert_eq!(
Some(vec![UncheckedXt::new_transaction((i as u64).into(), ())]),
bc.body(blocks[i]).unwrap()
);
}
}
}
@@ -3464,7 +3475,7 @@ pub(crate) mod tests {
prev_hash,
None,
Default::default(),
vec![i.into()],
vec![UncheckedXt::new_transaction(i.into(), ())],
None,
)
.unwrap();
@@ -3473,16 +3484,26 @@ pub(crate) mod tests {
}
// insert a fork at block 2
let fork_hash_root =
insert_block(&backend, 2, blocks[1], None, H256::random(), vec![2.into()], None)
.unwrap();
let fork_hash_root = insert_block(
&backend,
2,
blocks[1],
None,
H256::random(),
vec![UncheckedXt::new_transaction(2.into(), ())],
None,
)
.unwrap();
insert_block(
&backend,
3,
fork_hash_root,
None,
H256::random(),
vec![3.into(), 11.into()],
vec![
UncheckedXt::new_transaction(3.into(), ()),
UncheckedXt::new_transaction(11.into(), ()),
],
None,
)
.unwrap();
@@ -3492,7 +3513,10 @@ pub(crate) mod tests {
backend.commit_operation(op).unwrap();
let bc = backend.blockchain();
assert_eq!(Some(vec![2.into()]), bc.body(fork_hash_root).unwrap());
assert_eq!(
Some(vec![UncheckedXt::new_transaction(2.into(), ())]),
bc.body(fork_hash_root).unwrap()
);
for i in 1..5 {
let mut op = backend.begin_operation().unwrap();
@@ -3506,16 +3530,28 @@ pub(crate) mod tests {
assert_eq!(None, bc.body(blocks[1]).unwrap());
assert_eq!(None, bc.body(blocks[2]).unwrap());
assert_eq!(Some(vec![3.into()]), bc.body(blocks[3]).unwrap());
assert_eq!(Some(vec![4.into()]), bc.body(blocks[4]).unwrap());
assert_eq!(
Some(vec![UncheckedXt::new_transaction(3.into(), ())]),
bc.body(blocks[3]).unwrap()
);
assert_eq!(
Some(vec![UncheckedXt::new_transaction(4.into(), ())]),
bc.body(blocks[4]).unwrap()
);
} else {
for i in 0..5 {
assert_eq!(Some(vec![(i as u64).into()]), bc.body(blocks[i]).unwrap());
assert_eq!(
Some(vec![UncheckedXt::new_transaction((i as u64).into(), ())]),
bc.body(blocks[i]).unwrap()
);
}
}
if matches!(pruning, BlocksPruning::KeepAll) {
assert_eq!(Some(vec![2.into()]), bc.body(fork_hash_root).unwrap());
assert_eq!(
Some(vec![UncheckedXt::new_transaction(2.into(), ())]),
bc.body(fork_hash_root).unwrap()
);
} else {
assert_eq!(None, bc.body(fork_hash_root).unwrap());
}
@@ -3536,8 +3572,16 @@ pub(crate) mod tests {
let backend = Backend::<Block>::new_test_with_tx_storage(BlocksPruning::Some(10), 10);
let make_block = |index, parent, val: u64| {
insert_block(&backend, index, parent, None, H256::random(), vec![val.into()], None)
.unwrap()
insert_block(
&backend,
index,
parent,
None,
H256::random(),
vec![UncheckedXt::new_transaction(val.into(), ())],
None,
)
.unwrap()
};
let block_0 = make_block(0, Default::default(), 0x00);
@@ -3565,18 +3609,30 @@ pub(crate) mod tests {
let bc = backend.blockchain();
assert_eq!(None, bc.body(block_1b).unwrap());
assert_eq!(None, bc.body(block_2b).unwrap());
assert_eq!(Some(vec![0x00.into()]), bc.body(block_0).unwrap());
assert_eq!(Some(vec![0x1a.into()]), bc.body(block_1a).unwrap());
assert_eq!(Some(vec![0x2a.into()]), bc.body(block_2a).unwrap());
assert_eq!(Some(vec![0x3a.into()]), bc.body(block_3a).unwrap());
assert_eq!(
Some(vec![UncheckedXt::new_transaction(0x00.into(), ())]),
bc.body(block_0).unwrap()
);
assert_eq!(
Some(vec![UncheckedXt::new_transaction(0x1a.into(), ())]),
bc.body(block_1a).unwrap()
);
assert_eq!(
Some(vec![UncheckedXt::new_transaction(0x2a.into(), ())]),
bc.body(block_2a).unwrap()
);
assert_eq!(
Some(vec![UncheckedXt::new_transaction(0x3a.into(), ())]),
bc.body(block_3a).unwrap()
);
}
#[test]
fn indexed_data_block_body() {
let backend = Backend::<Block>::new_test_with_tx_storage(BlocksPruning::Some(1), 10);
let x0 = ExtrinsicWrapper::from(0u64).encode();
let x1 = ExtrinsicWrapper::from(1u64).encode();
let x0 = UncheckedXt::new_transaction(0.into(), ()).encode();
let x1 = UncheckedXt::new_transaction(1.into(), ()).encode();
let x0_hash = <HashingFor<Block> as sp_core::Hasher>::hash(&x0[1..]);
let x1_hash = <HashingFor<Block> as sp_core::Hasher>::hash(&x1[1..]);
let index = vec![
@@ -3597,7 +3653,10 @@ pub(crate) mod tests {
Default::default(),
None,
Default::default(),
vec![0u64.into(), 1u64.into()],
vec![
UncheckedXt::new_transaction(0.into(), ()),
UncheckedXt::new_transaction(1.into(), ()),
],
Some(index),
)
.unwrap();
@@ -3619,8 +3678,9 @@ pub(crate) mod tests {
fn index_invalid_size() {
let backend = Backend::<Block>::new_test_with_tx_storage(BlocksPruning::Some(1), 10);
let x0 = ExtrinsicWrapper::from(0u64).encode();
let x1 = ExtrinsicWrapper::from(1u64).encode();
let x0 = UncheckedXt::new_transaction(0.into(), ()).encode();
let x1 = UncheckedXt::new_transaction(1.into(), ()).encode();
let x0_hash = <HashingFor<Block> as sp_core::Hasher>::hash(&x0[..]);
let x1_hash = <HashingFor<Block> as sp_core::Hasher>::hash(&x1[..]);
let index = vec![
@@ -3641,7 +3701,10 @@ pub(crate) mod tests {
Default::default(),
None,
Default::default(),
vec![0u64.into(), 1u64.into()],
vec![
UncheckedXt::new_transaction(0.into(), ()),
UncheckedXt::new_transaction(1.into(), ()),
],
Some(index),
)
.unwrap();
@@ -3655,7 +3718,7 @@ pub(crate) mod tests {
let backend = Backend::<Block>::new_test_with_tx_storage(BlocksPruning::Some(2), 10);
let mut blocks = Vec::new();
let mut prev_hash = Default::default();
let x1 = ExtrinsicWrapper::from(0u64).encode();
let x1 = UncheckedXt::new_transaction(0.into(), ()).encode();
let x1_hash = <HashingFor<Block> as sp_core::Hasher>::hash(&x1[1..]);
for i in 0..10 {
let mut index = Vec::new();
@@ -3675,7 +3738,7 @@ pub(crate) mod tests {
prev_hash,
None,
Default::default(),
vec![i.into()],
vec![UncheckedXt::new_transaction(i.into(), ())],
Some(index),
)
.unwrap();
@@ -3709,7 +3772,7 @@ pub(crate) mod tests {
prev_hash,
None,
Default::default(),
vec![i.into()],
vec![UncheckedXt::new_transaction(i.into(), ())],
None,
)
.unwrap();
@@ -3724,7 +3787,7 @@ pub(crate) mod tests {
blocks[1],
None,
sp_core::H256::random(),
vec![i.into()],
vec![UncheckedXt::new_transaction(i.into(), ())],
None,
)
.unwrap();
@@ -3738,7 +3801,7 @@ pub(crate) mod tests {
blocks[0],
None,
sp_core::H256::random(),
vec![42.into()],
vec![UncheckedXt::new_transaction(42.into(), ())],
None,
)
.unwrap();
@@ -4211,7 +4274,7 @@ pub(crate) mod tests {
prev_hash,
None,
Default::default(),
vec![i.into()],
vec![UncheckedXt::new_transaction(i.into(), ())],
None,
)
.unwrap();
@@ -4226,7 +4289,10 @@ pub(crate) mod tests {
// Check that we can properly access values when there is reference count
// but no value.
assert_eq!(Some(vec![1.into()]), bc.body(blocks[1]).unwrap());
assert_eq!(
Some(vec![UncheckedXt::new_transaction(1.into(), ())]),
bc.body(blocks[1]).unwrap()
);
// Block 1 gets pinned three times
backend.pin_block(blocks[1]).unwrap();
@@ -4243,27 +4309,42 @@ pub(crate) mod tests {
// Block 0, 1, 2, 3 are pinned, so all values should be cached.
// Block 4 is inside the pruning window, its value is in db.
assert_eq!(Some(vec![0.into()]), bc.body(blocks[0]).unwrap());
assert_eq!(
Some(vec![UncheckedXt::new_transaction(0.into(), ())]),
bc.body(blocks[0]).unwrap()
);
assert_eq!(Some(vec![1.into()]), bc.body(blocks[1]).unwrap());
assert_eq!(
Some(vec![UncheckedXt::new_transaction(1.into(), ())]),
bc.body(blocks[1]).unwrap()
);
assert_eq!(
Some(Justifications::from(build_justification(1))),
bc.justifications(blocks[1]).unwrap()
);
assert_eq!(Some(vec![2.into()]), bc.body(blocks[2]).unwrap());
assert_eq!(
Some(vec![UncheckedXt::new_transaction(2.into(), ())]),
bc.body(blocks[2]).unwrap()
);
assert_eq!(
Some(Justifications::from(build_justification(2))),
bc.justifications(blocks[2]).unwrap()
);
assert_eq!(Some(vec![3.into()]), bc.body(blocks[3]).unwrap());
assert_eq!(
Some(vec![UncheckedXt::new_transaction(3.into(), ())]),
bc.body(blocks[3]).unwrap()
);
assert_eq!(
Some(Justifications::from(build_justification(3))),
bc.justifications(blocks[3]).unwrap()
);
assert_eq!(Some(vec![4.into()]), bc.body(blocks[4]).unwrap());
assert_eq!(
Some(vec![UncheckedXt::new_transaction(4.into(), ())]),
bc.body(blocks[4]).unwrap()
);
assert_eq!(
Some(Justifications::from(build_justification(4))),
bc.justifications(blocks[4]).unwrap()
@@ -4294,7 +4375,10 @@ pub(crate) mod tests {
assert!(bc.justifications(blocks[1]).unwrap().is_none());
// Block 4 is inside the pruning window and still kept
assert_eq!(Some(vec![4.into()]), bc.body(blocks[4]).unwrap());
assert_eq!(
Some(vec![UncheckedXt::new_transaction(4.into(), ())]),
bc.body(blocks[4]).unwrap()
);
assert_eq!(
Some(Justifications::from(build_justification(4))),
bc.justifications(blocks[4]).unwrap()
@@ -4302,9 +4386,16 @@ pub(crate) mod tests {
// Block tree:
// 0 -> 1 -> 2 -> 3 -> 4 -> 5
let hash =
insert_block(&backend, 5, prev_hash, None, Default::default(), vec![5.into()], None)
.unwrap();
let hash = insert_block(
&backend,
5,
prev_hash,
None,
Default::default(),
vec![UncheckedXt::new_transaction(5.into(), ())],
None,
)
.unwrap();
blocks.push(hash);
backend.pin_block(blocks[4]).unwrap();
@@ -4319,12 +4410,18 @@ pub(crate) mod tests {
assert!(bc.body(blocks[2]).unwrap().is_none());
assert!(bc.body(blocks[3]).unwrap().is_none());
assert_eq!(Some(vec![4.into()]), bc.body(blocks[4]).unwrap());
assert_eq!(
Some(vec![UncheckedXt::new_transaction(4.into(), ())]),
bc.body(blocks[4]).unwrap()
);
assert_eq!(
Some(Justifications::from(build_justification(4))),
bc.justifications(blocks[4]).unwrap()
);
assert_eq!(Some(vec![5.into()]), bc.body(blocks[5]).unwrap());
assert_eq!(
Some(vec![UncheckedXt::new_transaction(5.into(), ())]),
bc.body(blocks[5]).unwrap()
);
assert!(bc.header(blocks[5]).ok().flatten().is_some());
backend.unpin_block(blocks[4]);
@@ -4334,9 +4431,16 @@ pub(crate) mod tests {
// Append a justification to block 5.
backend.append_justification(blocks[5], ([0, 0, 0, 1], vec![42])).unwrap();
let hash =
insert_block(&backend, 6, blocks[5], None, Default::default(), vec![6.into()], None)
.unwrap();
let hash = insert_block(
&backend,
6,
blocks[5],
None,
Default::default(),
vec![UncheckedXt::new_transaction(6.into(), ())],
None,
)
.unwrap();
blocks.push(hash);
// Pin block 5 so it gets loaded into the cache on prune
@@ -4349,7 +4453,10 @@ pub(crate) mod tests {
op.mark_finalized(blocks[6], None).unwrap();
backend.commit_operation(op).unwrap();
assert_eq!(Some(vec![5.into()]), bc.body(blocks[5]).unwrap());
assert_eq!(
Some(vec![UncheckedXt::new_transaction(5.into(), ())]),
bc.body(blocks[5]).unwrap()
);
assert!(bc.header(blocks[5]).ok().flatten().is_some());
let mut expected = Justifications::from(build_justification(5));
expected.append(([0, 0, 0, 1], vec![42]));
@@ -4371,7 +4478,7 @@ pub(crate) mod tests {
prev_hash,
None,
Default::default(),
vec![i.into()],
vec![UncheckedXt::new_transaction(i.into(), ())],
None,
)
.unwrap();
@@ -4387,16 +4494,26 @@ pub(crate) mod tests {
// Block tree:
// 0 -> 1 -> 2 -> 3 -> 4
// \ -> 2 -> 3
let fork_hash_root =
insert_block(&backend, 2, blocks[1], None, H256::random(), vec![2.into()], None)
.unwrap();
let fork_hash_root = insert_block(
&backend,
2,
blocks[1],
None,
H256::random(),
vec![UncheckedXt::new_transaction(2.into(), ())],
None,
)
.unwrap();
let fork_hash_3 = insert_block(
&backend,
3,
fork_hash_root,
None,
H256::random(),
vec![3.into(), 11.into()],
vec![
UncheckedXt::new_transaction(3.into(), ()),
UncheckedXt::new_transaction(11.into(), ()),
],
None,
)
.unwrap();
@@ -4417,14 +4534,35 @@ pub(crate) mod tests {
}
let bc = backend.blockchain();
assert_eq!(Some(vec![0.into()]), bc.body(blocks[0]).unwrap());
assert_eq!(Some(vec![1.into()]), bc.body(blocks[1]).unwrap());
assert_eq!(Some(vec![2.into()]), bc.body(blocks[2]).unwrap());
assert_eq!(Some(vec![3.into()]), bc.body(blocks[3]).unwrap());
assert_eq!(Some(vec![4.into()]), bc.body(blocks[4]).unwrap());
assert_eq!(
Some(vec![UncheckedXt::new_transaction(0.into(), ())]),
bc.body(blocks[0]).unwrap()
);
assert_eq!(
Some(vec![UncheckedXt::new_transaction(1.into(), ())]),
bc.body(blocks[1]).unwrap()
);
assert_eq!(
Some(vec![UncheckedXt::new_transaction(2.into(), ())]),
bc.body(blocks[2]).unwrap()
);
assert_eq!(
Some(vec![UncheckedXt::new_transaction(3.into(), ())]),
bc.body(blocks[3]).unwrap()
);
assert_eq!(
Some(vec![UncheckedXt::new_transaction(4.into(), ())]),
bc.body(blocks[4]).unwrap()
);
// Check the fork hashes.
assert_eq!(None, bc.body(fork_hash_root).unwrap());
assert_eq!(Some(vec![3.into(), 11.into()]), bc.body(fork_hash_3).unwrap());
assert_eq!(
Some(vec![
UncheckedXt::new_transaction(3.into(), ()),
UncheckedXt::new_transaction(11.into(), ())
]),
bc.body(fork_hash_3).unwrap()
);
// Unpin all blocks, except the forked one.
for block in &blocks {
+8 -3
View File
@@ -582,14 +582,19 @@ impl<'a, 'b> codec::Input for JoinInput<'a, 'b> {
mod tests {
use super::*;
use codec::Input;
use sp_runtime::testing::{Block as RawBlock, ExtrinsicWrapper};
type Block = RawBlock<ExtrinsicWrapper<u32>>;
use sp_runtime::{
generic::UncheckedExtrinsic,
testing::{Block as RawBlock, MockCallU64},
};
pub type UncheckedXt = UncheckedExtrinsic<u64, MockCallU64, (), ()>;
type Block = RawBlock<UncheckedXt>;
#[cfg(feature = "rocksdb")]
#[test]
fn database_type_subdir_migration() {
use std::path::PathBuf;
type Block = RawBlock<ExtrinsicWrapper<u64>>;
type Block = RawBlock<UncheckedXt>;
fn check_dir_for_db_type(
db_type: DatabaseType,