Bastian Köcher
e2547f5064
Improve handling of unset StorageVersion ( #13417 )
...
* Improve handling of unset `StorageVersion`
When a user is forgetting to set the storage version in a pallet and calls
`current_storage_version` to compare it against the `on_chain_storage_version` it will now fail to
compile the code. Before the pallet macro just returned `StorageVersion::default()` for
`current_storage_version` leading to potential issues with migrations. Besides that it also checks
in `post_upgrade` that the pallet storage version was upgraded and thus, no migration was missed.
* Use correct `Cargo.lock`
* Fixes
* Fix test
* Update frame/support/test/tests/pallet.rs
* Ensure we don't set a storage version when the pallet is missing the attribute
* Fix merge conflict
* Update frame/support/procedural/src/pallet/expand/hooks.rs
Co-authored-by: Roman Useinov <roman.useinov@gmail.com >
* Update frame/support/procedural/src/pallet/expand/hooks.rs
Co-authored-by: Roman Useinov <roman.useinov@gmail.com >
* Fix compilation
* Do not run everything with `try-runtime`
* Fix test
* Apply suggestions from code review
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix `no-metadata-docs`
---------
Co-authored-by: Roman Useinov <roman.useinov@gmail.com >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: parity-processbot <>
2023-05-04 21:18:53 +02:00
Liam Aharon
9c53fd7299
fungible conformance tests: Inspect and Mutate ( #13852 )
...
* typo
* - create test files for each fungile trait
- begin implementing tests for the Inspect trait
* wrap inspect tests in a macro
* first run of mutate tests
* move test implementation out of ballances
* make tests more generic
* transfer tests
* combine inspect and mutate tests
* set balance failing tests
* can_deposit tests
* can_withdraw tests
* test reducible_balance
* remove balanced stub
* revert set_balance return val fix
* typo
* macro and dust trap tests
* disable test when it doesn't make sense
* remove debug comment
* reduce macro boilerplate
* improved var naming
* improve variable naming
* remove redundant comment
* remove placeholder tests
* remove placeholder tests
* simplify macro
* Update frame/balances/src/tests/fungible_conformance_tests.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* use Balance from T
* fix copyright
* add test doc comments
* improve test naming
* clippy
* fix rustdoc errors
* fix rustdoc
* improve macro
* improve variable naming
* remove redundant comment
* use path
---------
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
2023-05-05 02:21:40 +10:00
Davide Galassi
3a90728de0
Refinements to VRF types ( #14036 )
...
* Allow extra signing data
* Fix tests after renaming
* Rename VrfSecret/VrfVerifier to VrfSecret/VrfPublic
* Further encrapsulation of 'transcript' type to the sr25519 implementation
* Keystore sr25519 pre-output
* Leave additional custom input field hidden in the associated VrfInput type
* Fix test
* More ergonomic output_bytes
* Trigger pipeline
* Define a separated type for vrf signature data
* Fix docs
* Fix doc
* Remove annotation
* Directly use dleq_proove and dleq_verify in sr25519
* Trigger CI
* Remove cruft before merge
2023-05-04 15:41:59 +02:00
Arkadiy Paronyan
bfafbf7bac
Statement store ( #13701 )
...
* WIP Statement store
* Sync with networking changes in master
* WIP statement pallet
* Statement validation
* pallet tests
* Validation queue
* Store maintenance
* Basic statement refactoring + tests + docs
* Store metrics
* Store tests
* Store maintenance test
* cargo fmt
* Build fix
* OCW Api
* Offchain worker
* Enable host functions
* fmt
* Minor tweaks
* Fixed a warning
* Removed tracing
* Manual expiration
* Reworked constraint management
* Updated pallet constraint calculation
* Added small test
* Added remove function to the APIs
* Copy-paste spec into readme
* Comments
* Made the store optional
* Removed network protocol controller
* fmt
* Clippy fixes
* fmt
* fmt
* More clippy fixes
* More clippy fixes
* More clippy fixes
* Update client/statement-store/README.md
Co-authored-by: cheme <emericchevalier.pro@gmail.com >
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <git@kchr.de >
* Removed sstore from node-template
* Sort out data path
* Added offline check
* Removed dispatch_statement
* Renamed into_generic
* Fixed commit placement
* Use HashSet for tracking peers/statements
* fmt
* Use ExtendedHostFunctions
* Fixed benches
* Tweaks
* Apply suggestions from code review
Co-authored-by: cheme <emericchevalier.pro@gmail.com >
* Fixed priority mixup
* Rename
* newtypes for priorities
* Added MAX_TOPICS
* Fixed key filtering logic
* Remove empty entrie
* Removed prefix from signing
* More documentation
* fmt
* Moved store setup from sc-service to node
* Handle maintenance task in sc-statement-store
* Use statement iterator
* Renamed runtime API mod
* fmt
* Remove dump_encoded
* fmt
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <git@kchr.de >
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <git@kchr.de >
* Fixed build after applying review suggestions
* License exceptions
* fmt
* Store options
* Moved pallet consts to config trait
* Removed global priority
* Validate fields when decoding
* Limit validation channel size
* Made a comment into module doc
* Removed submit_encoded
---------
Co-authored-by: cheme <emericchevalier.pro@gmail.com >
Co-authored-by: Bastian Köcher <git@kchr.de >
2023-05-04 10:24:32 +00:00
juangirini
b8a01127d7
contracts: add events to ContractResult ( #13807 )
...
* contracts: add events to ContractResult
* contracts: add encoded events to ContractResult
* contracts: add generic Event to ContractResult
* contracts: test bare_call events
* contracts: update bare_call test name
* contracts: add better comments to dry run events
* contracts: fix pallet contracts primitives implementation
* contracts: add EventRecord generic to ContractInstantiateResult
* contracts: make event collection optional
* contracts: impreved notes on `collect_events`
* contracts: update benchmarking calls
* contracts: change bare_call and bare_instantiate to accept enums instead of bools
* contracts: add partial eq to new enums
* contracts: improve comments
* contracts: improve comments
* contracts: fix bare_call benchmarking
* contracts: fix bare call and instantiate in impl_runtime_apis
* contracts: add api versioning to new ContractsApi functions
* contracts: modify api versioning to new ContractsApi functions
* contracts: create new contracts api trait
* contracts: clean up code
* contracts: remove the contract results with events
* contracts: undo contracts api v3
* contracts: remove commented out code
* contracts: add new test bare call result does not return events
* contracts: add code review improvements
* contracts: remove type imports
* contracts: minor code review improvements
2023-05-03 13:45:04 +00:00
Bastian Köcher
13cab3a4b7
test-staking-e2e: Add to main Cargo.toml. ( #14062 )
...
This ensures that it is actually tested as part of the CI. There is also no need to have it separate.
2023-05-03 15:15:49 +02:00
Mira Ressel
793f04fc05
Bump clap to 4.2.5 ( #14061 )
...
Co-authored-by: parity-processbot <>
2023-05-02 17:54:18 +00:00
juangirini
5db4119f93
contracts: Make Origin information available ( #13708 )
...
* contracts: allow root calls
* contracts: update ContractOrigin
* contracts: test allow root calls
* contracts: rustfmt
* contracts: test root caller traps
* contracts: add Caller enum
* contracts: improve some comments
* contracts: improve some comments
* contracts: format code with +nightly
* contracts: fix failing tests
* contracts: improve charte instantiate call when root origin
* contract: refactor common, call and instantiate inputs
* contracts: fix some failing test
* contracts: trap caller when there is no account id
* Update frame/contracts/src/lib.rs
Co-authored-by: PG Herveou <pgherveou@gmail.com >
* Update frame/contracts/src/exec.rs
Co-authored-by: PG Herveou <pgherveou@gmail.com >
* contracts: make `into_deposit` return zero when the origin is root
* contracts: cargo fmt
* contracts: charging and terminating tests refactored
* contracts: improved errors
* contracts: refactor & merge ContractOrigin cand Caller enums
* Update frame/contracts/src/lib.rs
Co-authored-by: Sasha Gryaznov <hi@agryaznov.com >
* contracts: apply suggested pr changes
* contracts: rename Caller to Origin
* contracts: refactor run fn
* contracts: cr improvements
* contracts: allow root to use delegate call
* contracts: add caller_is_root weight
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts
* contracts: add caller_is_root benchmarking
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts
* contracts: add caller_is_root benchmarking
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts
* contracts: add some minor improvements
* contracts: make caller_is_root runtime fn unstable
* contracts: fix failing wasm test
* contracts: update benchmarking for origin_is_root
* contracts: improve seal_caller_is_root benchmarking
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts
* contracts: add small pr improvements
* contracts: fix broken tests after master merge
* contracts: acknowledge the default storage deposit limit
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts
* contracts: move origin to CommonInput
* contracts: add some extra tests
* contracts: move ensure origin logic inside invokable::run_guarded
* contracts: add minor improvements
* contracts: fix caller_is_root benchmarking
* contracts: improve function description
* Update frame/contracts/src/lib.rs
Co-authored-by: Sasha Gryaznov <hi@agryaznov.com >
* Update frame/contracts/src/lib.rs
Co-authored-by: Sasha Gryaznov <hi@agryaznov.com >
* Update frame/contracts/src/wasm/runtime.rs
Co-authored-by: Sasha Gryaznov <hi@agryaznov.com >
* contracts: improve function description
---------
Co-authored-by: parity-processbot <>
Co-authored-by: PG Herveou <pgherveou@gmail.com >
Co-authored-by: Sasha Gryaznov <hi@agryaznov.com >
2023-05-02 16:45:14 +00:00
Bastian Köcher
9a3555d2e2
Fix bags-list tests execution ( #14047 )
...
The `test` feature isn't propagated to dependencies in Rust, so we should just enable the method as
well for `std`.
2023-05-01 07:47:43 +00:00
PG Herveou
4df004d0d4
Contracts: runtime_call and storage_deposit ( #13990 )
...
* wip
* add comments
* fix comment
* comments
* comments
* PR comment
* field orders
* Update frame/contracts/src/tests.rs
* Update frame/contracts/fixtures/call_runtime_and_call.wat
Co-authored-by: Sasha Gryaznov <hi@agryaznov.com >
* Apply suggestions from code review
Co-authored-by: Sasha Gryaznov <hi@agryaznov.com >
* Apply suggestions from code review
Co-authored-by: Sasha Gryaznov <hi@agryaznov.com >
* Update frame/contracts/src/tests.rs
Co-authored-by: Sasha Gryaznov <hi@agryaznov.com >
* Validate fees of failed call
* Update frame/contracts/src/tests.rs
* Update frame/contracts/src/tests.rs
* Update frame/contracts/src/tests.rs
* bubble up refund error
* rename fixture file
---------
Co-authored-by: Sasha Gryaznov <hi@agryaznov.com >
Co-authored-by: parity-processbot <>
2023-04-29 16:07:55 +00:00
Oliver Tale-Yazdi
202836cb47
CI: Remove crate publish check ( #14044 )
...
* Fix frame-support feature
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Remove publishing script
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-04-29 03:34:05 +04:00
Gonçalo Pestana
82aa16315d
Implements try_state hook in elections and EPM pallets ( #13979 )
...
* Adds try_state hook to elections pallets
* Addresses PR review comments
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com >
* remove unecessary println
* ensures try-runtime does not mutate storage
* Addresses PR comments
* Fixes snapshot invariant checks; simplifies test infra
---------
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com >
Co-authored-by: parity-processbot <>
2023-04-27 18:45:43 +00:00
Oliver Tale-Yazdi
b5201fa0ec
FRAME: inherited call weight syntax ( #13932 )
...
* First approach on pallet::call_weight
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use attr on pallet::call instead
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Ui tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Rename to weight(prefix = ...))
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Simplify to #[pallet::call(weight(T))]
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add stray token error
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Cleanup
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Migrate remaining pallets
Using script from https://github.com/ggwpez/substrate-scripts/blob/e1b5ea5b5b4018867f3e869fce6f448b4ba9d71f/frame-code-migration/src/call_weight.rs
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Try to add some docs
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert "Migrate remaining pallets"
Lets do this as a follow-up, I dont want to bloat this small MR.
This reverts commit 331d4b42d72de1dacaed714d69166fa1bc9c92dd.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Renames
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Review fixes
Co-authored-by: Sam Johnson <sam@durosoft.com >
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Test weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update UI tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/support/procedural/src/pallet/parse/mod.rs
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com >
* Remove old code
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update docs
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: parity-processbot <>
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com >
2023-04-27 14:08:08 +00:00
Kian Paimani
2320bdd388
improve staking interface methods ( #14023 )
...
* improve staking interface methods
* fix
* fix
* fix build
* restart
* fix
---------
Co-authored-by: parity-processbot <>
2023-04-27 11:27:12 +00:00
PG Herveou
ac6e43e628
contracts Fix store-call test path ( #14028 )
2023-04-27 10:01:12 +00:00
Liam Aharon
be6b03738e
collective pallet: sort genesis members and enforce max len constraint ( #13988 )
...
* insert members in sorted order
* improve variable name
* enforce genesis members length constraint
2023-04-27 18:55:01 +10:00
PG Herveou
34780b1b2b
contracts Add storage_deposit test ( #14003 )
...
* contracts Add storage_deposit test
* fix comments
* PR comments
2023-04-27 08:23:01 +02:00
Gavin Wood
781ea7cbdc
Various minor fixes ( #13945 )
...
* Fix: Incorrect implementation of can_reserve check
* Fix: Incorrect migration of consumer counting for existing accounts with frozen amounts
* Fix: Inconsistent implementation between assets can_deposit and new_account
* Fixes
* Fixes
* Another fix
* Update tests.rs
* Update fungible_tests.rs
* Use `can_accrue_consumers` in the body of `can_inc_consumer`
---------
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: parity-processbot <>
2023-04-26 14:26:07 +00:00
Sasha Gryaznov
356b752d58
fix a test ( #14021 )
2023-04-26 13:46:44 +00:00
Sasha Gryaznov
60310de7d6
[contracts] Port host functions to Weight V2 and storage deposit limit ( #13565 )
...
* added [unstable][seal2] call()
* updated test to cover new seal_call proof_limit
* docs updated
* add [seal2][unstable] instantiate() and test
* add [seal2][unstable] weight_to_fee() + docs and test
* add [seal2][unstable] gas_left() + docs and test
* update benchmarks
* add DefaultDepositLimit to pallet Config
* specify deposit limit for nested call
add test for nested call deposit limit
save: separate deposit limit for nested calls
* specify deposit limit for nested instantiate
save: works with test
cleaned up debugging outputs
* update benchmarks
* added missing fixtures
* fix benches
* pass explicit deposit limit to storage bench
* explicit deposit limit for another set_storage bench
* add more deposit limit for storage benches
* moving to simplified benchmarks
* moved to simplified benchmarks
* fix seal_weight_to_fee bench
* fix seal_instantiate benchmark
* doc typo fix
* default dl for benchmarking
more dl for tests
dl for tests to max
deposit_limit fix in instantiate bench
fix instantiate bench
fix instantiate benchmark
fix instantiate bench again
remove dbg
fix seal bench again
fixing it still
seal_instantiate zero deposit
less runs to check if deposit enough
try
try 2
try 3
try 4
* max_runtime_mem to Schedule limits
* add default deposit limit fallback check to test
* weight params renaming
* fmt
* Update frame/contracts/src/benchmarking/mod.rs
Co-authored-by: PG Herveou <pgherveou@gmail.com >
* prettify inputs in tests
* typestate param refactored
---------
Co-authored-by: PG Herveou <pgherveou@gmail.com >
2023-04-26 11:27:13 +00:00
gupnik
6c8acaa5e2
Removes ReportsByKindIndex ( #13936 )
...
* Removes ReportsByKind
* Minor build fixes
* adds migration
* Addresses review comment
* Uses clear but weight check fails
* Uses unique
* Updates test to commit the change before migration
* Uses reads_writes
* ".git/.scripts/commands/fmt/fmt.sh"
* Fixes build
* Addresses review comments
* ".git/.scripts/commands/fmt/fmt.sh"
* fixes typo
---------
Co-authored-by: command-bot <>
2023-04-25 15:20:58 +00:00
Qinxuan Chen
b06748e2ab
frame-support: migrate some tests from decl_* macros to the new pallet macros ( #12401 )
...
* frame-support: migrate some tests from decl macros to new pallet attribute macros
* Remove useless type alias
* Remove useless type alias
* Work around for rust issue 52234
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use polkadot-compatible paste version
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix crate access and add tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Typo
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: parity-processbot <>
2023-04-25 11:58:21 +00:00
PG Herveou
c11cb1b274
contracts Add LOG_TARGET constant ( #14002 )
...
* contracts Add LOG_TARGET constant
* Update frame/contracts/src/lib.rs
Co-authored-by: Sasha Gryaznov <hi@agryaznov.com >
---------
Co-authored-by: Sasha Gryaznov <hi@agryaznov.com >
2023-04-25 11:46:20 +00:00
Bastian Köcher
fcfe769c6c
pallet-democracy: Do not request the proposal when scheduling ( #13827 )
...
The requesting of the proposal is actually done now in `pallet-scheduler`.
Fixes: https://github.com/paritytech/substrate/issues/13534
2023-04-25 09:21:54 +02:00
Bastian Köcher
3e02be440e
frame-support-procedural: Fix detection of the tuples feature ( #13996 )
...
We didn't had the tuples features declared for the `frame-support-procedural` crate and thus, it
could not properly detect that the feature was already enabled.
2023-04-24 20:23:26 +00:00
dependabot[bot]
801871afa1
Bump enumflags2 from 0.7.5 to 0.7.7 ( #13995 )
...
Bumps [enumflags2](https://github.com/meithecatte/enumflags2 ) from 0.7.5 to 0.7.7.
- [Release notes](https://github.com/meithecatte/enumflags2/releases )
- [Commits](https://github.com/meithecatte/enumflags2/compare/v0.7.5...v0.7.7 )
---
updated-dependencies:
- dependency-name: enumflags2
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-24 21:31:13 +02:00
Muharem Ismailov
97f4a09591
Vote locks for all reasons except RESERVE ( #13914 )
...
* Vote locks tip
* except reserve
* reason for delegate
* fix tests
---------
Co-authored-by: parity-processbot <>
2023-04-24 14:57:45 +00:00
gupnik
3688575fd0
Adds force_origin support ( #13845 )
...
* Adds force_origin support
* Moves a couple of tests to showcase v2 with force_origin
* Adds remaining tests
* adds documentation
* minor
* adds test for invalid origin
* ".git/.scripts/commands/fmt/fmt.sh"
* updates param to use MaxCalls
* Fixes compilation error
* Updates doc comment
* Fixes test outputs
* Fixes test output
* ".git/.scripts/commands/fmt/fmt.sh"
---------
Co-authored-by: command-bot <>
2023-04-24 17:34:15 +05:30
PG Herveou
0824b060b4
Update macro use and optimize storage collection ( #13970 )
2023-04-21 17:24:12 +02:00
Harald Heckmann
4411e8cec2
Add Freeze/Thaw events and tests ( #13779 )
...
* Add Freeze/Thaw events and tests
* Remove duplicate docstring
* Correct spelling error
* Cargo fmt
* Use proper punctuation in docstring
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
---------
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
Co-authored-by: parity-processbot <>
2023-04-21 12:06:26 +02:00
Liam Aharon
eb17581e3c
balances impl_currency WithdrawReasons note (#13964 )
...
* add withdrawreason note
* improve comment
* Update frame/balances/src/impl_currency.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* cargo fmt +nightly
---------
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
2023-04-21 18:46:54 +10:00
Jegor Sidorenko
7a1fc72a4a
[NFTs] Improve offchain signature validation ( #13960 )
...
* Improve signature validation
* Rework
2023-04-20 12:38:45 +00:00
Muharem Ismailov
f8b77f64f3
Collective pallet: max proposal weight ( #13771 )
...
* collective: max proposal weight
* fix test
---------
Co-authored-by: parity-processbot <>
2023-04-19 11:00:27 +00:00
gupnik
e458bf3795
Adds example for dev_mode and updates doc ( #13944 )
...
* Adds example for dev_mode and updates doc
* Addresses review comments
* Update frame/examples/dev-mode/src/lib.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Addresses review comment
---------
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
2023-04-19 16:24:19 +05:30
Davide Galassi
bb394e08ac
VRF refactory ( #13889 )
...
* First iteration to encapsulate schnorrkel and merlin usage
* Remove schnorkel direct dependency from BABE pallet
* Remove schnorrkel direct dependency from BABE client
* Trivial renaming for VrfTranscript data and value
* Better errors
* Expose a function to get a schnorrkel friendly transcript
* Keep the vrf signature stuff together (preventing some clones around)
* Fix tests
* Remove vrf agnostic transcript and define it as an associated type for VrfSigner and VrfVerifier
* Fix babe pallet mock
* Inner types are required to be public for polkadot
* Update client/consensus/babe/src/verification.rs
Co-authored-by: Koute <koute@users.noreply.github.com >
* Nit
* Remove Deref implementations
* make_bytes as a method
* Trigger CI
---------
Co-authored-by: Koute <koute@users.noreply.github.com >
2023-04-19 09:11:47 +00:00
William Freudenberger
9eb63f216c
feat: pallet asset-rate ( #13608 )
...
* poc
* fix: remove AssetIdParameter
* tests: add
* docs: add pallet description
* feat: add benches
* refactor: UnknownAssetId
* fix: normalize mock cfg
* fix: benchmarks
* chore: add weights
* refactor: remove storage getter
* chore: apply suggestions from code review
* docs: add native balance to calls
* chore: apply suggestions from code review
* chore: apply ConversionFromAssetBalance
* tests: update balance mock
* chore: apply suggestions from code review
* ci: set publish to false
* docs: fix missing rustdoc
---------
Co-authored-by: parity-processbot <>
2023-04-19 07:49:42 +00:00
yjh
cbc8e5f7df
chore(docs): improve some comments ( #13937 )
...
* chore(docs): improve some comments
* Update client/network/common/src/sync/message.rs
Co-authored-by: Koute <koute@users.noreply.github.com >
* Update client/rpc-api/src/chain/mod.rs
Co-authored-by: Koute <koute@users.noreply.github.com >
* Update client/rpc/src/chain/mod.rs
Co-authored-by: Koute <koute@users.noreply.github.com >
* Update client/rpc/src/chain/mod.rs
Co-authored-by: Koute <koute@users.noreply.github.com >
* Update frame/staking/src/pallet/impls.rs
Co-authored-by: Koute <koute@users.noreply.github.com >
---------
Co-authored-by: Koute <koute@users.noreply.github.com >
2023-04-18 17:46:46 +02:00
Gavin Wood
d23a251ee9
Balances: repatriate_reserved should respect freezes ( #13885 )
...
* repatriate_reserved should respect freezes
* Docs
* Fix and clean
* Formatting
* Update frame/balances/src/types.rs
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
* Fix
* Simplify
* Fixes
* Fixes
---------
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com >
2023-04-17 19:13:55 +01:00
Przemek Rzad
b66bc22252
Update links in the Referenda Readme ( #13929 )
...
* Update links in the Referenda Readme
* Update frame/referenda/README.md
---------
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-04-17 10:22:59 +00:00
Sergej Sakac
afbdfbca2a
Try-state for Collective pallet ( #13645 )
...
* write the try_state_ function
* update tests
* update check
* fix benchmarking
* fix nonsense
* Update frame/collective/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update frame/collective/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* unique proposal index
* prime must be a member of the collective
* oops
* Add new checks
* use ensure
* fix
---------
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-04-17 15:43:13 +10:00
Roman Useinov
5cecb888b2
[Fix] Remove redundant stash from Stake ( #13907 )
...
* [Fix] Remove redundant stash from Stake
* fix tests
2023-04-16 00:25:56 +02:00
gupnik
cd1e51a4e7
Updates Benchmark macro parsing to use Generic Argument ( #13919 )
...
* WIP
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Removes POC code
* Adds assertion and UT
* adds runtime error
* removes const_assert
* ".git/.scripts/commands/fmt/fmt.sh"
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: command-bot <>
2023-04-14 22:54:26 +05:30
Oliver Tale-Yazdi
4175ed6a87
Update proc-macro-warning ( #13876 )
...
* Update proc-macro-warning
Closes https://github.com/paritytech/substrate/issues/13872
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update to v0.3.1 (including syn 2.0)
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Revert "Update to v0.3.1 (including syn 2.0)"
CI is red since it Polkadot uses a different syn version…
Going to update it lean.
This reverts commit 3240d379b72f6f722eaf502ed49e9a1b0f79db4b.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-04-13 22:44:46 +02:00
Sasha Gryaznov
3c1fb62621
stabilize call_runtime ( #13901 )
2023-04-13 13:57:28 +00:00
Oliver Tale-Yazdi
ebfe00d590
Fixes PoV over-estimation ( #13766 )
...
* Align log
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Use max instead of sum
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Make comment ordering deterministic
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Dont add Pov overhead when all is ignored
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update test pallet weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Re-run weights on bm2
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix test
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Actually use new weights
Fucked up the merge for this file...
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Update contract weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2023-04-13 13:11:58 +00:00
dependabot[bot]
929a510108
Bump zstd from 0.11.2+zstd.1.5.2 to 0.12.3+zstd.1.5.2 ( #13671 )
...
Bumps [zstd](https://github.com/gyscos/zstd-rs ) from 0.11.2+zstd.1.5.2 to 0.12.3+zstd.1.5.2.
- [Release notes](https://github.com/gyscos/zstd-rs/releases )
- [Commits](https://github.com/gyscos/zstd-rs/commits )
---
updated-dependencies:
- dependency-name: zstd
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-12 22:50:31 +00:00
Sam Johnson
b83bf4784e
Globally upgrade to syn 2.x and latest quote and proc_macro2 1x versions ( #13846 )
...
* globally upgrade quote to latest 1.0.x (1.0.26)
* globally upgrade syn to final 1.0.x version (1.0.109)
* globally upgrade proc-macro2 to 1.0.56
* upgrade to syn v2.0.13 and fix everything except NestedMeta
* fix parse nested metadata code in decl_runtime_apis.rs
* Port more stuff to syn 2.0
* Make the rest compile
* Ignore error
* update to syn 2.0.14
---------
Co-authored-by: Bastian Köcher <info@kchr.de >
2023-04-12 18:42:22 +00:00
PG Herveou
03c99fe003
contracts: add sr25519_verify ( #13724 )
...
* wip
* fix
* wip
* fix lint
* rm fixture fix
* missing comment
* fix lint
* add comment to the wsm file
* fix comment
* Apply suggestions from code review
Co-authored-by: Sasha Gryaznov <hi@agryaznov.com >
* wip
* wip weights
* wip weights
* PR comment: test with return code
* wip
* PR review add mock test
* remove
* lint
* Update frame/contracts/fixtures/sr25519_verify.wat
* fix comments
* Update frame/contracts/src/benchmarking/mod.rs
* Update frame/contracts/src/wasm/runtime.rs
* Update frame/contracts/fixtures/sr25519_verify.wat
* Update frame/contracts/src/benchmarking/mod.rs
* fix lint
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts
* Update frame/contracts/src/wasm/runtime.rs
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
* PR: review use unstable + remove arbitrary index 4
* Add benchmark for calculating overhead of calling sr25519_verify
* fix message length encoding
* fix weights
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts
* Apply suggestions from code review
* Update frame/contracts/src/wasm/runtime.rs
* Update frame/contracts/src/wasm/runtime.rs
* Update frame/contracts/src/benchmarking/mod.rs
* Update frame/contracts/src/benchmarking/mod.rs
* Update frame/contracts/src/schedule.rs
Co-authored-by: Sasha Gryaznov <hi@agryaznov.com >
* Update frame/contracts/src/schedule.rs
Co-authored-by: Sasha Gryaznov <hi@agryaznov.com >
* Update frame/contracts/src/wasm/runtime.rs
* Update frame/contracts/src/wasm/runtime.rs
Co-authored-by: Sasha Gryaznov <hi@agryaznov.com >
* PR review
---------
Co-authored-by: Sasha Gryaznov <hi@agryaznov.com >
Co-authored-by: command-bot <>
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
2023-04-12 14:49:10 +00:00
Roman Useinov
376a288fb6
[Deps] Bump scale-info to match cumulus and polkadot ( #13873 )
...
* [Deps] Bump scale-info to match cumulus and polkadot
* fix Cargo.lock
* fix identity
* more fixes
* fix
* fixes
* more fixes
2023-04-12 14:14:06 +02:00
gupnik
6669c8ae37
Fixes error message when _ is used without dev mode ( #13886 )
...
* Initial changes
* Adds UI test for error when _ is used without dev_mode
* Minor
* ".git/.scripts/commands/fmt/fmt.sh"
* Adds test to verify hasher
* Fixes error message when _ is used without dev mode
* Updates test
* Addresses review comment
---------
Co-authored-by: command-bot <>
2023-04-12 13:56:40 +05:30