85bf52342f
Fix priority thresholds ( #5375 )
...
Fix for the priorities shown in the release notes
2022-04-22 15:25:49 +02:00
a5742b9ec1
Extract peers grid topology related code to a separate unit ( #5365 )
...
* Initial attempt to extract grid topology related code
* Use shared code in the approval distribution subsystem
* Fix spellcheck issues
* Moe Aggression stuff back to the approval-distribution subsystem
* Cargo fmt
2022-04-22 11:19:36 +01:00
bb3cc7b041
update weights ( #5361 )
...
* polkadot: update weights
* kusama: update weights
* rococo: update weights
* westend: update weights
2022-04-22 09:26:19 +00:00
42cbfba5d3
Companion to Proportional Slashing: Substrate #10982 ( #5306 )
...
* Companion to Proportional Slashing
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
2022-04-22 00:14:28 +00:00
3f0e73d320
Add some additional logging to availability recovery subsystem ( #5345 )
2022-04-21 18:15:02 +01:00
fc4b04db20
Prepare for network protocol version upgrades ( #5084 )
...
* explicitly tag network requests with version
* fmt
* make PeerSet more aware of versioning
* some generalization of the network bridge to support upgrades
* walk back some renaming
* walk back some version stuff
* extract version from fallback
* remove V1 from NetworkBridgeUpdate
* add accidentally-removed timer
* implement focusing for versioned messages
* fmt
* fix up network bridge & tests
* remove inaccurate version check in bridge
* remove some TODO [now]s
* fix fallout in statement distribution
* fmt
* fallout in gossip-support
* fix fallout in collator-protocol
* fix fallout in bitfield-distribution
* fix fallout in approval-distribution
* fmt
* use never!
* fmt
2022-04-21 16:34:59 +00:00
203441981f
Use EXTRA_DEPENDENCIES for pipeline-scripts ( #5328 )
...
* temporary: check if it works
* EXTRA_DEPENDENCIES for pipeline-scripts
* revert pipeline scripts source
2022-04-21 17:46:14 +02:00
ba052ca6a7
Bump clap from 3.1.9 to 3.1.10 ( #5355 )
...
Bumps [clap](https://github.com/clap-rs/clap ) from 3.1.9 to 3.1.10.
- [Release notes](https://github.com/clap-rs/clap/releases )
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md )
- [Commits](https://github.com/clap-rs/clap/compare/v3.1.9...v3.1.10 )
---
updated-dependencies:
- dependency-name: clap
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-21 10:11:22 +02:00
efe74e4336
Companion to Substrate #11002 ( #5309 )
...
* Add SignedMaxRefunds
* Update Cargo.lock
* update lockfile for {"substrate"}
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
Co-authored-by: parity-processbot <>
2022-04-21 00:01:17 +02:00
e460465515
Companion to Split SolutionImprovementThresholds into two types ( #5324 )
...
* Splitting `SolutionImprovementThreshold` in 2.
One for Signed phase, and one for Unsgined.
* Adding missing imports
* Removing `GetDefault`, renaming trait
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
2022-04-20 15:54:25 -04:00
2284a85aa3
remove FixCouncilDeposit migration ( #5341 )
...
* remove FixCouncilDeposit migration
* fixup
2022-04-20 09:29:22 +02:00
bcebd39e47
[ci] benchmarks: suppress wrong exit code ( #5344 )
...
* [ci] benchmarks: suppress wrong exit code
The script uses '!' to prevent set -e failures,
however a $? of `0` becomes exit code 1 if it is the last command ran.
This `true` makes sure that $? is 0 when we reach the end,
instead of carrying over a failure which would otherwise cause
the whole CI job to abort.
* add explanation comment
2022-04-20 09:04:46 +02:00
07d2985f82
Bump trybuild from 1.0.53 to 1.0.60 ( #5343 )
...
Bumps [trybuild](https://github.com/dtolnay/trybuild ) from 1.0.53 to 1.0.60.
- [Release notes](https://github.com/dtolnay/trybuild/releases )
- [Commits](https://github.com/dtolnay/trybuild/compare/1.0.53...1.0.60 )
---
updated-dependencies:
- dependency-name: trybuild
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-19 21:11:39 +02:00
79ecc53801
Reduce network bandwidth, improve parablock times: optimize approval-distribution ( #5164 )
...
* gossip-support: be explicit about dimensions
* some guide updates
* update network-bridge to distinguish x and y dimensions
* get everything to compile
* beginnings
* some TODOs
* polkadot runtime: use relevant_authorities
* make gossip topologies per-session
* better formatting
* gossip support: use current session validators
* expand in comment
* adjust tests and fix index bug
* add past/present/future connection test and clean up code
* fmt
* network bridge: updated types
* update protocols to new gossip topology message
* guide updates
* add session to BlockApprovalMeta
* add session to block info
* refactor knowledge and remove most unify logic
* start replacing gossip_peers with new SessionTopologies
* add routing information to message state
* add some utilities to SessionTopology
* implement new gossip topology logic
* re-implement unify_with_peer
* distribute assignments according to topology
* finish grid topology implementation
* refactor network bridge slightly
* issue connection requests on all past/present/future
* fmt
* address grumbles
* tighten invariants in unify_with_peer
* implement random propagation
* refactor: extract required routing adjustment logic
* some block-age logic
* aggressively propagate messages when finality is slow
* overhaul aggression system to have 3 levels
* add aggression metrics
* remove aggression L3
* reduce random circulation
* remove PeerData
* get approval tests compiling
* use btree_map in known_by to make deterministic
* Revert "use btree_map in known_by to make deterministic"
This reverts commit 330d65343a7bb6fe4dd0f24bd8dbc15c0cbdbd9d.
* test XY grid propagation
* remove stray println
* test unshared dimension propagation
* add random gossip check
* test unify_with_peer better
* test sending after getting gossip topology
* test L1 aggression on originator
* test L1 aggression for non-originators
* test non-originator aggression L2
* fnt
* ~spellcheck
* fix statement-distribution tests
* fix flaky test
* fix metrics typo
* re-send periodically
* test resending
* typo
Co-authored-by: Bernhard Schuster <bernhard@ahoi.io >
* add more metrics about apd messages
* add back unify_with_peer logs
* make Resend an enum
* be more explicit when resending
* fmt
* fix error
* add a TODO for refactoring
* remove debug metrics
* add some guide stuff
* fmt
* update runtime API in test-runtim
Co-authored-by: Bernhard Schuster <bernhard@ahoi.io >
2022-04-19 20:26:55 +02:00
edfa24bbc5
flatten dispute-coordinator 'real' module. ( #5254 )
...
* flatton dispute-coordinator 'real' module,
* Drop obsolete modules.
Co-authored-by: Robert Klotzner <robert.klotzner@gmx.at >
2022-04-19 18:14:50 +00:00
f820db494f
dispute-coordinator: Cleanup + Bug fixes ( #5323 )
...
* Make import confirmation oneshot optional.
* Cleanup for further improvements.
* Queue adoptions.
* Fix fieldname
* Use correct relay parent
* Fix scraper tests.
* Small optimization.
* Fix all tests.
* Fix other tests.
* fmt
* spelling
* Fix warning.
2022-04-19 14:51:02 +02:00
b3540e76e3
Bump clap from 3.1.8 to 3.1.9 ( #5335 )
...
Bumps [clap](https://github.com/clap-rs/clap ) from 3.1.8 to 3.1.9.
- [Release notes](https://github.com/clap-rs/clap/releases )
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md )
- [Commits](https://github.com/clap-rs/clap/compare/v3.1.8...v3.1.9 )
---
updated-dependencies:
- dependency-name: clap
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-18 23:01:47 +02:00
6b9bdbe1c2
Bump parity-db from 0.3.9 to 0.3.11 ( #5261 )
...
Bumps [parity-db](https://github.com/paritytech/parity-db ) from 0.3.9 to 0.3.11.
- [Release notes](https://github.com/paritytech/parity-db/releases )
- [Commits](https://github.com/paritytech/parity-db/commits/v0.3.11 )
---
updated-dependencies:
- dependency-name: parity-db
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-18 22:55:18 +02:00
42cc18a80c
Bump tracing from 0.1.33 to 0.1.34 ( #5329 )
...
Bumps [tracing](https://github.com/tokio-rs/tracing ) from 0.1.33 to 0.1.34.
- [Release notes](https://github.com/tokio-rs/tracing/releases )
- [Commits](https://github.com/tokio-rs/tracing/compare/tracing-0.1.33...tracing-0.1.34 )
---
updated-dependencies:
- dependency-name: tracing
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-18 22:54:17 +02:00
286fedf04a
Make debug builds more useful & testing faster. ( #4807 )
...
* Make debug builds more useful & testing likely faster.
Stolen from substrate.
* Add some more packages from
https://github.com/paritytech/polkadot/pull/3344/files
* Fix compilation.
2022-04-16 13:42:33 +02:00
8c3dbe0cfc
Co #11198 : Expose benchmark machine command ( #5326 )
...
* Expose benchmark machine command
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* error.into
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* update lockfile for {"substrate"}
* Revert "update lockfile for {"substrate"}"
This reverts commit 41c2ddda511076567a98c85efa631374071c9e5a.
* cargo update -p sp-io
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: parity-processbot <>
2022-04-15 18:46:36 +02:00
a74c527d32
Companion for Adding benchmarking for new frame_election_provider_support #11149 ( #5241 )
...
* `GenesisElectionOf` after changes to substrate
* Benchmarking for `frame_election_provider_support`
* Introducing `OnChainSeqPhragmen` after changes
to substrate.
Pallet renaming in substrate
* Fixing `test-runtime`
* Use `UnboundedExecution` after change to substrate
* update lockfile for {"substrate"}
* cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark pallet --chain=polkadot-dev --steps=50 --repeat=20 --pallet=frame_election_provider_support --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/
* cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark pallet --chain=kusama-dev --steps=50 --repeat=20 --pallet=frame_election_provider_support --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/
* cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark pallet --chain=westend-dev --steps=50 --repeat=20 --pallet=frame_election_provider_support --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/
Co-authored-by: parity-processbot <>
Co-authored-by: Parity Bot <admin@parity.io >
2022-04-15 17:17:38 +02:00
e3326d26b3
Bump scale-info from 2.0.1 to 2.1.1 ( #5325 )
...
Bumps [scale-info](https://github.com/paritytech/scale-info ) from 2.0.1 to 2.1.1.
- [Release notes](https://github.com/paritytech/scale-info/releases )
- [Changelog](https://github.com/paritytech/scale-info/blob/master/CHANGELOG.md )
- [Commits](https://github.com/paritytech/scale-info/commits/v2.1.1 )
---
updated-dependencies:
- dependency-name: scale-info
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-15 08:16:50 +02:00
b9e0e1493f
Bump quote from 1.0.17 to 1.0.18 ( #5301 )
...
Bumps [quote](https://github.com/dtolnay/quote ) from 1.0.17 to 1.0.18.
- [Release notes](https://github.com/dtolnay/quote/releases )
- [Commits](https://github.com/dtolnay/quote/compare/1.0.17...1.0.18 )
---
updated-dependencies:
- dependency-name: quote
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-14 20:55:58 +02:00
2f01960eb2
Update zstd dependency ( #5148 )
...
* Update zstd dependency
* Update Cargo.lock
Co-authored-by: Bastian Köcher <info@kchr.de >
2022-04-14 15:54:27 +02:00
3f56e1ff55
Add XCM Benchmarks to Kusama ( #4442 )
...
* add xcm benchmarks to kusama
* Create temp
* cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::generic --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/kusama/src/weights/xcm/pallet_xcm_benchmarks_generic.rs
* cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::fungible --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/kusama/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs
* add weights to kusama runtime
* Fixes
* Fixes
* Fixes
* Fixes
* cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::fungible --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/kusama/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs
* cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::generic --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/kusama/src/weights/xcm/pallet_xcm_benchmarks_generic.rs
* use new benchmark
* Fix license year
* update substrate deps
* Add Configuration::ActiveConfig storage key to the whitelist
* Update Cargo.lock
Co-authored-by: Parity Bot <admin@parity.io >
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com >
2022-04-14 10:50:06 +02:00
cddd5749d3
Malus: improvements in dispute ancestor and suggest garbage candidate implementation ( #5011 )
...
* Implement fake validation results
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* refactor
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* cargo lock
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* spell check
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* spellcheck
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* typos
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Review feedback
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* move stuff around
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* chores
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Impl valid - still wip
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fixes
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fmt
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Pull Ladi's implementation:
https://github.com/paritytech/polkadot/pull/4711
Co-authored-by: Lldenaurois <Ljdenaurois@gmail.com >
Co-authored-by: Andrei Sandu <andrei-mihail@parity.io >
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Fix build
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Logs and comments
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* WIP: suggest garbage candidate + implement validation result caching
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Do commitment hash checks in candidate validation
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Minor refactor in approval, backing, dispute-coord
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Working version of suggest garbage candidate
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Dedup
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* cleanup #1
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Fix tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* remove debug leftovers
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fmt
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Accidentally commited some local test
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* spellcheck
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* some more fixes
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Refactor and fix it
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* review feedback
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* typo
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* tests review feedback
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* refactor disputer
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Fix zombienet disputes test
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* spellcheck
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Fix ui tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix typo
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
Co-authored-by: Lldenaurois <Ljdenaurois@gmail.com >
2022-04-13 13:45:39 +00:00
a46237cebb
Add mmr_root() to pallet-mmr API to expose root from state (companion for substrate#11183) ( #5276 )
...
* Add mmr_root() to pallet-mmr API to expose root from state
* use the right MmrApi primitives
* bridges: use correct mmr primitives
* rococo: beefy-mmr deposit mmr root digest
* fix lockfile
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
2022-04-13 10:55:18 +00:00
ff18cabbc5
remove old pallet migrations ( #5194 )
...
* remove old pallet migrations
* remove more stuff
2022-04-13 10:01:57 +00:00
c8423f5175
Bump tracing from 0.1.32 to 0.1.33 ( #5299 )
...
Bumps [tracing](https://github.com/tokio-rs/tracing ) from 0.1.32 to 0.1.33.
- [Release notes](https://github.com/tokio-rs/tracing/releases )
- [Commits](https://github.com/tokio-rs/tracing/compare/tracing-0.1.32...tracing-0.1.33 )
---
updated-dependencies:
- dependency-name: tracing
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-12 22:45:21 +02:00
fd020c07e5
Add staging runtime api ( #5048 )
...
* Move `trait ParachainHost` to a separate version independent module
`trait ParachainHost` is no longer part of a specific primitives
version. Instead there is a single trait for stable and staging api
versions. The trait contains stable AND staging methods. The latter are
explicitly marked as unstable.
* Fix `use` primitives
`polkadot_primitives::v2` becomes `polkadot_primitives::runtime_api`
* Staging API declaration and stubs
Introduces the concept for 'staging functions' in runtime API. These
functions are still in testing and they are meant to be used only
within test networks (Westend).
They coexist with the stable calls for technical reasons - maintaining
different runtime APIs for different networks is hard to implement.
Check the doc comments in source files for more details how the staging
API should be used.
* Add new staging method - get_session_disputes()
Add `staging_get_session_disputes` to `ParachainHost` as the first
method of the staging API.
* Hide vstaging runtime api implementations behind feature flag
* Fix test runtime
* fn staging_get_session_disputes() is renamed to fn staging_get_disputes()
2022-04-12 15:47:46 +00:00
04f5a15be4
CI: rename ambiguous jobs ( #5313 )
2022-04-12 15:53:13 +02:00
905ec74f6a
Prepare for rust 1.60 ( #5282 )
...
* Prepare for rust 1.60
* change ci image to staging
* empty commit for pipeline rerun
* ci image production
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com >
Co-authored-by: alvicsam <alvicsam@gmail.com >
2022-04-11 11:31:39 +02:00
3fef84a69a
Bump proc-macro2 from 1.0.36 to 1.0.37 ( #5265 )
...
Bumps [proc-macro2](https://github.com/dtolnay/proc-macro2 ) from 1.0.36 to 1.0.37.
- [Release notes](https://github.com/dtolnay/proc-macro2/releases )
- [Commits](https://github.com/dtolnay/proc-macro2/compare/1.0.36...1.0.37 )
---
updated-dependencies:
- dependency-name: proc-macro2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-09 23:44:41 +02:00
b89dc00ec0
Fixes the dead lock when any of the channels get at capacity. ( #5297 )
...
The PVF host is designed to avoid spawning tasks to minimize knowledge
of outer code. Using `async_std::task::spawn` (or Tokio's counterpart)
deemed unacceptable, `SpawnNamed` undesirable. Instead there is only one
task returned that is spawned by the candidate-validation subsystem.
The tasks from the sub-components are polled by that root task.
However, the way the tasks are bundled was incorrect. There was a giant
select that was polling those tasks. Particularly, that implies that as soon as
one of the arms of that select goes into await those sub-tasks stop
getting polled. This is a recipe for a deadlock which indeed happened
here.
Specifically, the deadlock happened during sending messages to the
execute queue by calling
[`send_execute`](https://github.com/paritytech/polkadot/blob/a68d9be35656dcd96e378fd9dd3d613af754d48a/node/core/pvf/src/host.rs#L601 ).
When the channel to the queue reaches the capacity, the control flow is
suspended until the queue handles those messages. Since this code is
essentially reached from [one of the select
arms](https://github.com/paritytech/polkadot/blob/a68d9be35656dcd96e378fd9dd3d613af754d48a/node/core/pvf/src/host.rs#L371 ),
the queue won't be given the control and thus no further progress can be
made.
This problem is solved by bundling the tasks one level higher instead,
by `selecting` over those long-running tasks.
We also stop treating returning from those long-running tasks as error
conditions, since that can happen during legit shutdown.
2022-04-09 10:57:34 +00:00
a68d9be356
Bump syn from 1.0.90 to 1.0.91 ( #5273 )
...
Bumps [syn](https://github.com/dtolnay/syn ) from 1.0.90 to 1.0.91.
- [Release notes](https://github.com/dtolnay/syn/releases )
- [Commits](https://github.com/dtolnay/syn/compare/1.0.90...1.0.91 )
---
updated-dependencies:
- dependency-name: syn
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-08 19:56:15 +02:00
c8eb992cfd
create .github/workflows/pr-custom-review.yml ( #5280 )
2022-04-08 17:39:29 +02:00
11fc94176d
[ci] fix pallet benchmark script ( #5247 ) ( #5292 )
2022-04-08 14:50:10 +02:00
2cc30515d8
bump spec_version to 9190 ( #5291 )
2022-04-08 11:48:52 +00:00
7ed275bff8
bump version to 0.9.19 ( #5290 )
2022-04-08 11:48:43 +00:00
243c855f03
Session is actually ancient not unknown. ( #5286 )
2022-04-08 13:04:59 +02:00
6608975861
[ci] point benchmark script to sub-commands ( #5247 ) ( #5289 )
2022-04-08 12:13:58 +02:00
d56c5f86ef
Remove Travis CI ( #5287 )
2022-04-08 12:41:56 +03:00
ef4e64c641
Improve error handling in approval voting block import ( #5283 )
...
* Print out original the runtime API error
* Improved error handling in approval voting block import
* Fix test
* Update comment
2022-04-08 10:26:38 +02:00
ecd42d5408
fix .github/pr-custom-review.yml ( #5279 )
2022-04-08 10:52:00 +03:00
08163de073
Co #11164 : Sub-commands for benchmark ( #5247 )
...
* Restructure benchmark commands
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add benchmark storage test
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* cargo update -p sp-io
* Revert "cargo update -p sp-io"
This reverts commit c321b570cef806934acfb7e1a18f543a681b9927.
* cargo update -p sp-io
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* update lockfile for {"substrate"}
* remove `useless_attribute`
* Remove rococo-native cfg
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Make cumulus build
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix benchmark commands for the CI
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Make cumulus build
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Make cumulus build
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Disable new bench commands for rococo
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Make cumulus build
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
Co-authored-by: parity-processbot <>
2022-04-07 22:29:16 +00:00
7b58f85a2b
Bump clap from 3.1.6 to 3.1.8 ( #5240 )
...
Bumps [clap](https://github.com/clap-rs/clap ) from 3.1.6 to 3.1.8.
- [Release notes](https://github.com/clap-rs/clap/releases )
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md )
- [Commits](https://github.com/clap-rs/clap/compare/v3.1.6...v3.1.8 )
---
updated-dependencies:
- dependency-name: clap
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-07 22:06:30 +02:00
4d837bac88
Custom Slots Migration for Fund Index Change ( #5227 )
...
* new migration
* use new migration in runtime
2022-04-07 10:51:37 -04:00
8db1b341e5
create pr-custom-review.yml ( #5253 )
...
syntax in accordance to https://github.com/paritytech/pr-custom-review/tree/5814820aa0e5d35412f31dc02f9d130a8b138cae#configuration-syntax
rules in accordance to https://github.com/paritytech/pr-custom-review/blob/da1d81b9fd39705cc8b37f59235283801c818708/rules.md
2022-04-07 16:23:08 +02:00
2433de588a
Replace TransactionByteFee with LengthToFee ( #5028 )
...
* Replace TransactionByteFee with LengthToFee
* s/ConstantModifierFee/ConstantMultiplier/
* fmt
* Remove duplicate import
* fmt
* Update runtime/test-runtime/src/lib.rs
* update lockfile for {"substrate"}
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
Co-authored-by: parity-processbot <>
2022-04-07 13:13:32 +00:00
Chevdor