Commit Graph

7 Commits

Author SHA1 Message Date
Demi M. Obenour 06aa7e2d3b Make the Signer impl require Send + Sync
This is what Ledgeracio needs.
2020-05-29 19:41:12 -04:00
Demi M. Obenour ba4f90cb24 Merge branch 'master' into staking
Also implement Signer for Box<dyn Signer>
2020-05-29 18:42:12 -04:00
Demi Obenour a2eead0c3d Make signing fallable and asynchronous (#119)
* Make signing fallable and asynchronous

This is needed for hardware wallets, which require human confirmation to
sign transactions.  Blocking on a human to sign transactions is not a
good idea, and the signing might fail for many reasons (device
unplugged, authorization not granted, etc).

* Reformat

* Refactor as suggested by Andrew Jones (@ascjones).

* Use future::ok

Co-authored-by: Andrew Jones <ascjones@gmail.com>
2020-05-29 08:49:27 +01:00
Demi M. Obenour e3e30cf7bb Trait cleanups 2020-05-28 20:50:20 -04:00
Demi M. Obenour c4942c45a8 Reformat 2020-05-28 12:34:08 -04:00
Demi M. Obenour 193104c5e9 Make signing fallable and asynchronous
This is needed for hardware wallets, which require human confirmation to
sign transactions.  Blocking on a human to sign transactions is not a
good idea, and the signing might fail for many reasons (device
unplugged, authorization not granted, etc).
2020-05-27 21:55:07 -04:00
David Craven 67f3ce529e Refactors the api (#113)
* Refactor api.

* Try fix ci.

* Fix test.

* Address review comments.
2020-05-26 10:04:44 +01:00