c261353380
Make rolling session more resilient in case of long finality stalls ( #6106 )
...
* Impl dynamic window size. Keep sessions for unfinalized chain
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* feedback
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Stretch also in contructor plus tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* review feedback
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix approval-voting tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* grunting: dispute coordinator tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* add session window column
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* integrate approval vote and fix tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix rolling session tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Small refactor
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* WIP, tests failing
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Fix approval voting tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix dispute-coordinator tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* remove uneeded param
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fmt
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix loose ends
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* allow failure and tests for it
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix comment
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* comment fix
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* style fix
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* new col doesn't need to be ordered
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fmt and spellcheck
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* db persist tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Add v2 config and cols
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* DB upgrade WIP
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Fix comments
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* add todo
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* update to parity-db to "0.4.2"
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* migration complete
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* One session window size
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix merge damage
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix build errors
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fmt
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* comment fix
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix build
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* make error more explicit
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* add comment
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* refactor conflict merge
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* rename col_data
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* add doc comment
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix build
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* migration: move all cols to v2
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
2022-11-08 18:16:31 +01:00
351d37e324
Check if approval voting db is empty on startup ( #6219 )
...
* Add approval voting db sanity check
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* add newline back
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* no need for overlay to read
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
2022-10-31 20:57:50 +01:00
8eb1f4617f
Use a more typesafe approach for managing indexed data ( #6150 )
...
* Fix for issue #2403
* Nightly fmt
* Quick documentation fixes
* Default Implementation
* iter() function integrated
* Implemented iter functionalities
* Fmt
* small change
* updates node-network
* updates in dispute-coordinator
* Updates
* benchmarking fix
* minor fix
* test fixes in runtime api
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* Removal of [index], shorting of FromIterator, Renaming of GroupValidators to ValidatorGroups
* Removal of ops import
* documentation fixes for spell check
* implementation of generic type
* Refactoring
* Test and documentation fixes
* minor test fix
* minor test fix
* minor test fix
* Update node/network/statement-distribution/src/lib.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* removed IterMut
* Update node/core/dispute-coordinator/src/import.rs
Co-authored-by: Andronik <write@reusable.software >
* Update node/core/dispute-coordinator/src/initialized.rs
Co-authored-by: Andronik <write@reusable.software >
* Update primitives/src/v2/mod.rs
Co-authored-by: Andronik <write@reusable.software >
* fmt
* IterMut
* documentation update
Co-authored-by: Andronik <write@reusable.software >
* minor adjustments and new TypeIndex trait
* spelling fix
* TypeIndex fix
Co-authored-by: Andronik <write@reusable.software >
2022-10-22 08:39:11 +00:00
f8cc39a761
sync versions with current release (0.9.31) ( #6176 )
...
* Bump spec_version to 9310
* bump transaction_version (0.9.31) (#6171 )
* Bump transaction_version for polkadot
* Bump transaction_version for kusama
* Bump transaction_version for rococo
* Bump transaction_version for westend
* Bump transaction_version for polkadot
* Bump transaction_version for kusama
* Bump transaction_version for rococo
* Bump transaction_version for westend
* Bump crate versions (0.9.31)
2022-10-22 00:08:53 -04:00
af6a5cd96a
update kvdb & co ( #6111 )
...
* toml changes
* REVERTME: patch
* adapt parachains db interface
* fix Cargo.toml patch after master rebase
* fix av-store
* fix chain-selection
* fix parachains-db?
* Revert "fix Cargo.toml patch after master rebase"
This reverts commit 3afcbf033c86027b3f2b909d83ec703591bdd287.
* Revert "REVERTME: patch"
This reverts commit 464b717cf4142d3d09c3d77b83700b632d8c5f54.
* Use `Ok` imported from prelude
Co-authored-by: Bastian Köcher <info@kchr.de >
* update lockfile for {"substrate"}
* Revert "update lockfile for {"substrate"}"
This reverts commit fdc623de226f7645741b86c4b1a7d030fed2172d.
* cargo update -p sp-io
Co-authored-by: Bastian Köcher <info@kchr.de >
Co-authored-by: parity-processbot <>
2022-10-05 22:36:51 +00:00
a64cc4a860
Bump lru from 0.7.8 to 0.8.0 ( #6060 )
...
* Bump lru from 0.7.8 to 0.8.0
Bumps [lru](https://github.com/jeromefroe/lru-rs ) from 0.7.8 to 0.8.0.
- [Release notes](https://github.com/jeromefroe/lru-rs/releases )
- [Changelog](https://github.com/jeromefroe/lru-rs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jeromefroe/lru-rs/compare/0.7.8...0.8.0 )
---
updated-dependencies:
- dependency-name: lru
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
* Change `LruCache` paramerter to `NonZeroUsize`
* Change type of `session_cache_lru_size` to `NonZeroUsize`
* Add expects instead of unwrap
Co-authored-by: Bastian Köcher <info@kchr.de >
* Use match to get rid of expects
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sebastian Kunert <skunert49@gmail.com >
Co-authored-by: Bastian Köcher <info@kchr.de >
2022-10-04 11:28:21 +00:00
7114a8cfca
Keep sessions in window for the full unfinalized chain ( #6054 )
...
* Impl dynamic window size. Keep sessions for unfinalized chain
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* feedback
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Stretch also in contructor plus tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* review feedback
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix approval-voting tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* grunting: dispute coordinator tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
2022-10-04 13:36:42 +03:00
1acc3fa150
Sync versions with current release (v0.9.29) ( #5982 )
...
* Bump transaction_version for westend
* Bump transaction_version for rococo
* Bump transaction_version for kusama
* Bump transaction_version for polkadot
* Bump spec_version to 9290
* Bump crate versions
2022-09-09 11:24:06 +00:00
fc97080cb2
version bumps (0.9.28) ( #5933 )
...
* Bump crate versions
* Bump spec_version to 9280 for kusama
* Bump spec_version to 9280 for polkadot
* Bump spec_version to 9280 for rococo
* Bump spec_version to 9280 for westend
* update Cargo.lock
Co-authored-by: parity-processbot <>
2022-08-29 18:01:58 +02:00
427e7c1ab3
Bump async-trait from 0.1.56 to 0.1.57 ( #5919 )
...
Bumps [async-trait](https://github.com/dtolnay/async-trait ) from 0.1.56 to 0.1.57.
- [Release notes](https://github.com/dtolnay/async-trait/releases )
- [Commits](https://github.com/dtolnay/async-trait/compare/0.1.56...0.1.57 )
---
updated-dependencies:
- dependency-name: async-trait
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-08-24 21:13:45 +00:00
c83eaa2475
Send back empty votes + log in approval-voting in case candidate entry is missing. ( #5925 )
...
* Send back empty votes + log.
* Update node/core/approval-voting/src/lib.rs
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com >
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com >
2022-08-24 15:44:13 +00:00
ca6297c853
Reduce dispute coordinator load ( #5785 )
...
* Don't import backing statements directly
into the dispute coordinator. This also gets rid of a redundant
signature check. Both should have some impact on backing performance.
In general this PR should make us scale better in the number of parachains.
Reasoning (aka why this is fine):
For the signature check: As mentioned, it is a redundant check. The
signature has already been checked at this point. This is even made
obvious by the used types. The smart constructor is not perfect as
discussed [here](https://github.com/paritytech/polkadot/issues/3455 ),
but is still a reasonable security.
For not importing to the dispute-coordinator: This should be good as the
dispute coordinator does scrape backing votes from chain. This suffices
in practice as a super majority of validators must have seen a backing
fork in order for a candidate to get included and only included
candidates pose a threat to our system. The import from chain is
preferable over direct import of backing votes for two reasons:
1. The import is batched, greatly improving import performance. All
backing votes for a candidate are imported with a single import.
And indeed we were able to see in metrics that importing votes
from chain is fast.
2. We do less work in general as not every candidate for which
statements are gossiped might actually make it on a chain. The
dispute coordinator as with the current implementation would still
import and keep those votes around for six sessions.
While redundancy is good for reliability in the event of bugs, this also
comes at a non negligible cost. The dispute-coordinator right now is the
subsystem with the highest load, despite the fact that it should not be
doing much during mormal operation and it is only getting worse
with more parachains as the load is a direct function of the number of statements.
We'll see on Versi how much of a performance improvement this PR
* Get rid of dead code.
* Dont send approval vote
* Make it pass CI
* Bring back tests for fixing them later.
* Explicit signature check.
* Resurrect approval-voting tests (not fixed yet)
* Send out approval votes in dispute-distribution.
Use BTreeMap for ordered dispute votes.
* Bring back an important warning.
* Fix approval voting tests.
* Don't send out dispute message on import + test
+ Some cleanup.
* Guide changes.
Note that the introduced complexity is actually redundant.
* WIP: guide changes.
* Finish guide changes about dispute-coordinator
conceputally. Requires more proof read still.
Also removed obsolete implementation details, where the code is better
suited as the source of truth.
* Finish guide changes for now.
* Remove own approval vote import logic.
* Implement logic for retrieving approval-votes
into approval-voting and approval-distribution subsystems.
* Update roadmap/implementers-guide/src/node/disputes/dispute-coordinator.md
Co-authored-by: asynchronous rob <rphmeier@gmail.com >
* Review feedback.
In particular: Add note about disputes of non included candidates.
* Incorporate Review Remarks
* Get rid of superfluous space.
* Tidy up import logic a bit.
Logical vote import is now separated, making the code more readable and
maintainable.
Also: Accept import if there is at least one invalid signer that has not
exceeded its spam slots, instead of requiring all of them to not exceed
their limits. This is more correct and a preparation for vote batching.
* We don't need/have empty imports.
* Fix tests and bugs.
* Remove error prone redundancy.
* Import approval votes on dispute initiated/concluded.
* Add test for approval vote import.
* Make guide checker happy (hopefully)
* Another sanity check + better logs.
* Reasoning about boundedness.
* Use `CandidateIndex` as opposed to `CoreIndex`.
* Remove redundant import.
* Review remarks.
* Add metric for calls to request signatures
* More review remarks.
* Add metric on imported approval votes.
* Include candidate hash in logs.
* More trace log
* Break cycle.
* Add some tracing.
* Cleanup allowed messages.
* fmt
* Tracing + timeout for get inherent data.
* Better error.
* Break cycle in all places.
* Clarified comment some more.
* Typo.
* Break cycle approval-distribution - approval-voting.
Co-authored-by: asynchronous rob <rphmeier@gmail.com >
2022-08-16 08:16:30 +02:00
f1dce2f548
Trivial networking changes for Substrate PR #11940 ( #5841 )
...
* Trivial networking changes for Substrate PR https://github.com/paritytech/substrate/pull/11940
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
2022-08-09 19:37:31 +00:00
85dabbd850
Backport crate version bumps to 0.9.27 ( #5826 )
...
* Bump crate versions
* Update cargo.lock
2022-07-28 10:03:27 +00:00
72bde2889f
Introduce async runtime calling trait for runtime-api subsystem ( #5782 )
...
* Implement OverseerRuntimeClient
* blockchainevents
* Update patches
* Finish merging rntime-api subsystem
* First version that is able to produce blocks
* Make OverseerRuntimeClient async
* Move overseer notification stream forwarding to cumulus
* Remove unused imports
* Add more logging to collator-protocol
* Lockfile
* Use hashes in OverseerRuntimeClient
* Move OverseerRuntimeClient into extra module
* Fix old session info call and make HeadSupportsParachain async
* Improve naming of trait
* Cleanup
* Remove unused From trait implementation
* Remove unwanted debug print
* Move trait to polkadot-node-subsystem-types
* Add sections to runtime client
Co-authored-by: Davide Galassi <davxy@datawok.net >
* Reorder methods
* Fix spelling
* Fix spacing in Cargo.toml
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Remove unused babe methods
Co-authored-by: Davide Galassi <davxy@datawok.net >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2022-07-20 10:23:25 +00:00
9fc4e16eff
Version bump to v0.9.26/9260 ( #5755 )
...
* Bump spec_version to 9260
* Version bump to v0.9.26
2022-07-06 10:31:45 +00:00
09b10fa25e
Bump parity-scale-codec from 3.1.2 to 3.1.5 ( #5720 )
...
Bumps [parity-scale-codec](https://github.com/paritytech/parity-scale-codec ) from 3.1.2 to 3.1.5.
- [Release notes](https://github.com/paritytech/parity-scale-codec/releases )
- [Changelog](https://github.com/paritytech/parity-scale-codec/blob/master/CHANGELOG.md )
- [Commits](https://github.com/paritytech/parity-scale-codec/compare/parity-scale-codec-3.1.2...parity-scale-codec-3.1.5 )
---
updated-dependencies:
- dependency-name: parity-scale-codec
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-27 10:27:49 +00:00
97f9b840e4
bump versions to 0.9.25 ( #5684 )
...
* kusama: bump spec_version to 9250
* polkadot: bump spec_version to 9250
* rococo: bump spec_version to 9250
* westend: bump spec_version to 9250
* bump version to 0.9.25
* bump transaction version (polkadot & kusama) (#5690 )
* kusama: bump transaction_version to 12
* polkadot: bump transaction_version to 13
2022-06-21 13:02:04 +00:00
13900dfeea
Improve forceApprove logging ( #5595 )
...
* Add some meaningful logging to the force approval to understand why it fails
* Add original block into the log to simplify logs lurking
* Update node/core/approval-voting/src/import.rs
Co-authored-by: asynchronous rob <rphmeier@gmail.com >
Co-authored-by: asynchronous rob <rphmeier@gmail.com >
2022-05-27 09:32:24 +00:00
7eba8f2162
bump to 0.9.23 ( #5593 )
...
* bump version to 0.9.23
* bump spec_version to 9230
2022-05-27 10:18:23 +02:00
450ca2baca
overseer becomes orchestra ( #5542 )
...
* rename overseer-gen to orchestra
Also drop `gum` and use `tracing`.
* make orchestra compile as standalone
* introduce Spawner trait to split from sp_core
Finalizes the independence of orchestra from polkadot-overseer
* slip of the pen
* other fixins
* remove unused import
* Update node/overseer/orchestra/proc-macro/src/impl_builder.rs
Co-authored-by: Vsevolod Stakhov <vsevolod.stakhov@parity.io >
* Update node/overseer/orchestra/proc-macro/src/impl_builder.rs
Co-authored-by: Vsevolod Stakhov <vsevolod.stakhov@parity.io >
* orchestra everywhere
* leaky data
* Bump scale-info from 2.1.1 to 2.1.2 (#5552 )
Bumps [scale-info](https://github.com/paritytech/scale-info ) from 2.1.1 to 2.1.2.
- [Release notes](https://github.com/paritytech/scale-info/releases )
- [Changelog](https://github.com/paritytech/scale-info/blob/master/CHANGELOG.md )
- [Commits](https://github.com/paritytech/scale-info/compare/v2.1.1...v2.1.2 )
---
updated-dependencies:
- dependency-name: scale-info
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add missing markdown code block delimiter (#5555 )
* bitfield-signing: remove util::jobs usage (#5523 )
* Switch to pooling copy-on-write instantiation strategy for WASM (companion for Substrate#11232) (#5337 )
* Switch to pooling copy-on-write instantiation strategy for WASM
* Fix compilation of `polkadot-test-service`
* Update comments
* Move `max_memory_size` to `Semantics`
* Rename `WasmInstantiationStrategy` to `WasmtimeInstantiationStrategy`
* Update a safety comment
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* Fix build
Co-authored-by: Vsevolod Stakhov <vsevolod.stakhov@parity.io >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Malte Kliemann <mail@maltekliemann.com >
Co-authored-by: Chris Sosnin <48099298+slumber@users.noreply.github.com >
Co-authored-by: Koute <koute@users.noreply.github.com >
2022-05-19 13:42:02 +01:00
3b685fbf91
version bumps (0.9.22) ( #5495 )
...
* bump versions to 0.9.22
* bump spec_version to 9220
2022-05-16 13:24:24 +02:00
511891dcce
refactor+feat: allow subsystems to send only declared messages, generate graphviz ( #5314 )
...
Closes #3774
Closes #3826
2022-05-12 17:39:05 +02:00
26340b9054
more ParaId::from uses ( #5514 )
2022-05-12 16:46:19 +02:00
8837dc7e6f
Revert approval voting ( #5438 )
...
* Revert approval-voting subsystem
* Approval voting revert encapsulated within 'ops' module
* use 'get_stored_blocks' to get lower block height
* Fix error message
* Optionally shrink/delete stored blocks range
* range end number is last block number plus 1
* Apply code review suggestions
* Use tristate enum for block range in backend overlay
* Add clarification comment
* Add comments to private struct
2022-05-11 10:28:16 +02:00
bd5db20e7c
Bump thiserror from 1.0.30 to 1.0.31 ( #5439 )
...
Bumps [thiserror](https://github.com/dtolnay/thiserror ) from 1.0.30 to 1.0.31.
- [Release notes](https://github.com/dtolnay/thiserror/releases )
- [Commits](https://github.com/dtolnay/thiserror/compare/1.0.30...1.0.31 )
---
updated-dependencies:
- dependency-name: thiserror
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-04 13:53:53 +00:00
69af87a199
more verbose assignment cert errors ( #5433 )
...
* more verbose assignment cert errors
* rename a variant to InvalidAssignmentKey
2022-05-04 14:45:11 +02:00
79ecc53801
Reduce network bandwidth, improve parablock times: optimize approval-distribution ( #5164 )
...
* gossip-support: be explicit about dimensions
* some guide updates
* update network-bridge to distinguish x and y dimensions
* get everything to compile
* beginnings
* some TODOs
* polkadot runtime: use relevant_authorities
* make gossip topologies per-session
* better formatting
* gossip support: use current session validators
* expand in comment
* adjust tests and fix index bug
* add past/present/future connection test and clean up code
* fmt
* network bridge: updated types
* update protocols to new gossip topology message
* guide updates
* add session to BlockApprovalMeta
* add session to block info
* refactor knowledge and remove most unify logic
* start replacing gossip_peers with new SessionTopologies
* add routing information to message state
* add some utilities to SessionTopology
* implement new gossip topology logic
* re-implement unify_with_peer
* distribute assignments according to topology
* finish grid topology implementation
* refactor network bridge slightly
* issue connection requests on all past/present/future
* fmt
* address grumbles
* tighten invariants in unify_with_peer
* implement random propagation
* refactor: extract required routing adjustment logic
* some block-age logic
* aggressively propagate messages when finality is slow
* overhaul aggression system to have 3 levels
* add aggression metrics
* remove aggression L3
* reduce random circulation
* remove PeerData
* get approval tests compiling
* use btree_map in known_by to make deterministic
* Revert "use btree_map in known_by to make deterministic"
This reverts commit 330d65343a7bb6fe4dd0f24bd8dbc15c0cbdbd9d.
* test XY grid propagation
* remove stray println
* test unshared dimension propagation
* add random gossip check
* test unify_with_peer better
* test sending after getting gossip topology
* test L1 aggression on originator
* test L1 aggression for non-originators
* test non-originator aggression L2
* fnt
* ~spellcheck
* fix statement-distribution tests
* fix flaky test
* fix metrics typo
* re-send periodically
* test resending
* typo
Co-authored-by: Bernhard Schuster <bernhard@ahoi.io >
* add more metrics about apd messages
* add back unify_with_peer logs
* make Resend an enum
* be more explicit when resending
* fmt
* fix error
* add a TODO for refactoring
* remove debug metrics
* add some guide stuff
* fmt
* update runtime API in test-runtim
Co-authored-by: Bernhard Schuster <bernhard@ahoi.io >
2022-04-19 20:26:55 +02:00
f820db494f
dispute-coordinator: Cleanup + Bug fixes ( #5323 )
...
* Make import confirmation oneshot optional.
* Cleanup for further improvements.
* Queue adoptions.
* Fix fieldname
* Use correct relay parent
* Fix scraper tests.
* Small optimization.
* Fix all tests.
* Fix other tests.
* fmt
* spelling
* Fix warning.
2022-04-19 14:51:02 +02:00
cddd5749d3
Malus: improvements in dispute ancestor and suggest garbage candidate implementation ( #5011 )
...
* Implement fake validation results
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* refactor
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* cargo lock
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* spell check
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* spellcheck
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* typos
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Review feedback
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* move stuff around
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* chores
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Impl valid - still wip
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fixes
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fmt
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Pull Ladi's implementation:
https://github.com/paritytech/polkadot/pull/4711
Co-authored-by: Lldenaurois <Ljdenaurois@gmail.com >
Co-authored-by: Andrei Sandu <andrei-mihail@parity.io >
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Fix build
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Logs and comments
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* WIP: suggest garbage candidate + implement validation result caching
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Do commitment hash checks in candidate validation
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Minor refactor in approval, backing, dispute-coord
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Working version of suggest garbage candidate
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Dedup
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* cleanup #1
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Fix tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* remove debug leftovers
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fmt
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Accidentally commited some local test
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* spellcheck
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* some more fixes
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Refactor and fix it
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* review feedback
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* typo
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* tests review feedback
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* refactor disputer
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Fix zombienet disputes test
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* spellcheck
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* Fix ui tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
* fix typo
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io >
Co-authored-by: Lldenaurois <Ljdenaurois@gmail.com >
2022-04-13 13:45:39 +00:00
7ed275bff8
bump version to 0.9.19 ( #5290 )
2022-04-08 11:48:43 +00:00
243c855f03
Session is actually ancient not unknown. ( #5286 )
2022-04-08 13:04:59 +02:00
ef4e64c641
Improve error handling in approval voting block import ( #5283 )
...
* Print out original the runtime API error
* Improved error handling in approval voting block import
* Fix test
* Update comment
2022-04-08 10:26:38 +02:00
74078d8eb9
Comanion for substrate#11136 ( #5218 )
...
* Comanion for substrate#11136
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* revert changes in bridge
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
2022-04-04 11:13:34 +02:00
52912ab392
fix approval-voting force-approve ( #5229 )
2022-03-31 21:12:38 +00:00
91e07d53ad
Extract MAX_FINALITY_LAG constant from relay_chain_selection ( #5159 )
...
* Fix for Issue #4788
* Updated fix. Moved constant to node primitives
* cargo fmt
* Update node/primitives/src/lib.rs
Co-authored-by: Andronik <write@reusable.software >
* Update node/core/dispute-coordinator/src/real/initialized.rs
Co-authored-by: Andronik <write@reusable.software >
2022-03-23 15:34:41 +01:00
3688e46d1b
Don't wait for dispute coordinator ( #5157 )
...
* Don't wait for dispute coordinator
in backing and approval-voting - we are single threaded there, so this
is blocking everything.
* Add missing import.
* Don't warn on dropped receiver.
2022-03-18 15:15:50 +00:00
61a6004cf1
Bump parity-scale-codec from 3.1.0 to 3.1.2 ( #5153 )
...
Bumps [parity-scale-codec](https://github.com/paritytech/parity-scale-codec ) from 3.1.0 to 3.1.2.
- [Release notes](https://github.com/paritytech/parity-scale-codec/releases )
- [Changelog](https://github.com/paritytech/parity-scale-codec/blob/master/CHANGELOG.md )
- [Commits](https://github.com/paritytech/parity-scale-codec/commits )
---
updated-dependencies:
- dependency-name: parity-scale-codec
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-18 10:32:49 +00:00
d631f1dea8
observability: tracing gum, automatically cross ref traceID ( #5079 )
...
* add some gum
* bump expander
* gum
* fix all remaining issues
* last fixup
* Update node/gum/proc-macro/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* change
* netowrk
* fixins
* chore
* allow optional fmt str + args, prep for expr as kv field
* tracing -> gum rename fallout
* restrict further
* allow multiple levels of field accesses
* another round of docs and a slip of the pen
* update ADR
* fixup lock fiel
* use target: instead of target=
* minors
* fix
* chore
* Update node/gum/README.md
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com >
2022-03-15 11:05:16 +00:00
3335ddc0da
Bump parity-scale-codec from 3.0.0 to 3.1.0 ( #5096 )
...
Bumps [parity-scale-codec](https://github.com/paritytech/parity-scale-codec ) from 3.0.0 to 3.1.0.
- [Release notes](https://github.com/paritytech/parity-scale-codec/releases )
- [Changelog](https://github.com/paritytech/parity-scale-codec/blob/master/CHANGELOG.md )
- [Commits](https://github.com/paritytech/parity-scale-codec/compare/v3.0...parity-scale-codec-v3.1.0 )
---
updated-dependencies:
- dependency-name: parity-scale-codec
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-14 19:34:46 +01:00
6fc2da146f
Bump all spec version to 9180 and versions to 0.9.18 ( #5083 )
...
* bump all spec version to 9180 and versions to 0.9.18
* all to 0.9.18
* lock update
2022-03-11 10:19:47 +01:00
a863bfe69d
Bump tracing from 0.1.31 to 0.1.32 ( #5075 )
...
Bumps [tracing](https://github.com/tokio-rs/tracing ) from 0.1.31 to 0.1.32.
- [Release notes](https://github.com/tokio-rs/tracing/releases )
- [Commits](https://github.com/tokio-rs/tracing/compare/tracing-0.1.31...tracing-0.1.32 )
---
updated-dependencies:
- dependency-name: tracing
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-10 09:45:57 +00:00
49f7e5cce4
Finish migration to v2 primitives ( #5037 )
...
* remove v0 primitives from polkadot-primitives
* first pass: remove v0
* fix fallout in erasure-coding
* remove v1 primitives, consolidate to v2
* the great import update
* update runtime_api_impl_v1 to v2 as well
* guide: add `Version` request for runtime API
* add version query to runtime API
* reintroduce OldV1SessionInfo in a limited way
2022-03-09 14:01:13 -06:00
d5ddb1a809
paritydb support for parachains db. ( #4838 )
...
* parity db subsystem without cache and no splitted column
* fmt
* fix path (auto from parity-db fail)
* lru cache for db column with cache
* Revert "lru cache for db column with cache"
This reverts commit ae177bc5e107a075eff6a21f651218ada6599b74.
* Write_lock mutex
* theoric code for bridges
* revert changes
* Revert bridge changes
* fix spec_version
* update parity db
* test purge-db
* Use specific ordered collection with paritydb.
* Revert "Use specific ordered collection with paritydb."
This reverts commit 8b66d0a4ae914cba1af0f44050d45dd6d9327c6b.
* fix chain selection tests.
* remove patch
* fix auto.
* Remove useless exists directory method
* purge chain without parity-db removal
* spellcheck
* renamings and filtering.
* fix assertion
* format
* update parity-db and fmt
* Auto keep using rocksdb when it exists.
* Revert "Auto keep using rocksdb when it exists."
This reverts commit cea49b32ae590bdce31fed5c45f3c028ae0c7564.
* Update kvdb version.
2022-03-03 11:49:38 +00:00
e8cb6cdaac
Companion to "Updating scale to v3" ( #4958 )
...
* Updating dependencies
* Adapting code to scale v3
* Upgrade bitvec to 1.0.0
* Fix bitvec arithmetics
* Update Cargo.lock
* Update sp-io
* Fixing the build
* Yanked scale-info 2.0.0
Co-authored-by: Bastian Köcher <info@kchr.de >
2022-02-25 13:07:06 +01:00
d9d53c17a1
Switch to edition 2021 ( #4976 )
...
* Switch to edition 2021
* Reset bridges
* Fix compilation
* Fix test-runtime
* Fix malus
2022-02-24 10:20:58 +00:00
6fdd026010
Bump tracing from 0.1.30 to 0.1.31 ( #4941 )
...
Bumps [tracing](https://github.com/tokio-rs/tracing ) from 0.1.30 to 0.1.31.
- [Release notes](https://github.com/tokio-rs/tracing/releases )
- [Commits](https://github.com/tokio-rs/tracing/compare/tracing-0.1.30...tracing-0.1.31 )
---
updated-dependencies:
- dependency-name: tracing
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-18 09:54:13 +00:00
f00f24e656
Bump tracing from 0.1.29 to 0.1.30 ( #4897 )
...
Bumps [tracing](https://github.com/tokio-rs/tracing ) from 0.1.29 to 0.1.30.
- [Release notes](https://github.com/tokio-rs/tracing/releases )
- [Commits](https://github.com/tokio-rs/tracing/compare/tracing-0.1.29...tracing-0.1.30 )
---
updated-dependencies:
- dependency-name: tracing
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-11 23:17:19 +01:00
167df32561
Bump version ( #4904 )
...
* Bump spec_version
* Bump version to 0.9.17
2022-02-11 20:43:39 +01:00
ca81c0b50f
Bump parking_lot from 0.11.2 to 0.12.0 ( #4890 )
...
Bumps [parking_lot](https://github.com/Amanieu/parking_lot ) from 0.11.2 to 0.12.0.
- [Release notes](https://github.com/Amanieu/parking_lot/releases )
- [Changelog](https://github.com/Amanieu/parking_lot/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Amanieu/parking_lot/compare/0.11.2...0.12.0 )
---
updated-dependencies:
- dependency-name: parking_lot
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-11 10:10:20 +00:00
Andrei Sandu