Robert Klotzner
ffcde1e5e7
Fixes/improvements for disputes ( #3753 )
...
* More debugging output.
* Fix chain selection in case of disputes.
* Fix flaky test.
2021-09-01 14:25:56 -05:00
Bernhard Schuster
b85586619f
disputes: fix relay chain selection sanity check ( #3750 )
...
* Fix off-by-one bug in approval voting and adjust tests
* Address feedback
* Remove default disputes
* Remove spaces
* cargo +nightly fmt
Co-authored-by: Lldenaurois <Ljdenaurois@gmail.com >
Co-authored-by: Andronik Ordian <write@reusable.software >
2021-09-01 16:09:13 +00:00
Bernhard Schuster
4ac1e73535
remove dead_code from chain selection test ( #3685 )
...
* remove dead_code from chain selection test
Ref #3674
* remove convenience consts
* disable the test suite
It is crafted for usage _with_ disputes.
* fix lockfile
2021-08-23 13:34:44 +02:00
Bernhard Schuster
5f622ee68c
Bypass chain-selection subsystem until disputes are enabled. ( #3676 )
...
* cleanup of rob's patch
* depend on feature disputes, both lag and query
* typo
* make it work
TODO move the fallback into selection
* option
* Update node/service/src/relay_chain_selection.rs
* remove trait implementation and fix errors
* hotfix: tests
* fmt
* remove unused trait
* make pub(crate) for test
* disable tests with disputed blocks
* Fix warnings
Co-authored-by: Robert Habermeier <rphmeier@gmail.com >
Co-authored-by: Lldenaurois <Ljdenaurois@gmail.com >
2021-08-20 17:22:59 -05:00
Shawn Tabrizi
ff5d56fb76
cargo +nightly fmt ( #3540 )
...
* cargo +nightly fmt
* add cargo-fmt check to ci
* update ci
* fmt
* fmt
* skip macro
* ignore bridges
2021-08-02 10:47:33 +00:00
Bernhard Schuster
6519ba987c
integrate dispute finality ( #3484 )
...
* finality_target adjustments
* fn finality_target
* partially address review comments
* fixins
* more rustic if condition
* fix tests
* fixins
* Update node/core/approval-voting/src/lib.rs
Co-authored-by: Andronik Ordian <write@reusable.software >
* Update node/core/approval-voting/src/lib.rs
Co-authored-by: Robert Habermeier <rphmeier@gmail.com >
* review comments part one
* rename candidates -> block_descriptions
* testing outline (incomplete, WIP)
* test foo
* split RelayChainSelection into RelayChainSelection{,WithFallback}, introduce HeaderProvider{,Provider}
* make some stuff public (revert this soon™)
* some test improvements
* slips of pens
* test fixins
* add another trait abstraction
* pending edge case tests + warnings fixes
* more test cases
* fin
* chore fmt
* fix cargo.lock
* Undo obsolete changes
* // comments
* make mod pub(crate)
* fix
* minimize static bounds
* resolve number() as before
* fmt
* post merge fix
* address some nits
Co-authored-by: Andronik Ordian <write@reusable.software >
Co-authored-by: Robert Habermeier <rphmeier@gmail.com >
2021-07-26 17:54:50 +02:00