* Add skeleton for `pallet-finality-verifier`
* Sketch out implementation for importing finality proofs
* Get pallet compiling
* Introduce skeleton for mock runtime
* Start using real Grandpa types in finality pallet
* Redefine types in header chain primitives crate
* Implement HeaderChain for Substrate bridge pallet
* Plug Substrate Bridge Pallet into verifier mock
* Fix compilation of `header-chain` primitives
* Start writing to base pallet storage
* Add first "cross-pallet" test
* Move keyring primitives used in tests to shared crate
* Stop pulling `std` deps into `no_std` builds
* Revert "Stop pulling `std` deps into `no_std` builds"
This reverts commit f74dd660652f98b7336936d1534a4e63cc9169a5.
* Revert "Move keyring primitives used in tests to shared crate"
This reverts commit b774fa730b2cdc40545afff308a66b0840266001.
* Use new SS58Prefix type in mock
* Start using `bp-test-utils` in finality pallet
* Start using real justification code
* Get a test working with real justification verification
* Add basic tests for invalid proofs
* Get rid of AncestryProof config type
* Add error types to transaction outcome
* Bound number of headers allowed in a single ancestry proof
* Disallow invalid authority sets
* Remove unused items
* Add some documentation
* Get rid of Clippy warnings
* Rename BaseHeaderChain to TransactionVerifier
* Remove unused code
* Make dummy trait implementations more generic
* Fix more Clippy complaints
* Update tests to use fix for duplicate headers
* Fix benchmarking compilation
* Rename TransactionVerifier to InclusionProofVerifier
* High level docs - start.
* Clean up README
* Start adding details to high level docs
* More docs on the header sync pallet
* Testing scenarios document.
* Add some scenarios.
* Add multi-sig scenario.
* Start writing about message dispatch pallet
* Move content from old README into PoA specific doc
* Apply suggestions from code review
Co-authored-by: Andreas Doerr <adoerr@users.noreply.github.com>
* GRANDPA for consistency.
* Describe scenario steps.
* WiP
* Add notes about block production and forks
* Update.
* Add sequence diagram for Millau to Rialto transfer
* Clean up header sync pallet overview
* Remove leftover example code
* Clean up testing scenarios and amend sequence diagram.
* Linking docs.
* Add some more docs.
* Do a bit of cleanup on the high-level docs
* Clean up the testing scenario
* Fix typos in flow charts
* Fix small typo
* Fix indentation of Rust block
* Another attempt at rendering block correctly
* TIL about lazy list numbering in Markdown
* Add list numbers across sections
* Start counting from correct number
* Update README to use correct path to local scripts
* Wrap ASCII art in code block
Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
Co-authored-by: Andreas Doerr <adoerr@users.noreply.github.com>
* Copy-Pasta owner and freezing code from `message-lane`
* Halt pallet if bridge hasn't been initialized
* Make owner optional in `message-lane` pallet
* Add `is_halted` to `InitializationData`
* Fix initialization tests
* Only allow pallet to be initialized once
* Add some logging around halting and ownership changes
* Remove `target` in debugging calls
* Add dispatchable for intializing pallet
* Add Polkadot JS types for Substrate bridge pallet
* Ensure Root is the only one that can initialize the pallet
* Add some tests
* Pack initialization data into struct
* Only allow pallet to be initialized once
* Use new initialization config in nodes
* Rename ScheduledChange in Ethereum pallet
We're renaming it to prevent clashes with Substrate bridge pallet type
of the same name. This is relevant when importing types to Polkadot JS
Apps.
* Move all Polkadot JS types into one file
* Appease Clippy
* Support multiple "best headers" from different forks
* Update the name of a test
* Add note about multiple scheduled changes
* Disallow multiple scheduled authority set changes
* Return multiple best headers from Runtime APIs
* Remove invalid test write-up
* Add some sketch-ups of test scenarios
* Clean up test scenarios
* Add module for testing forks
* Write headers to storage
* Add way to check expected outcome for header imports
* Add support for importing finality proofs
* Support importing headers which schedule changes
* Write out test scenario using new framework
* Map authority set changes across forks
Gets all the tests in the `forks` module passing
* Remove basic tests
These were used when working on the initial test helper
* Prevent multiple pending set changes on the same fork
* Remove old test which allowed imports past unfinalized header
* Ignore failing test (for now)
* Rewrite `if` comparison using `match` and `cmp`
Fixes Clippy warning: `comparison_chain`
* Add helper for writing test headers with default characteristics
* Fix test that checked authority set updates
* Make note about importing headers on different unfinalized fork
* Perform some cleanup on the fork module
* Fix Clippy complaints
* Provide list of unfinalized headers to Runtime APIs
* Add proofs to expect() calls
* Make tests the focus of the forks module
* Allow specific errors to be checked in fork tests
* Remove unused method
* Replace unreachable() statement with expect()
* Rename storage `unfinalized_headers() `to make its purpose more clear
* Update Runtime API name in relayer to match pallet
* Commit `unfinalized_headers` changes I forgot to add
* Rename ChainTipHeight to BestHeight
* Make schedule_next_set_change require a mutable reference
* Remove check for key when enacting authority set
We only expect to take the happy-path in the pallet anyways, so this check
to save ourselves the time spent decoding the entry isn't really used.
* Clear justification set when writing headers to storage
* Clarify why we only allow one set change per fork
* Change best_headers() to return HeaderIDs
Prevents us from returning full headers (which are more expensive to
get from storage) since we only care about header IDs (number, hash)
anyways.
* Fix Clippy complaint
* Make note about equivocations
* Use HeaderIds when returning incomplete headers
This change stops returning full headers which are more expensive
to get from storage than header Ids (number, hash) are. Clients likely
don't need the full header anyways which is why this change is fine.
* Introduce HeaderId type to reduce type complexity
* Add signal hash to storage during genesis config
* Return error instead of expect()-ing
* Fix Clippy lint about `ok_or` fn call
* Rename `forks` module to indicate that it's for testing
* Use `const` for `expect()` proofs
* Remove check that key exists before `kill`-ing value
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
* Remove the Substrate primitives crate
The types here were only used in one place, the pallet itself. If other
components start using these types we can considering moving them back
into a standalone crate.
* Start trying to integrate justification module
* Make Substrate blocks configurable in Pallet
* WIP: Try and generalize justification test helpers
* Fix tests which use "real" justifications
* Put common test helpers alongside mock code
* Use common helper for creating headers
* Remove usage of UintAuthorityId
This change favours the use of the Ed25519Keyring authorities
in order to keep things consistent with the tests.
* Add documentation around config trait types
* Make test header, hash, and number types consistent
* Update modules/substrate/src/verifier.rs
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
* Update modules/substrate/src/lib.rs
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
* Update modules/substrate/Cargo.toml
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
* Derive `RuntimeDebug` instead of `Debug`
* Add `Paramter` as a trait constraint on config types
Since we use these types as part of the dispatchable functions
we should explicitly require this.
* Enforce that hasher output matches expected hash type
* Accept headers over indexes when making test justifications
* Check that authority sets are valid
* Make Clippy happy
* Apply correct Clippy fix
* Move justification code into primitives module
* Use new module in verifier code
* Add primitives module for Substrate test helpers
* WIP
* Move justification generation into test_helpers
* Revert commits which move `justification` into primitives
This reverts commit 03a381f0bc4a8dbe4785c30d42ab252a06ba876c.
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
Hernando Castano